http://bugs.winehq.org/show_bug.cgi?id=27264
Summary: Silent Hill 2 menu Product: Wine Version: 1.3.19 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: ardolynk@telegraf.by
In SH2, main menu and other UI elements are invisible (still OK in 1.3.18).
http://bugs.winehq.org/show_bug.cgi?id=27264
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Silent Hill 2 menu |Silent Hill 2 menu | |invisible
--- Comment #1 from Juan Lang juan_lang@yahoo.com 2011-05-23 10:48:57 CDT --- Please perform a regression test: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=27264
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #2 from Ardolynk ardolynk@telegraf.by 2011-05-24 15:36:03 CDT --- 96b758f7b37033bf382ce40dd3310965d3ac3f76 is the first bad commit commit 96b758f7b37033bf382ce40dd3310965d3ac3f76 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu Apr 21 22:36:11 2011 +0200
d3d: Map D3DRS_ZBIAS to WINED3DRS_DEPTHBIAS.
ZBIAS was removed in d3d9 and replaced with DEPTHBIAS. Currently wined3d implements both independently which will cause trouble if we want to set the depthbias value depending on the depth stencil format.
:040000 040000 14659e4a25f6e8f7d7cee165cbdc6690e3349ba0 12e71355fbcd1fd575e308dc1ba3e018cca97f05 M dlls :040000 040000 dc3104a0db5f013d6ea6c4ab4865d61d26065310 a70d788d0a8919d70846681550c830bee08fe213 M include
http://bugs.winehq.org/show_bug.cgi?id=27264
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefandoesinger@gmx.at Component|-unknown |directx-d3d
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #3 from Stefan Dösinger stefandoesinger@gmx.at 2011-05-24 16:41:22 CDT --- Does this bug still occur in 1.3.20? I sent a patch a while ago that was supposed to fix a regression caused by 96b758f7b37033bf382ce40dd3310965d3ac3f76.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #4 from Ardolynk ardolynk@telegraf.by 2011-05-24 23:35:35 CDT --- (In reply to comment #3)
Does this bug still occur in 1.3.20?
Yes. Just launch Silent Hill 2 and make sure. My video card is NVidia GeForce GTS 250.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #5 from Stefan Dösinger stefandoesinger@gmx.at 2011-05-25 02:17:46 CDT --- Is there a demo somewhere? I don't have this game.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #6 from Ardolynk ardolynk@telegraf.by 2011-05-25 03:37:56 CDT --- Looks like SH2 demo isn't available for public download. Check your mail for some details ;-) Alternatively, you can post your latest patch (or commit ID if any) to let me closer to this issue.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #7 from Stefan Dösinger stefandoesinger@gmx.at 2011-05-25 03:59:23 CDT --- a1519e62f47f2dfa54ca526ee718fe8a936593f2 is the patch that was supposed to fix the regressions. You could try to play with a smaller or bigger zbias_factor. Also take a look at the ZBIAS values the app sets.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #8 from Ardolynk ardolynk@telegraf.by 2011-05-25 16:53:59 CDT --- (In reply to comment #7)
You could try to play with a smaller or bigger zbias_factor.
I realized that the game looks properly when there is POSITIVE value of zbias_factor (0.000005f) defined in dlls/d3d8/device.c
Also take a look at the ZBIAS values the app sets.
How to do this? Sorry for my ignorance.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #9 from Stefan Dösinger stefandoesinger@gmx.at 2011-05-25 17:00:52 CDT --- the easiest way is to add some statement like
ERR("zbias set to %u\n", Value);
In the case block that handles D3DRS_ZBIAS.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #10 from Ardolynk ardolynk@telegraf.by 2011-05-26 00:04:42 CDT --- Thanks, I put the output statement into SetRenderState. In SH2 there is an interlacing of 0 and 1 values.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #11 from Ardolynk ardolynk@telegraf.by 2011-05-27 02:19:52 CDT --- Bump. Let's summarize the application's behaviour. D3DRS_ZBIAS oulput looks like
... zbias set to 0 zbias set to 1 zbias set to 0 zbias set to 1 ...
Main menu disappears when we allow ZBIAS to be handled and use negative zbias_factor. What's reasonable to do with that? Is there any "robust" D3DRS_ZBIAS value range we need to handle (and ignore the rest)?
http://bugs.winehq.org/show_bug.cgi?id=27264
Aleksey Inozemcew inozemcew@i.ua changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |inozemcew@i.ua
--- Comment #12 from Aleksey Inozemcew inozemcew@i.ua 2011-06-25 11:25:56 CDT --- wine-1.3.23: bug still present.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #13 from Henri Verbeet hverbeet@gmail.com 2011-07-03 01:44:26 CDT --- This is probably similar to bug 27263, does http://bugs2.winehq.org/attachment.cgi?id=35410 make it any better?
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #14 from Henri Verbeet hverbeet@gmail.com 2011-07-05 13:05:33 CDT --- (In reply to comment #13)
This is probably similar to bug 27263, does http://bugs2.winehq.org/attachment.cgi?id=35410 make it any better?
That patch is now in git as ddc29c40e66f686190a40ac4bc2578e81785f56f.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #15 from Aleksey Inozemcew inozemcew@i.ua 2011-07-08 17:40:45 CDT --- wine-1.3.24: bug still present.
http://bugs.winehq.org/show_bug.cgi?id=27264
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |wylda@volny.cz Ever Confirmed|0 |1
--- Comment #16 from Wylda wylda@volny.cz 2011-07-09 05:22:06 CDT ---
I can confirm this too. Stefan or Henri could you provide a patch for 1.3.18 which would dump that Z values and similar patch for 1.3.24 so we could compare the values and maybe find some miscalculation? Sorry if total nonsense ;)
http://bugs.winehq.org/show_bug.cgi?id=27264
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |96b758f7b37033bf382ce40dd33 | |10965d3ac3f76
http://bugs.winehq.org/show_bug.cgi?id=27264
Stefan Dösinger stefan@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan@codeweavers.com
--- Comment #17 from Stefan Dösinger stefan@codeweavers.com 2011-10-15 10:17:47 CDT --- I see why the game is broken now, and why it worked before, but I don't yet know a proper fix.
The game draws the broken parts of the menu at z = 0.0: err:d3d:position_float4 Position 471.250000 433.000031 0.000000 1.000000
This is right at the near clip plane. If the z would be any less the geometry would be discarded. The game sets ZBIAS to 0x00000001, which is supposed to move the geometry closer to the camera. To get the result in GL we set glPolygonOffset to -1.0. This does cause the geometry to be clipped by the near clipping plane.
Prior to my patch this used to work because we interpreted the DWORD value 0x00000001 as float, which is a really tiny value, much smaller than 1.0. This didn't make sense because even the highest possible ZBIAS(15) would be a way too small offset, so ZBIAS was essentially disabled prior to my patch. Now that we give the app what it asks for it breaks.
I'm not sure why it is working on Windows(or supposed to work, didn't test yet). Most likely it is because it is using pretransformed geometry and ZBIAS isn't applied in that case. Or ZBIAS is applied after clipping(unlikely). Or a zbias value of 1 is supposed to be so small that it doesn't have any effect at all. This will need some tests.
There are some parts of the main menu that still work, e.g. the mouse pointer, the main menu and the new game menu. Those are drawn at z=0.01. What's not working is the fade-in/fade-out animation and the text in the options menu.
http://bugs.winehq.org/show_bug.cgi?id=27264
--- Comment #18 from Henri Verbeet hverbeet@gmail.com 2012-02-16 06:40:43 CST --- Does the patch attached to bug 28404 make any difference?
http://bugs.winehq.org/show_bug.cgi?id=27264
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d17f037fb11b8a654a38040aaef | |bdce5f2358963 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #19 from Wylda wylda@volny.cz 2012-05-12 00:01:58 CDT ---
Fixed by d17f037fb11b8a654a38040aaefbdce5f2358963 (wine-1.4-rc4-64-gd17f037).
Thank you Henri!
http://bugs.winehq.org/show_bug.cgi?id=27264
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org 2012-05-25 13:43:30 CDT --- Closing bugs fixed in 1.5.5.
-
wine-bugs＠winehq.org