https://bugs.winehq.org/show_bug.cgi?id=49841
Bug ID: 49841 Summary: Building with "-sw" doesn't show sub directories anymore Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: trivial Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: dark.shadow4@web.de Distribution: ---
I usually build wine with "make -sw". Starting with commit 8a5e603000c1337657b1e3256284c1f9b4e84581, this doesn't work anymore. The console only shows "make: Entering directory '/home/fabian/Programming/Wine/wine'" but not the subdirectories anymore.
Is this an intentional breakage or can this be fixed?
https://bugs.winehq.org/show_bug.cgi?id=49841
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |8a5e603000c1337657b1e325628 | |4c1f9b4e84581 Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=49841
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com Version|unspecified |5.17 Component|-unknown |build-env
--- Comment #1 from Zebediah Figura z.figura12@gmail.com --- I don't think it can exist in the same form, since the makefile no longer really has a concept of subdirectories, and is essentially free to build the targets in any order (modulo dependencies, of course).
I used these options as well, essentially as a way to gauge make's progress (by judging how far through the alphabet it is) while avoiding printing every command verbatim (because gcc command lines are very long, containing mostly redundant information, and it's thus harder to find the source filename and harder to pick out compiler errors).
If this is all that is desired by the reporter as well (and anyone else who misses the old behaviour of -s -w), I think a probably sufficient solution would be to introduce automake-style "silent rules", i.e. output like the following:
CC libs/vkd3d/command.lo CC libs/vkd3d/device.lo CC libs/vkd3d/resource.lo CC libs/vkd3d/state.lo CC libs/vkd3d/utils.lo CC libs/vkd3d/vkd3d_main.lo CC libs/vkd3d-utils/vkd3d_utils_main.lo GEN libvkd3d.pc
https://bugs.winehq.org/show_bug.cgi?id=49841
--- Comment #2 from Fabian Maurer dark.shadow4@web.de ---
If this is all that is desired by the reporter as well (and anyone else who misses the old behaviour of -s -w), I think a probably sufficient solution would be to introduce automake-style "silent rules", i.e. output like the following
Exactly that's what I used it for as well, that would be great!
https://bugs.winehq.org/show_bug.cgi?id=49841
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com
--- Comment #3 from Vijay Kamuju infyquest@gmail.com --- fix committed. test with wine 6.0 rc2 https://source.winehq.org/git/wine.git/commitdiff/1a16b9e9aa9a3ea1d0b5adbfa5...
https://bugs.winehq.org/show_bug.cgi?id=49841
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |1a16b9e9aa9a3ea1d0b5adbfa5f | |b6c83d99a06bb Resolution|--- |FIXED
--- Comment #4 from Fabian Maurer dark.shadow4@web.de --- Looking great, thanks! They always have to be enabled by passing "--enable-silent-rules" to configure?
https://bugs.winehq.org/show_bug.cgi?id=49841
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement Summary|Building with "-sw" doesn't |Provide an intermediate |show sub directories |level of make output |anymore |
https://bugs.winehq.org/show_bug.cgi?id=49841
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.0-rc3.
https://bugs.winehq.org/show_bug.cgi?id=49841
Mathew Hodson mathew.hodson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mathew.hodson@gmail.com
--- Comment #6 from Mathew Hodson mathew.hodson@gmail.com --- Hey Fabian, the regression commit is not right. It should be commit 1dd3051cca5cafe90ce44460731df61abb680b3b
Can you update the field in the bug?
https://bugs.winehq.org/show_bug.cgi?id=49841
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|8a5e603000c1337657b1e325628 |1dd3051cca5cafe90ce44460731 |4c1f9b4e84581 |df61abb680b3b
https://bugs.winehq.org/show_bug.cgi?id=49841
Mathew Hodson mathew.hodson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|mathew.hodson@gmail.com |