[Bug 17528] New: 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

Summary: 3D Mark 2001 SE Dragothic: Textures not rendered on
                    running humans
           Product: Wine
           Version: 1.1.15
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=19644)
 --> (http://bugs.winehq.org/attachment.cgi?id=19644)
dragothic low detail test run

I don't know when this error started but I can remember wine rendering these
textures long time ago but now I noticed that they aren't. I don't see anything
in log that seems like related to this but attached log when only running the
Dragothic test.

radeon-m 9200 (r280)

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #1 from Pauli Nieminen   2009-02-25 04:13:13 ---
Created an attachment (id=19645)
 --> (http://bugs.winehq.org/attachment.cgi?id=19645)
Start and close log file for comparision which messages are coming from the
test case

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #2 from Pauli Nieminen   2009-02-27 05:09:30 ---
So this is bug in rendering of strided objects if pixel shader support is
disabled. It seems like this has been always around there so it isn't
regression at least.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

Pauli Nieminen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Pauli Nieminen   2009-02-27 17:58:25 ---
693d9ded47d56846c3dafe7d04115a4f3a01750a is first bad commit
commit 693d9ded47d56846c3dafe7d04115a4f3a01750a
Author: Stefan Dösinger 
Date:   Sat Jan 10 02:29:39 2009 +0100

wined3d: Properly set the fog frag coord according to the FOGTABLEMODE.

This also fixes the test that an earlier patch broke, so the todo_wine can
be
    removed again.

:040000 040000 d6c96e24ebde7212191b4113d6d55a1bdcd073f1
745e7693925a3ab9384ff77141aad74d082bc23e M      dlls

This commit caused strided objects to turn transparent.
fixme:d3d_draw:drawStridedFast >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from glDrawElements @ drawprim.c / 276

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #4 from Pauli Nieminen   2009-02-27 18:05:16 ---
PS. real bug is this:
fixme:d3d_shader:shader_arb_generate_vshader HW VertexShader Error at position
1543: "Too many parameter variables"

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #5 from Stefan Dösinger   2009-02-28 05:04:25 ---
Probably we stepped on the driver's toe and forced it to use a shader constant
for its own use. The only line I can imagine is this one:

shader_addline(buffer, "MOV result.fogcoord, 0.0;\n");

0.0 may require a constant to load the immediate value. What happens if you
comment out this line? There are alternative ways to say "0.0" that doesn't
need an implicit value, for example

shader_addline(buffer, MOV result.fogcoord, helper_const.w;\n");

Since helper_const = { 2.0, -1.0, XX.0, 0.0 }

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #6 from Pauli Nieminen   2009-02-28 05:41:31 ---
0.0 is the offender.

I did use helper_const.w and now everything renders.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #7 from Stefan Dösinger   2009-02-28 08:05:47 ---
Feel free to send a patch ;-)

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #8 from Stefan Dösinger   2009-02-28 08:06:52 ---
Actually, it might also be worthwile to report a bug to mesa. The driver might
as well recognize that it is loading 0.0 two times and optimize one of the uses
away and save the constant.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #9 from François Gouget   2009-04-23 05:40:55 ---
I am getting a very similar error with Flatout 2 on my Intel 945GME card:

fixme:d3d:IWineD3DDeviceImpl_EvictManagedResources (0x16c030) : stub
fixme:d3d_shader:shader_arb_generate_vshader HW VertexShader Error at position
435: "Too many parameter variables"

Mason did you report this issue to anyone? Do you have a link to the
corresponding bug report?
Where should this issue be reported?

---

Wine 1.1.19
xserver-xorg-video-intel             2:2.3.2-2+lenny6
Flatout 2 Demo: http://www.gamershell.com/download_16702.shtml

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #10 from François Gouget   2009-04-23 05:45:36 ---
The helper_const.w patch also gets Flatout 2 to start so I'm sending it to
WineHQ.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #11 from H. Verbeet   2009-04-23 06:23:04 ---
(In reply to comment #9)
> Where should this issue be reported?

Mesa/DRI bugs should go to https://bugs.freedesktop.org/, product Mesa. I think
the component for Intel 945 would be Drivers/DRI/i915. This would probably be a
core Mesa enhancement though.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #12 from François Gouget   2009-04-23 08:59:01 ---
I have reported this bug to the Mesa developpers:
 * Bug 21354 - Better optimize loading constants in VertexShaders
   https://bugs.freedesktop.org/show_bug.cgi?id=21354

Feel free to chime in and fix any mistake I might have made.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #13 from François Gouget   2009-04-23 09:01:12 ---
I have also retested Dragothic and while I think there are still some textures
missing on the running humans, at least now I see them and I also see the
dragon, and also the characters in the Lobby. This was not the case before!

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

--- Comment #14 from François Gouget   2009-04-23 09:36:39 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2009-April/072222.html

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from François Gouget   2009-04-23 15:56:45 ---
The patch was committed. So I'm marking this as Resolved.

[Bug 17528] 3D Mark 2001 SE Dragothic: Textures not rendered on running humans

http://bugs.winehq.org/show_bug.cgi?id=17528

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2009-04-24 12:20:56 ---
Closing bugs fixed in 1.1.20.