[Bug 24668] New: Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

Summary: Introduction screen in Melty Blood is drawn
                    upside-down
           Product: Wine
           Version: 1.3.4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=31183)
 --> (http://bugs.winehq.org/attachment.cgi?id=31183)
Terminal output in wine-1.3.4-202-g47d2a00

In wine-1.3.4-202-g47d2a00 introduction screen and fighting scenes in Melty
Blood are rendered upside down. These were drawn correctly in wine 1.3.4.

A regression test yields the following result:

5fa84c56c344927dcb13b12409fbf64d738438f4 is the first bad commit
commit 5fa84c56c344927dcb13b12409fbf64d738438f4
Author: Henri Verbeet 
Date:   Tue Oct 5 14:32:35 2010 +0200

ddraw: Remove another hack.

It breaks actual front buffer / back buffer flips.

:040000 040000 3b85800dcfb6069dc55abe0daa21e63694c1d600
5add7ba691e5b542e503ea14b373af3b9a569a36 M    dlls
:040000 040000 dd04818a2c84caaf8d64932e313154e159ad5621
205e27a6da9999ca94a47e7bedffbb4b0d02e0c5 M    include

Reverting this commit makes the screens be drawn correctly. Apparently this
game depended on the ddraw hack mentioned in the commit.

The biggest differences in error logs is that the terminal now is spammed with
many occurrences of:
fixme:d3d:context_apply_blit_state Applying blit state for an offscreen target
with ORM_FBO. This should be avoided.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #1 from [e-mail] 2010-10-08 05:16:18 CDT ---
Created an attachment (id=31184)
 --> (http://bugs.winehq.org/attachment.cgi?id=31184)
Terminal output with ddraw patch reverted

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Wylda  2010-10-08 05:37:53 CDT ---

Hmmm... I guess that removing of this hack shifted you game into different code
path and you jumped into bug 23173.

So probably duplicate, if Henri does not have a different opinion.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #3 from Henri Verbeet  2010-10-08 07:49:34 CDT ---
Sounds plausible. But anyway, does this have a demo / free download?

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #4 from [e-mail] 2010-10-09 06:32:55 CDT ---
(In reply to comment #3)
> Sounds plausible. But anyway, does this have a demo / free download?

No demo that I can find.

Setting ORM to 'backbuffer' as suggested in bug 23173 does not help, screen is
still upside down.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #5 from Andrew Millington  2010-10-09 07:00:22 CDT ---
http://mirrormoon.org/projects/melty_blood
Is this the game you are talking about?

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://mirrormoon.org/proje
                   |                            |cts/melty_blood

--- Comment #6 from [e-mail] 2010-10-09 07:50:26 CDT ---
(In reply to comment #5)
> http://mirrormoon.org/projects/melty_blood
> Is this the game you are talking about?

Yes. Thank you, the demo there also shows the upside down screen. Adding url.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

--- Comment #7 from Wylda  2010-10-09 07:59:37 CDT ---
> Setting ORM to 'backbuffer' as suggested in bug 23173 does not help, screen is
> still upside down.

Then this could be truly separate problem. Filling few keywords.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #8 from Henri Verbeet  2010-10-14 12:54:47 CDT ---
Created an attachment (id=31271)
 --> (http://bugs.winehq.org/attachment.cgi?id=31271)
patch

Please give this patch a try. Note that the issue only occurs in windowed mode.

@Wylda: The bug looks generic enough that it might still turn out to be a
duplicate of bug 23173, so you might want to give that one a try as well.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #9 from [e-mail] 2010-10-14 17:00:27 CDT ---
(In reply to comment #8)
> Created an attachment (id=31271)

--> (http://bugs.winehq.org/attachment.cgi?id=31271) [details]
> patch
>
> Please give this patch a try. Note that the issue only occurs in windowed mode.

This patch is a step in the right direction. Introduction screen is now
rendered correctly.

The only remaining issue is that special effects in some fighting scenes are
placed incorrectly (see attachment for an example where some flags supposed to
be on the top of the screen are placed on the bottom when the patch is
applied). This can be worked around by setting "BG Rendering" to "simple" in
the game options.

This only affects the full version of the game, the stages in the demo uses no
such special effects.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

--- Comment #10 from [e-mail] 2010-10-14 17:02:26 CDT ---
Created an attachment (id=31274)
 --> (http://bugs.winehq.org/attachment.cgi?id=31274)
Some objects placed incorrectly even with the patch applied

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from [e-mail] 2010-10-16 00:55:52 CDT ---
This bug is fixed in 1.3.5 by commit 1fa3365832e35c42a20d7b40ef47bdb1d99c7f3f.
All graphics are now placed correctly. Thank you, Henri.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2010-10-29 12:58:11 CDT ---
Closing bugs fixed in 1.3.6.

[Bug 24668] Introduction screen in Melty Blood is drawn upside-down

http://bugs.winehq.org/show_bug.cgi?id=24668

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d