[Bug 22501] New: Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Summary: Bioshock won't run without native msvcp80.dll
           Product: Wine
           Version: 1.1.43
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Workaround is winetricks vcrun2005

This is not easy to fix, but we should have a bug for it nonetheless,
even if we mark it WONTFIX.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #1 from Austin English   2010-04-26 23:46:28 ---
I don't see why it should be a WONTFIX, if we've already got msvcr70/80/90/etc.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #2 from Dan Kegel   2010-04-27 07:46:26 ---
It's relatively more difficult, and would have to be compiled with
visual c++, at least until gcc learns visual c++'s ABI, which seems
a remote prospect.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #3 from Dan Kegel   2010-05-15 22:01:30 ---
Starcraft II also suffers from this, but winedump -j imports seems to show it 
only needs six functions:

1637  ?compare@?$char_traits@D@std@@SAHPBD0I@Z 
  1498  ?_Xlen@_String_base@std@@SAXXZ 
  1499  ?_Xran@_String_base@std@@SAXXZ 
   377 
??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@PBD@Z 
   606  ??1?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@XZ 
   370 
??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@ABV01@@Z

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #4 from Dan Kegel   2010-05-15 22:05:51 ---
Oh, and this function, too:
  1581 
?c_str@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEPBDXZ

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Piotr Caban   2010-05-26 16:49:38 ---
Adding demangled names (so it's easier to read):

static int __cdecl std::char_traits<char>::compare(char const *,char const
*,unsigned int)

static void __cdecl std::_String_base::_Xlen(void)
static void __cdecl std::_String_base::_Xran(void)

__thiscall std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >(char const *)

__thiscall std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >::~basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >(void)

__thiscall std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >(class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > const &)

public: char const * __thiscall std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> >::c_str(void)const

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #6 from Piotr Caban   2010-06-14 13:37:15 ---
Partial implementation of msvcp90 attached in bug 23126. It has all functions
needed by this application implemented.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jeff Zaroyko   2010-07-18 17:58:11 ---
*** Bug 23693 has been marked as a duplicate of this bug. ***

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

alaukik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #8 from Piotr Caban   2010-08-24 12:43:40 ---
Msvcp80 is now in Wine, please retest with newest git.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #9 from Austin English   2010-08-24 18:19:35 ---
(In reply to comment #8)
> Msvcp80 is now in Wine, please retest with newest git.

wine: Call from 0x7ed82e29 to unimplemented function
msvcp80.dll.??0?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAE@XZ,
aborting

wine-1.3.1-135-g2c127dd

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Wylda  2010-08-28 06:29:45 CDT ---

Does not happen to me. No winetricks used except "mouse trick". Probably fixed.

Wine: wine-1.3.1-267-g7ab48e8

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #11 from Austin English  2010-08-30 00:14:51 CDT ---
(In reply to comment #10)
> Does not happen to me. No winetricks used except "mouse trick". Probably fixed.
>
> Wine: wine-1.3.1-267-g7ab48e8

You need to set msvcp80 to builtin in winecfg.

See also
http://source.winehq.org/git/wine.git/?a=blob;f=dlls/msvcp80/msvcp80.spec#l8...

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #12 from Piotr Caban  2010-08-30 04:54:34 CDT ---
It looks that there are few versions of the game. Some of them use unicode
functions. It's why builtin msvcp80 is working for some people. I'm working on
implementing missing functions.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #13 from Piotr Caban  2010-08-30 09:48:46 CDT ---
I've sent patches that may fix the game for more people
(http://source.winehq.org/patches/data/65588). Please retest when the patches
get into Wine.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #14 from Austin English  2010-08-30 13:35:06 CDT ---
(In reply to comment #13)
> I've sent patches that may fix the game for more people
> (http://source.winehq.org/patches/data/65588). Please retest when the patches
> get into Wine.

Getting closer. Now crashes on:
resize@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEXI@Z

I tried running winedump -j imports Bioshock.exe (as well as the other dll's in
the directory), but didn't get anything. Perhaps I'm doing it wrong..

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #15 from Austin English  2010-08-30 13:56:12 CDT ---
(In reply to comment #14)
> I tried running winedump -j imports Bioshock.exe (as well as the other dll's in
> the directory), but didn't get anything. Perhaps I'm doing it wrong..

Should be 'winedump -j import Bioshock.exe'. There's 19 missing for my version
of Bioshock:
?data@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEPBDXZ
?size@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEIXZ
??4?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAAV01@ABV01@@Z
??4?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAAV01@ABV01@@Z
??$?M_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA_NABV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@0@Z
?size@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QBEIXZ
??0?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAE@ABV01@II@Z
?find@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QBEI_WI@Z
??$?H_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@ABV10@PB_W@Z
??$?H_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@ABV10@0@Z
??Y?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAAV01@_W@Z
?at@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAA_WI@Z
??A?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAADI@Z
?resize@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEXI@Z
??A?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAA_WI@Z
?resize@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEXI@Z
??4?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAAV01@PBD@Z
?compare@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEHIIPBDI@Z
?append@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAAV12@PBD@Z

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msvcp

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #16 from Wylda  2010-09-18 21:27:06 CDT ---

Under wine-1.3.3 builtin msvcp80.dll is still missing:

resize@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEXI@Z

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24927

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #17 from Piotr Caban  2010-11-21 06:39:46 CST ---
Updated list of missing functions:
??$?M_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA_NABV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@0@Z
??0?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAE@ABV01@II@Z
?find@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QBEI_WI@Z
??$?H_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@ABV10@PB_W@Z
??$?H_WU?$char_traits@_W@std@@V?$allocator@_W@1@@std@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@0@ABV10@0@Z
??Y?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAAV01@_W@Z
?at@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAA_WI@Z
??A?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAADI@Z
?resize@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEXI@Z
??A?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEAA_WI@Z
?resize@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEXI@Z
?compare@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEHIIPBDI@Z
?append@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEAAV12@PBD@Z

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #18 from Austin English  2011-04-20 20:52:52 CDT ---
In git, crashes on
?resize@?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@QAEXI@Z

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Andrew Millington  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Andrew Millington  2011-04-29 20:33:08 CDT ---
It works for me with wine-1.3.19, please test it with this version.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

--- Comment #20 from Piotr Caban  2011-04-30 02:19:27 CDT ---
(In reply to comment #19)
> It works for me with wine-1.3.19, please test it with this version.

Yesterday I've sent patches that were intended to fix this bug. All functions
mentioned in this bug are now implemented in wine.

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from Austin English  2011-05-01 21:38:38 CDT ---
Looks good here as well, thanks!

[Bug 22501] Bioshock won't run without native msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=22501

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Alexandre Julliard  2011-05-13 13:34:02 CDT ---
Closing bugs fixed in 1.3.20.