[Bug 48113] New: The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

Bug ID: 48113
           Summary: The -mno-cygwin option should be abandoned.
           Product: Wine
           Version: 4.20
          Hardware: x86
                OS: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
          Assignee: [e-mail]
          Reporter: [e-mail]

With reference to bugs #47959 and #47951, I think that the "-mno-cygwin" option
should be abandoned, since it is no more functional by long time.

In the past, this option was used for telling GCC if executables and DLLs
depended on POSIX layer or they were just plain executables for Windows.
This option has been obsoleted since the transition from gcc3 to gcc4 and
deprecated since GCC 4.7.
Modern build tools for CYGWIN make only objects linked with POSIX layer and
cross compilers from MINGW-W64 are included for both 32 and 64 bit platforms.
Building WINE for running natively on Windows requires to follow the same
method typically used when doing a cross compile, on CYGWIN but also in MSYS2.
This will also fix this error:

gcc: error: unrecognized command line option '-mno-cygwin'

that you get when you start to build.

Question: this is the content of a simple Makefile.in:

<================================

MODULE    = acledit.dll

EXTRADLLFLAGS = -mno-cygwin

C_SRCS = \
    main.c

================================>

Assuming that somebody will provide this change and since EXTRADLLFLAGS is
typically used only for "-mno-cygwin", is it required to keep the presence of
an empty EXTRADLLFLAGS or it can be deleted from the Makefile.in?

Thanks.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #1 from Alexandre Julliard  ---
(In reply to Carlo Bramini from comment #0)
> With reference to bugs #47959 and #47951, I think that the "-mno-cygwin"
> option should be abandoned, since it is no more functional by long time.

The option is very much functional. There may well be some breakage specific to
the Cygwin environment, but removing the option is not the solution.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #2 from Carlo Bramini  ---
Created attachment 65699
  --> https://bugs.winehq.org/attachment.cgi?id=65699
Console output of "gcc -mno-cygwin"

Thank you for your quick reply.
Perhaps I'm doing something wrong, but this is what I get if I try to call gcc
with -mno-cygwin option.
Sincerely.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #3 from Alexandre Julliard  ---
(In reply to Carlo Bramini from comment #2)
> Created attachment 65699 [details]
> Console output of "gcc -mno-cygwin"
>
> Thank you for your quick reply.
> Perhaps I'm doing something wrong, but this is what I get if I try to call
> gcc with -mno-cygwin option.

You shouldn't do that. The option is meant for winegcc. If it gets passed
through to gcc that's a winegcc bug.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEEDINFO

--- Comment #4 from Ken Sharp  ---
Need to confirm if there is a bug or not.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #5 from Carlo Bramini  ---
> The option is meant for winegcc. If it gets passed through to gcc that's a winegcc bug.

Excuse me, evidently it was my misunderstand.
Sorry for the trouble.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #6 from Carlo Bramini  ---
I tried to rebuild everything and it seems that I have made a mistake.
The error was raised by -municode and not by -mno-cygwin:

../../tools/winegcc/winegcc.exe -o arp.exe --wine-objdir ../..
-Wl,--disable-std
call-fixup \
  -fasynchronous-unwind-tables -mconsole -municode -mno-cygwin main.o
gcc: error: unrecognized command line option GÇÿ-municodeGÇÖ
winegcc: gcc failed
make: *** [Makefile:196: arp.exe] Error 2

I don't know why, but it seems that my eyes slipped on the wrong option.
Please excuse me again. You can close this issue if you want.
Sincerely.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #7 from Saulius K.  ---
Carlo, have you reported the "-municode" bug?
Could this report be safely closed now?

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #8 from Carlo Bramini  ---
(In reply to Saulius K. from comment #7)
> Carlo, have you reported the "-municode" bug?
> Could this report be safely closed now?

Is it the same thing if I rename the title of this bug?

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #9 from Saulius K.  ---
Carlo, if this is still valid, I would open new bug report for that.

This bugreport then would remain useful as direct reference to how
'-mno-cygwin' work.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #10 from Carlo Bramini  ---
Hello, I verified that the problem still exists.
Tested with:

$ uname -a
CYGWIN_NT-10.0 LAPTOP-658U9K2I 3.3.3(0.341/5/3) 2021-12-03 16:35 x86_64 Cygwin

$ gcc --version
gcc (GCC) 11.2.0

I have to say that, after long time, I tried to build again with CYGWIN and
unfortunately the build process hangs for other errors before reaching this
point.
Many things seem to not build anymore.
However, you can still reproduce the bug by doing a "cd programs/arp" (or one
of the other programs could be used) and launching "make" directly from that
directory.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

--- Comment #11 from Saulius K.  ---
(This is continuation from the bug 52607)

After applying the fix [1] inspired by the earlier one from Alexandre [2], I
get the same error as Carlo:

--- snip ---
tools/winegcc/winegcc.exe -o dlls/ntdll/ntdll.dll --wine-objdir .
-Wl,--disable-stdcall-fixup \
  -fasynchronous-unwind-tables -shared dlls/ntdll/ntdll.spec -nodefaultlibs \
  -Wl,--image-base,0x7bc00000 -mno-cygwin dlls/ntdll/actctx.o dlls/ntdll/atom.o
dlls/ntdll/crypt.o \
  dlls/ntdll/debugbuffer.o dlls/ntdll/env.o dlls/ntdll/error.o
dlls/ntdll/exception.o \
  dlls/ntdll/handletable.o dlls/ntdll/heap.o dlls/ntdll/large_int.o
dlls/ntdll/loader.o \
  dlls/ntdll/locale.o dlls/ntdll/math.o dlls/ntdll/misc.o dlls/ntdll/path.o
dlls/ntdll/printf.o \
  dlls/ntdll/process.o dlls/ntdll/reg.o dlls/ntdll/relay.o
dlls/ntdll/resource.o dlls/ntdll/rtl.o \
  dlls/ntdll/rtlbitmap.o dlls/ntdll/rtlstr.o dlls/ntdll/sec.o
dlls/ntdll/signal_arm.o \
  dlls/ntdll/signal_arm64.o dlls/ntdll/signal_i386.o dlls/ntdll/signal_x86_64.o
dlls/ntdll/string.o \
  dlls/ntdll/sync.o dlls/ntdll/thread.o dlls/ntdll/threadpool.o
dlls/ntdll/time.o \
  dlls/ntdll/version.o dlls/ntdll/wcstring.o dlls/ntdll/version.res
dlls/winecrt0/libwinecrt0.a \

tools/winegcc/winegcc.exe -o programs/arp/arp.exe --wine-objdir .
-Wl,--disable-stdcall-fixup \
  -fasynchronous-unwind-tables -mconsole -municode -mno-cygwin
programs/arp/main.o \
  dlls/winecrt0/libwinecrt0.a dlls/ucrtbase/libucrtbase.a
dlls/kernel32/libkernel32.a \
  dlls/ntdll/libntdll.a
gcc: error: unrecognized command-line option ‘-municode’
winegcc: /usr/bin/gcc.exe failed
make: *** [Makefile:156236: programs/arp/arp.exe] Error 2
--- snip ---

As `-municode` gets passed through to gcc, it's a bug in winegcc judging by
Alexandre in comment #3 circa 2019-11-16:
> (In reply to Carlo Bramini from comment #2)
> > Perhaps I'm doing something wrong, but this is what I get if I try to call
> > gcc with -mno-cygwin option.
>
> You shouldn't do that. The option is meant for winegcc. If it gets passed
> through to gcc that's a winegcc bug.

Ping Alexandre.

[1]https://www.winehq.org/pipermail/wine-devel/2022-February/209575.html
[2]https://source.winehq.org/git/wine.git/commitdiff/49ee0f58e8e1f993c2fb91c088...

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #12 from Ken Sharp  ---
The reported "bug" is not a bug. Invalid.

[Bug 48113] The -mno-cygwin option should be abandoned.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48113

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Gijs Vermeulen  ---
Closing.