http://bugs.winehq.org/show_bug.cgi?id=35630
Bug ID: 35630 Summary: SHCreateSessionKey is unimplemented Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs@winehq.org Reporter: gonzomdx@gmail.com
While testing the new upcoming shell from ReactOS I found out that the following function is unimplemented: SHCreateSessionKey()
I know that you don't like to use ROS Code but maybe this would be usefull: http://doxygen.reactos.org/d4/d5c/base_2shell_2explorer_2services_2startup_8...
I also attached a Backtrace for the case that there is something else wrong too.
http://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #1 from gonzomdx@gmail.com --- Created attachment 47586 --> http://bugs.winehq.org/attachment.cgi?id=47586 backtrace
http://bugs.winehq.org/show_bug.cgi?id=35630
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Bruno Jesus 00cpxxx@gmail.com --- There is a patch already in the list awaiting for review: http://source.winehq.org/patches/data/102530
https://bugs.winehq.org/show_bug.cgi?id=35630
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=35630
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #3 from super_man@post.com --- This bug is marked fixed with wine-staging and because it's marked as fixed they use this patch or similar and it means this patch was never marked into wine.
So the issue is still there 1.7.49
https://bugs.winehq.org/show_bug.cgi?id=35630
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |STAGED CC| |michael@fds-team.de Ever confirmed|0 |1 Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/shell32-SHCrea | |teSessionKey
https://bugs.winehq.org/show_bug.cgi?id=35630
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Version|unspecified |1.6 Summary|SHCreateSessionKey is |New ReactOS shell crashes |unimplemented |on unimplemented function | |shell32.dll.723 a.k.a. | |SHCreateSessionKey
https://bugs.winehq.org/show_bug.cgi?id=35630
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@baikal.ru
--- Comment #4 from Austin English austinenglish@gmail.com --- (In reply to Bruno Jesus from comment #2)
There is a patch already in the list awaiting for review: http://source.winehq.org/patches/data/102530
Hi Dmitry,
Looks like that patch didn't make it in. Would you mind rebasing and resending now that 1.8 is released? Thanks.
https://bugs.winehq.org/show_bug.cgi?id=35630
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|dmitry@baikal.ru |
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #4)
Looks like that patch didn't make it in. Would you mind rebasing and resending now that 1.8 is released? Thanks.
The patch was silently ignored, I don't think it makes any sense to resend.
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #6 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Dmitry Timoshkov from comment #5)
(In reply to Austin English from comment #4)
Looks like that patch didn't make it in. Would you mind rebasing and resending now that 1.8 is released? Thanks.
The patch was silently ignored, I don't think it makes any sense to resend.
The patch was sent before wineconf 2015, I'm sure that resending it now will have a different impact ;-)
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #7 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Bruno Jesus from comment #6)
(In reply to Austin English from comment #4)
Looks like that patch didn't make it in. Would you mind rebasing and resending now that 1.8 is released? Thanks.
The patch was silently ignored, I don't think it makes any sense to resend.
The patch was sent before wineconf 2015, I'm sure that resending it now will have a different impact ;-)
Frankly, I don't see much difference in patch acceptance practices, they got even worse with inventing the sign-off qualification. The original idea for sign-off was to set the rules for sending patches created by somebody else, making the sender take the responsibility (by signing off the patch) for any regressions and any other bad things caused by the patch. Current (utterly perverted IMO) situation made the patch acceptance policy even worse than it was before, basically now you have to wait for some person who does not necessarily knows the code best (or even better than the sender), just he/she decided to make himself a "maintainer". Personally I even saw the situations when the patch author sends patches for the code originally written himself but nonetheless he must wait for an approvement (sign-off) from unrelated person who just happened to assign himself to be a "maintainer". Another thing worrying me is the "maintainers" origin. The matter of the fact is that everyone outside of codeweavers relies on sign-offs from CW people, while patches from @codeweavers.com senders usually get in without any delay, or even without waiting even for finishing a testbot run. Basically you can't get your patch accepted without a sign-off from a @CW person, and if someone else even dare to sign-off your patch (even a test or a really trivial change), your patch most likely won't be accepted without a sign-off with trailing @CW.com.
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com --- This is bugzilla, not your personal blog. Please keep your offtopic email git statistics out of it.
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #9 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Nikolay Sivov from comment #8)
This is bugzilla, not your personal blog. Please keep your offtopic email git statistics out of it.
Of course, you Nikolay couldn't resist not to post your own off-topic comment here :)
https://bugs.winehq.org/show_bug.cgi?id=35630
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
--- Comment #10 from Austin English austinenglish@gmail.com --- I sent a stub to prevent the crash for now: https://source.winehq.org/patches/data/117576
https://bugs.winehq.org/show_bug.cgi?id=35630
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #11 from winetest@luukku.com --- (In reply to Austin English from comment #10)
I sent a stub to prevent the crash for now: https://source.winehq.org/patches/data/117576
The patch applies cleanly against wine 1.9.20 so it dropped without getting committed.
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #12 from Austin English austinenglish@gmail.com --- (In reply to Austin English from comment #10)
I sent a stub to prevent the crash for now: https://source.winehq.org/patches/data/117576
Try 2: https://source.winehq.org/patches/data/126992
https://bugs.winehq.org/show_bug.cgi?id=35630
--- Comment #13 from winetest@luukku.com --- I think this is fixed with commit id
6c876de7d079a5b918a3d13c0ac2403d7dd3b40d
https://bugs.winehq.org/show_bug.cgi?id=35630
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6c876de7d079a5b918a3d13c0ac | |2403d7dd3b40d Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #14 from Austin English austinenglish@gmail.com --- https://source.winehq.org/git/wine.git/commitdiff/6c876de7d079a5b918a3d13c0a...
https://bugs.winehq.org/show_bug.cgi?id=35630
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.22.
-
wine-bugs＠winehq.org