[Bug 54172] New: ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

Bug ID: 54172
           Summary: ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7
                    - test_window_position() gets the size of the wrong
                    screen in Wine
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position()
gets the size of the wrong screen in Wine:

ddraw1.c:14471: Test failed: Expect window rect (0,0)-(1024,768), got
(0,0)-(1024,737).
ddraw2.c:15385: Test failed: Expect window rect (0,0)-(1024,768), got
(0,0)-(1024,737).
ddraw4.c:18435: Test failed: Expect window rect (0,0)-(1024,768), got
(0,0)-(1024,737).
ddraw7.c:18702: Test failed: Expect window rect (0,0)-(1024,768), got
(0,0)-(1024,737).

See https://test.winehq.org/data/patterns.html#ddraw:ddraw1
    https://test.winehq.org/data/patterns.html#ddraw:ddraw2
    https://test.winehq.org/data/patterns.html#ddraw:ddraw4
    https://test.winehq.org/data/patterns.html#ddraw:ddraw7

These failures never happen on debian11b which is a single-monitor
configuration.

$ xrandr | grep Virtual
  Virtual-1 connected primary 1024x768+0+0 0mm x 0mm
  Virtual-2 disconnected
  Virtual-3 disconnected
  Virtual-4 disconnected

It also never happens on debian11 where both monitors have the same resolution:

$ xrandr | grep Virtual
  Virtual-1 connected primary 1024x737+0+0 0mm x 0mm
  Virtual-2 connected 1024x737+1024+0 0mm x 0mm
  Virtual-3 disconnected
  Virtual-4 disconnected

But it is systematic on the debiant VM where the two screens have different
resolutions:

$ xrandr | grep Virtual
  Virtual-1 connected primary 1024x768+0+0 0mm x 0mm
  Virtual-2 connected 1024x737+1024+0 0mm x 0mm
  Virtual-3 disconnected
  Virtual-4 disconnected

Note:
* I did not intentionally configure the two screens to have different
resolutions but I did not fight it either because it's also not that uncommon
in multi-monitor configurations.
* The 737 pixel height is a bit weird but there is no dock. Really! I'm not
sure how the X server picked these sizes.

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

--- Comment #1 from François Gouget  ---
I know what causes the different screen dimensions:
* If I connect to the display using virt-manager I get the regular 1024x768.
* If I connect to the display using virt-viewer I get 1024x737. Coincidentally
virt-viewer's menu bar is 768 - 737 == 31 pixels high...

In order to set up the dual monitor configuration I have to do the following:
1. Wait for the X session auto-login.
2. In virt-viewer go to View -> Displays and enable the second display (that
checkbox is disabled before step 1).
3. Log out and wait for the X session auto-login again.

If I do step 1 in virt-manager or I only connect after step 1 is complete, the
main screen is 1024x768. The second step has to be done in virt-viewer and
results in the second screen being 1024x737.

Presumably when setting up debian11 I connected using virt-viewer pretty early
which is why the main screen got the 1024x737 resolution, same as the second
screen.

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

--- Comment #2 from Zhiyi Zhang  ---
I will take a look.

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]      |[e-mail]
      Fixed by SHA1|                            |36afabb9c1aa73ea6aeab4af627
                   |                            |327ce1a712b2a
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Zhiyi Zhang  ---
Fixed by 36afabb9c1aa73ea6aeab4af627327ce1a712b2a

[Bug 54172] ddraw:ddraw1, ddraw:ddraw2, ddraw:ddraw4, ddraw:ddraw7 - test_window_position() gets the size of the wrong screen in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54172

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc4.