[Bug 28761] New: ddraw/tests/visual.c: invalid write in ddraw_surface_delete_attached_surface

http://bugs.winehq.org/show_bug.cgi?id=28761

Bug #: 28761
           Summary: ddraw/tests/visual.c: invalid write in
                    ddraw_surface_delete_attached_surface
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

While running "make visual.ok" in ddraw/tests, valgrind complained
inside ddraw's reference counting code.  Log:

fixme:d3d:wined3d_device_set_render_target Surface 0x7fb4d7a0 doesn't have
render target usage.
err:d3d:wined3d_device_uninit_3d Something is still holding a reference to
depth/stencil buffer 0x7f0b24b8.
Invalid write of size 4
   at ddraw_surface_delete_attached_surface (surface.c:1628)
   by ddraw_surface_wined3d_object_destroyed (surface.c:5098)
   by wined3d_surface_decref (surface.c:2867)
   by wined3d_device_uninit_3d (device.c:1535)
   by ddraw_surface_cleanup (surface.c:446)
   by ddraw_surface_release_iface (surface.c:495)
   by ddraw_surface7_Release (surface.c:540)
   by func_d3d (d3d.c:203)
   by run_test (test.h:556)
   by main (test.h:624)
 Address 0x7f0b23f0 is 88 bytes inside a block of size 268 free'd
   at RtlFreeHeap (heap.c:262)
   by ddraw_surface_wined3d_object_destroyed (surface.c:5112)
   by wined3d_surface_decref (surface.c:2867)
   by ddraw_surface_destroy (surface.c:383)
   by ddraw_surface_cleanup (surface.c:428)
   by ddraw_surface_release_iface (surface.c:495)
   by ddraw_surface7_Release (surface.c:540)
   by ddraw_surface_delete_attached_surface (surface.c:1627)
   by ddraw_surface_wined3d_object_destroyed (surface.c:5098)
   by wined3d_surface_decref (surface.c:2867)
   by wined3d_device_uninit_3d (device.c:1535)
   by ddraw_surface_cleanup (surface.c:446)
   by ddraw_surface_release_iface (surface.c:495)
   by ddraw_surface7_Release (surface.c:540)
   by func_d3d (d3d.c:203)
   by run_test (test.h:556)
   by main (test.h:624)

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ddraw/tests/visual.c:       |ddraw/tests: invalid writes
                   |invalid write in            |in ddraw_surface7_Release
                   |ddraw_surface_delete_attach |and friends
                   |ed_surface                  |

--- Comment #1 from Dan Kegel  2011-10-17 03:14:54 CDT ---
And here's another one, in ddraw_test.exe.so overlay.c:

Invalid write of size 4
   at surface_cleanup (list.h:98)
   by wined3d_surface_decref (surface.c:2866)
   by ddraw_surface_destroy (surface.c:383)
   by ddraw_surface_cleanup (surface.c:428)
   by ddraw_surface_release_iface (surface.c:495)
   by ddraw_surface7_Release (surface.c:540)
   by func_overlay (overlay.c:190)
   by run_test (test.h:556)
   by main (test.h:624)
 Address 0x7f088e2c is 332 bytes inside a block of size 344 free'd
   at RtlFreeHeap (heap.c:262)
   by wined3d_surface_decref (surface.c:2870)
   by ddraw_surface_destroy (surface.c:383)
   by ddraw_surface_cleanup (surface.c:428)
   by ddraw_surface_release_iface (surface.c:495)
   by ddraw_surface7_Release (surface.c:540)
   by func_overlay (overlay.c:189)
   by run_test (test.h:556)
   by main (test.h:624)

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

--- Comment #2 from Henri Verbeet  2011-10-17 06:44:05 CDT ---
What does this look like with current git versions? At least some of the
surface attachment code was recently changed.

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

--- Comment #3 from Dan Kegel  2011-10-17 10:07:39 CDT ---
That's with today's git.  Do you want an older run for comparison?

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

--- Comment #4 from Henri Verbeet  2011-10-17 10:37:10 CDT ---
Created attachment 36951
  --> http://bugs.winehq.org/attachment.cgi?id=36951
patch

No, that's ok. The attached patch may help.

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

--- Comment #5 from Dan Kegel  2011-10-19 11:02:01 CDT ---
Yes, that patch makes the error go away.

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

http://bugs.winehq.org/show_bug.cgi?id=28761

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

https://bugs.winehq.org/show_bug.cgi?id=28761

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Austin English  ---
It's fine now in git.

[Bug 28761] ddraw/tests: invalid writes in ddraw_surface7_Release and friends

https://bugs.winehq.org/show_bug.cgi?id=28761

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.18.