[Bug 52908] New: mf:mf - The 64-bit test_wma_decoder() fails on 64-bit Debian 11 + Intel
https://bugs.winehq.org/show_bug.cgi?id=52908
Bug ID: 52908 Summary: mf:mf - The 64-bit test_wma_decoder() fails on 64-bit Debian 11 + Intel Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: mfplat Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com Distribution: ---
The 64-bit test_wma_decoder() fails on my Debian 11 + Intel machine (see fg-deb64-wow64):
mf.c:6282: Test failed: ProcessOutput returned 0xd0000001 mf.c:6328: Test failed: ProcessOutput returned 0xd0000001 mf.c:6340: Test failed: ProcessOutput returned 0xd0000001 mf.c:6352: Test failed: ProcessInput returned 0xc00d36b5
https://test.winehq.org/data/patterns.html#mf:mf
The last two failures are gone now but the first two are still present. configure does not mention any missing library (besides libhal) in either the 32- or the 64-bit builds.
A bisect shows that the failures started with this commit:
commit 651e4002ceeb9a15b11a184b5f47a732e26b7e00 Author: Rémi Bernon rbernon@codeweavers.com AuthorDate: Mon Mar 14 14:43:22 2022 +0100
winegstreamer: Introduce new wg_transform_(push|read)_data functions.
And use it to implement WMA decoder Process(Input|Output).
The test output is different because ffmpeg WMA decoder outputs data in a different way as native. The data seems valid audio nonetheless, and it shouldn't matter too much.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51931 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52391 Signed-off-by: Rémi Bernon rbernon@codeweavers.com Signed-off-by: Zebediah Figura zfigura@codeweavers.com Signed-off-by: Nikolay Sivov nsivov@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=52908
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase Regression SHA1| |651e4002ceeb9a15b11a184b5f4 | |7a732e26b7e00
https://bugs.winehq.org/show_bug.cgi?id=52908
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
--- Comment #1 from Rémi Bernon rbernon@codeweavers.com --- The WMA decoder requires libav GStreamer plugins, I'm not completely sure how that can be made a dependency, or if we want to.
The test could include some skipping, but it's a bit inconvenient IMHO as the transform is only created lazily.
Maybe we can add some winegstreamer init checks to validate the presence of certain plugins we may later need.
https://bugs.winehq.org/show_bug.cgi?id=52908
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #2 from Zeb Figura z.figura12@gmail.com --- (In reply to Rémi Bernon from comment #1)
Maybe we can add some winegstreamer init checks to validate the presence of certain plugins we may later need.
I don't think we want to do that if it's not guaranteed that we'll need them.
https://bugs.winehq.org/show_bug.cgi?id=52908
--- Comment #3 from Rémi Bernon rbernon@codeweavers.com --- We could check that a decoding plugin can be matched, (in the same way wg_transform will do) and only register WMA decoder transform if there's one, no?
https://bugs.winehq.org/show_bug.cgi?id=52908
--- Comment #4 from Rémi Bernon rbernon@codeweavers.com --- Created attachment 72296 --> https://bugs.winehq.org/attachment.cgi?id=72296 Check early if wg_transform can be created
So maybe not on init, but something like that should work?
https://bugs.winehq.org/show_bug.cgi?id=52908
--- Comment #5 from Zeb Figura z.figura12@gmail.com --- (In reply to Rémi Bernon from comment #4)
Created attachment 72296 [details] Check early if wg_transform can be created
So maybe not on init, but something like that should work?
I guess Media Foundation makes it difficult to react to failure from SetOutputType(), then? In that case I think that patch seems reasonable.
https://bugs.winehq.org/show_bug.cgi?id=52908
--- Comment #6 from Rémi Bernon rbernon@codeweavers.com --- It's not really that it's hard to handle, but from the test PoV it's easier if the error is caught early, without having to worry about validating each possible case where it may fail. Otherwise any future change to the test call sequence will possibly break this again.
On Windows the transform may not be there either (I guess, if somehow you can uninstall codecs), and it will also fail to enumerate (rather than fail to create probably, but it's hopefully okay). Then I don't think it would later fail spuriously like how a missing GStreamer plugin does for us.
https://bugs.winehq.org/show_bug.cgi?id=52908
Julian Rüger jr98@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98@gmx.net
https://bugs.winehq.org/show_bug.cgi?id=52908
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |3aaa953bd6f71c77a3d3ec34ab0 | |f5155f67346db
--- Comment #7 from Rémi Bernon rbernon@codeweavers.com --- I believe this is fixed after 3aaa953bd6f71c77a3d3ec34ab0f5155f67346db.
https://bugs.winehq.org/show_bug.cgi?id=52908
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.9.
-
WineHQ Bugzilla