https://bugs.winehq.org/show_bug.cgi?id=37149
Bug ID: 37149 Summary: python 3.1.1: test_cmath failed Product: Wine Version: 1.7.24 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: litimetal@gmail.com
Created attachment 49379 --> https://bugs.winehq.org/attachment.cgi?id=49379 terminal output.txt
0. Download python from https://www.python.org/ftp/python/3.1.1/python-3.1.1.msi sha1sum python-3.1.1.msi dcf93cb7d5432aa6e47479351f3cbeefddb0bd62 python-3.1.1.msi
1. Install it
2. wine python.exe -m test.test_cmath
FAILED (failures=2)
https://bugs.winehq.org/show_bug.cgi?id=37149
lizhenbo litimetal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://www.python.org/ftp/ | |python/3.1.1/python-3.1.1.m | |si
https://bugs.winehq.org/show_bug.cgi?id=37149
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=37149
Teras teras@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |teras@luukku.com
--- Comment #1 from Teras teras@luukku.com --- Still failing
wine-1.7.36-83-gf75d1b0
https://bugs.winehq.org/show_bug.cgi?id=37149
Kevin Chan ChanChengCC@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ChanChengCC@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=37149
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com Component|-unknown |msvcrt
https://bugs.winehq.org/show_bug.cgi?id=37149
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |STAGED CC| |michael@fds-team.de, | |sebastian@fds-team.de Ever confirmed|0 |1 Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/msvcrt-Math_Pr | |ecision
https://bugs.winehq.org/show_bug.cgi?id=37149
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=37149
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/msvcrt-Math_Pr |er/patches/msvcrt-Math_Prec |ecision |ision CC| |nerv@dawncrow.de
https://bugs.winehq.org/show_bug.cgi?id=37149
Alex Henrie alexhenrie24@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24@gmail.com
--- Comment #2 from Alex Henrie alexhenrie24@gmail.com --- The cmath tests pass after running `winetricks vcrun2008`.
I actually don't think that there is a bug here at all. The MSVC implementations of these math functions are slightly more accurate and the glibc implementations have slightly better performance. Python 3.1.1 sets the FPU to extended precision (80 bits) on Linux, presumably to force glibc to give results that are as accurate as MSVC.[1] However, if we make Wine always set the extended precision flag before calling a glibc math function, we could see an unacceptable slowdown in programs that don't require exact values. So the only way to truly "fix the bug" would be to stop relying on glibc and instead write our own math function implementations that make the same performance/accuracy tradeoffs as the Microsoft implementations. I don't think it's worth the effort, especially since the tradeoffs that Microsoft chose could be different in different MSVC versions or on different CPU architectures.
TLDR: If you need more accurate math in Wine, I recommend installing vcrun2008 or complaining to the GCC developers.
[1] https://github.com/python/cpython/blob/586547387b468ffb391cb76842f65e68164e5...
https://bugs.winehq.org/show_bug.cgi?id=37149
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com Fixed by SHA1| |f5bd0be6a44c1c7d69afb8b8eb6 | |311923e7762a1 Resolution|--- |FIXED Status|STAGED |RESOLVED
--- Comment #3 from Zebediah Figura z.figura12@gmail.com --- This appears to have been fixed by https://source.winehq.org/git/wine.git/commitdiff/f5bd0be6a44c1c7d69afb8b8eb6311923e7762a1.
https://bugs.winehq.org/show_bug.cgi?id=37149
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.11.