[Bug 26718] New: dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

Summary: dbghelp has lots of 'parse_inlined_subroutine
                    Unhandled Tag type' (gcc 4.7)
           Product: Wine
           Version: 1.3.2
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: enhancement
          Priority: P2
         Component: dbghelp
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Found while retesting bug 24359
With new gcc (4.7.0), doing make debugger.ok in kernel32/tests gives:
fixme:dbghelp_dwarf:dwarf2_parse_inlined_subroutine Unhandled Tag type 0x4109
at ctx(0x33e518,L"libwine.so.1"), for debug_info(abbrev:0x1668f8,symt:(nil))
fixme:dbghelp_dwarf:dwarf2_parse_subprogram Unhandled Tag type 0x4109 at
ctx(0x33e518,L"libwine.so.1"), for debug_info(abbrev:0x165f70,symt:0x18f46c)

in terminal thousand times:
$ grep -c "Unhandled Tag type" debug.txt 
27918

also a few:
fixme:dbghelp_dwarf:dwarf2_lookup_type Unable to load forward reference for tag
26
austin@aw21 ~ $ grep -c "forward reference" debug.txt 
85

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #1 from Austin English  2011-04-11 00:34:18 CDT ---
Created an attachment (id=34034)
 --> (http://bugs.winehq.org/attachment.cgi?id=34034)
terminal output

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.2                       |1.3.17

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #2 from Eric Pouech  2011-04-11 13:49:16 CDT ---
I've just sent the fix to wine-patches (look for forcing void type in const
management)

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #3 from Austin English  2011-04-11 14:25:25 CDT ---
(In reply to comment #2)
> I've just sent the fix to wine-patches (look for forcing void type in const
> management)

Still a ton of spam (tried that patch, as well as the others you sent):
fixme:dbghelp_dwarf:dwarf2_parse_subprogram Unhandled Tag type 0x4109 at
ctx(0x33bee8,L"ntdll<elf>"), for debug_info(abbrev:0xcd2238,symt:0xf7bf6c)
fixme:dbghelp_dwarf:dwarf2_parse_subprogram_block Unhandled Tag type 0x4109 at
ctx(0x33bee8,L"ntdll<elf>"), for debug_info(abbrev:0xcd1828,symt:(nil))

austin@aw21 ~/wine-git/dlls/kernel32/tests $ wc -l < output.txt
28118

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #4 from Eric Pouech  2011-04-13 15:39:44 CDT ---
Created an attachment (id=34089)
 --> (http://bugs.winehq.org/attachment.cgi?id=34089)
tentative patch

does the attached patch solves all the output ?

it should reduce lots of them, I just to be sure everything is covered
A+

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #5 from Austin English  2011-04-13 15:52:44 CDT ---
(In reply to comment #4)
> Created an attachment (id=34089)

--> (http://bugs.winehq.org/attachment.cgi?id=34089) [details]
> tentative patch
>
> does the attached patch solves all the output ?
>
> it should reduce lots of them, I just to be sure everything is covered
> A+

Helps quite a bit, but you still have:
fixme:dbghelp_dwarf:dwarf2_parse_inlined_subroutine Unhandled Tag type 0x4109
at ctx(0x33e518,L"libwine.so.1"), for debug_info(abbrev:0x166858,symt:(nil))

794 of them.

Though I notice the backtrace is:
    00000022    0 <==
Backtrace:
=>0 0x685e23ca func_debugger+0x3ba()
[/home/austin/wine-git/dlls/kernel32/tests/debugger.c:177] in kernel32_test
(0x00000003)
  1 0x6865afd4 main+0x393(argc=*** Invalid address 0x5c5c5c5c ***
, argv=*** Invalid address 0x5c5c5c60 ***
Internal symbol error: unable to access memory location 0x5c5c5c60)
[/home/austin/wine-git/dlls/kernel32/tests/../../../include/wine/test.h:556] in
kernel32_test (0x0033fe68)
  2 0x6865b112 __wine_spec_exe_entry+0x71(peb=0x7ffdf000)
[/home/austin/wine-git/dlls/winecrt0/exe_entry.c:36] in kernel32_test
(0x0033feb8)
  3 0x6842c68c call_process_entry+0xb() in kernel32 (0x0033feb8)
  4 0x6842d380 start_process+0x5f(peb=0x7ffdf000)
[/home/austin/wine-git/dlls/kernel32/process.c:1086] in kernel32 (0x0033fef8)
  5 0x68355a48 call_thread_func+0xb() in ntdll (0x0033fef8)
  6 0x6835870d call_thread_entry_point+0x6c(entry=0x6842d320, arg=0x7ffdf000)
[/home/austin/wine-git/dlls/ntdll/signal_i386.c:2499] in ntdll (0x00000000)

(Invalid address) which should probably be a separate bug...

Thanks for the quick work!

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #6 from Eric Pouech  2011-04-14 14:24:13 CDT ---
I'll send the patch with the fix the inlined_subroutine as well
yes the backtrace is wrong because gcc aligns main's stack on 16bit boundaries,
and the dwarf unwinder isn't smart enough yet to cope with it
A+

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

--- Comment #7 from Austin English  2011-04-14 15:53:58 CDT ---
(In reply to comment #6)
> I'll send the patch with the fix the inlined_subroutine as well

Thanks!
> yes the backtrace is wrong because gcc aligns main's stack on 16bit boundaries,
> and the dwarf unwinder isn't smart enough yet to cope with it

Would you like a separate bug for this?

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English  2011-04-15 13:29:56 CDT ---
Fixed by:
http://source.winehq.org/git/wine.git/commitdiff/44c52c16fde45e8188b0f1afa77...
http://source.winehq.org/git/wine.git/commitdiff/18f539ac2e444118e128c0a0bb0...

The broken backtrace is now bug 26791.

[Bug 26718] dbghelp has lots of 'parse_inlined_subroutine Unhandled Tag type' (gcc 4.7)

http://bugs.winehq.org/show_bug.cgi?id=26718

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-04-29 13:15:51 CDT ---
Closing bugs fixed in 1.3.19.