[Bug 50491] New: Detecting whether garbled lines are new

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50491

Bug ID: 50491
           Summary: Detecting whether garbled lines are new
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Sometimes a failure line is garbled because of race conditions or a missing
'\n'. This typically looks something like this:

advpack.c:689: WTBS Garble 2advpack.c:691: WTBS Garble 3advpack.c:692: Test
failed: WTBS A test failure

The TestBot still detects these failures because it knows which test unit is
running at that point in the report and thus looks for something like
'advpack.c:\d+: Test failed: ...'.

But when it tries to detect whether this is a new error line it cannot compare
the whole line with past instances as the garbage part may change or not be
present in WineTest runs (particularly if it contains line numbers). That
suggests it should extract just the current failure string, that is:

advpack.c:692: Test failed: WTBS A test failure

This should maybe also be the string stored in the .errors file.

[Bug 50491] Detecting whether garbled lines are new

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50491

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 50491] Detecting whether garbled lines are new

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50491

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |4ddd1988c59548839c1c19e146e
                   |                            |a213ecd0e74d3

--- Comment #1 from François Gouget  ---
This is fixed.
Now only the 'clean' part of the error line is put in the .errors file so
comparison with past instances can match.
This also means the JobDetails page only shows the 'clean' part of the error
but then when one expands to see the full log the raw line is shown. Note that
it can still be matched to the .errors entry thanks to the line number, which
means it is highlighted as expected.

commit 4ddd1988c59548839c1c19e146ea213ecd0e74d3
Author: Francois Gouget 
Date:   Mon Mar 22 11:12:15 2021 +0100

testbot/LogUtils: Don't include garbage in the .errors file.

When failure lines are garbled because of a race condition or a missing
    '\n' they often contain unwanted characters at the start of the line.
    If included in the .errors file these prevent the line from matching
    past instances of the failure (if only because of line numbers), thus
    causing it to be incorrectly reported as new. So only include the
    parts of the line matched by the error matching regular expression.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50491
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 50491] Detecting whether garbled lines are new

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50491

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from François Gouget  ---
Closing.