[Bug 56103] New: PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

Bug ID: 56103
           Summary: PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not
                    processed
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed
They should allow to change active tab but they don't.

Cause : in do_loop function, if(!IsDialogMessageW(hwnd, &msg)) should be
replaced by if (!PROPSHEET_IsDialogMessage(hwnd, &msg)) as
PROPSHEET_IsDialogMessage correctly implement TAB management for
propertysheets.

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
do you plan to send a fix for that?

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

--- Comment #2 from KRosUser  ---
See
https://github.com/reactos/reactos/commit/6e5fde7ebb40532cbe9b81dcd3cee6a738...

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

--- Comment #3 from Fabian Maurer  ---
No I mean, do you want to make a wine MR for this? If not, I can try. But I
would need an application to test with.

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

--- Comment #4 from KRosUser  ---
No sorry, I let some contributors or developpers propose a MR for this.

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

--- Comment #5 from KRosUser  ---
Sample app : Desk.cpl from ReactOS as per
https://jira.reactos.org/browse/CORE-17941 or any similar sample with PropSheet
and TabCtrl

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |download, source
             Status|UNCONFIRMED                 |NEW

--- Comment #6 from Fabian Maurer  ---
Thanks, created a MR here:
https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |1256f7c98c5e14852b74e0c3a25
                   |                            |50dc3b7b32ae7

--- Comment #7 from Fabian Maurer  ---
Fixed by
https://gitlab.winehq.org/wine/wine/-/commit/1256f7c98c5e14852b74e0c3a2550dc...

[Bug 56103] PropertySheet - CTRL+TAB and CTRL+SHIFT+TAB not processed

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56103

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 9.17.