[Bug 27263] New: Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Summary: Broken depth test for translucent surfaces in Arx
                    Fatalis (d3d 7 game)
           Product: Wine
           Version: 1.3.19
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=34866)
 --> (http://bugs.winehq.org/attachment.cgi?id=34866)
Screenshot of translucent water being rendered in front of a bridge.

Starting with wine 1.3.19 the game Arx Fatalis draws translucent surfaces in
front of other surfaces, even if they should be behind them.

This can be seen in the original binary (the game is not freely available, bu
there is a demo) as well as in the ongoing port at
https://github.com/lubosz/ArxFatalis Arx
Fatalis uses direct3d 7.

The bug is also in current master (tested commit
456e48efa1df91cee6149b67187812e16350c474)

git bisect blames:

96b758f7b37033bf382ce40dd3310965d3ac3f76 is the first bad commit
commit 96b758f7b37033bf382ce40dd3310965d3ac3f76
Author: Stefan Dösinger 
Date:   Thu Apr 21 22:36:11 2011 +0200

d3d: Map D3DRS_ZBIAS to WINED3DRS_DEPTHBIAS.

ZBIAS was removed in d3d9 and replaced with DEPTHBIAS. Currently
    wined3d implements both independently which will cause trouble if we
    want to set the depthbias value depending on the depth stencil format.

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

--- Comment #1 from Henri Verbeet  2011-05-23 03:52:05 CDT ---
Does this also happen with 1.3.20? I think
a1519e62f47f2dfa54ca526ee718fe8a936593f2 was supposed to fix this.

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

--- Comment #2 from Daniel Scharrer  2011-05-23 08:50:11 CDT ---
Yes, this also happens with wine-1.3.20 (commit
6f5e5ec98b1c9b4f930655e38a8d5ba86a5beac3) and with commit
a1519e62f47f2dfa54ca526ee718fe8a936593f2

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

--- Comment #3 from Henri Verbeet  2011-07-03 01:38:18 CDT ---
Created an attachment (id=35410)
 --> (http://bugs.winehq.org/attachment.cgi?id=35410)
patch

Could you give this patch a try? Works for me with the demo.

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wylda  2011-07-03 04:35:51 CDT ---
> Could you give this patch a try? Works for me with the demo.

Hi Henri, i found this full game bundled to some game magazine and gave this
patch a try on top of wine-1.3.23-160-g38c13e5. Before when being in the water
i was able to see partly through the walls. With the patch this gone.

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

--- Comment #5 from Daniel Scharrer  2011-07-03 06:02:31 CDT ---
(In reply to comment #3)
> Created an attachment (id=35410)

--> (http://bugs.winehq.org/attachment.cgi?id=35410) [details]
> patch
>
> Could you give this patch a try? Works for me with the demo.

I can confirm that this patch works with both the demo and the full game.
Thanks!

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Piotr Pawlow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Piotr Pawlow  2011-07-03 11:10:14 CDT ---
This patch also fixes translucent ground/objects in Giants: Citizen Kabuto, and
flickering shadows bug is gone too (bug #17398)!

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

--- Comment #7 from Henri Verbeet  2011-07-05 13:02:25 CDT ---
Should be fixed by ddc29c40e66f686190a40ac4bc2578e81785f56f.

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Daniel Scharrer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Daniel Scharrer  2011-07-09 09:17:39 CDT ---
Works in wine-1.3.24

[Bug 27263] Broken depth test for translucent surfaces in Arx Fatalis (d3d 7 game)

http://bugs.winehq.org/show_bug.cgi?id=27263

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-07-22 12:44:33 CDT ---
Closing bugs fixed in 1.3.25.