https://bugs.winehq.org/show_bug.cgi?id=53594
Bug ID: 53594 Summary: Stacktrace when opening GOG Galaxy Product: Wine-staging Version: 7.13 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: oldrecords88@gmail.com CC: leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
Created attachment 72984 --> https://bugs.winehq.org/attachment.cgi?id=72984 stacktrace output from Wine dialog
Opening GOG Galaxy using Wine Staging in Ubuntu 21.10 results in a backtrace. The application still loads and appears to somewhat work (tried downloading and installing a new game, said installation failed but I'm not sure if it's directly related).
https://bugs.winehq.org/show_bug.cgi?id=53594
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|leslie_alistair@hotmail.com | |, z.figura12@gmail.com | Product|Wine-staging |Wine Component|-unknown |iphlpapi
--- Comment #1 from Zeb Figura z.figura12@gmail.com --- It crashes in get_extended_tcp_table(), apparently on this line: https://source.winehq.org/git/wine.git/blob/wine-7.13:/dlls/iphlpapi/iphlpapi_main.c#l3136
Nothing in wine-staging touches that code; assuming an upstream bug.
https://bugs.winehq.org/show_bug.cgi?id=53594
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Stacktrace when opening GOG |GOG Galaxy crashes in |Galaxy |GetExtendedTcpTable() CC| |z.figura12@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=53594
David Kahurani k.kahurani@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |k.kahurani@gmail.com
--- Comment #2 from David Kahurani k.kahurani@gmail.com --- (In reply to Zeb Figura from comment #1)
Nothing in wine-staging touches that code; assuming an upstream bug.
Unless I'm missing something, GOG Galaxy seems to load and run fine on upstream
https://bugs.winehq.org/show_bug.cgi?id=53594
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|iphlpapi |-unknown CC| |leslie_alistair@hotmail.com Product|Wine |Wine-staging
https://bugs.winehq.org/show_bug.cgi?id=53594
--- Comment #3 from Zeb Figura z.figura12@gmail.com --- (In reply to David Kahurani from comment #2)
(In reply to Zeb Figura from comment #1)
Nothing in wine-staging touches that code; assuming an upstream bug.
Unless I'm missing something, GOG Galaxy seems to load and run fine on upstream
Are you sure that wine-staging is also broken for you?
https://bugs.winehq.org/show_bug.cgi?id=53594
--- Comment #4 from David Kahurani k.kahurani@gmail.com --- Sorry, I did check with wine-staging at first but I just checked and no, GOG Galaxy works fine for me on wine-staging too.
Sorry, if I wasted your time.
https://bugs.winehq.org/show_bug.cgi?id=53594
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|leslie_alistair@hotmail.com | |, z.figura12@gmail.com | Component|-unknown |iphlpapi Product|Wine-staging |Wine
--- Comment #5 from Zeb Figura z.figura12@gmail.com --- Okay, no worries, it's probably something specific to the original reporter's network setup.
https://bugs.winehq.org/show_bug.cgi?id=53594
Teo Klestrup Röijezon teo@nullable.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |teo@nullable.se
--- Comment #6 from Teo Klestrup Röijezon teo@nullable.se --- Created attachment 73260 --> https://bugs.winehq.org/attachment.cgi?id=73260 crash log on wine-7.18
I can confirm that GetExtendedTcpTable seems to have a low but non-zero chance of segfaulting on every call.
I wrote a repro program that seems to crash reliably-ish after about 10-20 minutes on mainline Wine, or about 1-2 minutes on Wine-staging.
https://bugs.winehq.org/show_bug.cgi?id=53594
--- Comment #7 from Teo Klestrup Röijezon teo@nullable.se --- Created attachment 73261 --> https://bugs.winehq.org/attachment.cgi?id=73261 crashotron.c (repro program)
And here's the repro program. I've been compiling it with gcc/mingw (`x86_64-w64-mingw32-gcc crashotron.c -liphlpapi`) if that matters.
https://bugs.winehq.org/show_bug.cgi?id=53594
--- Comment #8 from Teo Klestrup Röijezon teo@nullable.se --- Still not 100% sure about whether the multiple threads are required, but I haven't been able to reproduce the crash with only a single thread so far.
https://bugs.winehq.org/show_bug.cgi?id=53594
marc_aurel@me.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marc_aurel@me.com
https://bugs.winehq.org/show_bug.cgi?id=53594
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase
https://bugs.winehq.org/show_bug.cgi?id=53594
--- Comment #9 from David Kahurani k.kahurani@gmail.com --- Hello
I think your issue has been independently reproduced and fixed by another developer as can be seen on bug 54328 and the MR https://gitlab.winehq.org/wine/wine/-/merge_requests/1978
https://bugs.winehq.org/show_bug.cgi?id=53594
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |cc32eb6c0d9f5fa834ee628529f | |ccea51fafc00d CC| |fgouget@codeweavers.com Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #10 from François Gouget fgouget@codeweavers.com --- I think this should indeed be fixed: The main bug (when NsiAllocateAndGetTable() returns success in cases of failure) should be fixed by cc32eb6c0d9f5fa834ee628529fccea51fafc00d. The secondary bug (failing to allocate the tables) should be fixed by 31792f43701d74589e2f06dc5b6446a84d5d4614.
https://bugs.winehq.org/show_bug.cgi?id=53594
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.1.