[Bug 22798] New: Invalid Wine version results in hidden / lost / invisible test results entry
http://bugs.winehq.org/show_bug.cgi?id=22798
Summary: Invalid Wine version results in hidden / lost / invisible test results entry Product: WineHQ Apps Database Version: unspecified Platform: x86 OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: appdb-unknown AssignedTo: wine-bugs@winehq.org ReportedBy: sparr0@gmail.com
I submitted test results for Time of Defiance (http://appdb.winehq.org/objectManager.php?sClass=version&iId=8261) with an invalid Wine Version number (1.1.45). The form accepted my submission, and I was later emailed that my results had been added (perhaps because I was the submitter, perhaps because I am the maintainer of the version). Now http://appdb.winehq.org/objectManager.php?sClass=version&iId=8261&iT... displays my new results in the "Selected Test Results" box, but on no page are the details of the results visible in the "Test Results" box.
I expect two fixes are required here. First, more input validation on the submission page. Second, whatever is preventing this entry from showing up under Test Results.
http://bugs.winehq.org/show_bug.cgi?id=22798
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P4 Status|UNCONFIRMED |NEW CC| |kennybobs@o2.co.uk Platform|x86 |Other Ever Confirmed|0 |1 OS/Version|All |other Severity|normal |trivial
--- Comment #1 from Ken Sharp kennybobs@o2.co.uk 2010-05-20 16:49:42 --- Confirming bug, but not sure how you managed to submit a new Wine version. You should have seen a drop-down list so entering your own version wouldn't be possible.
How did you enter the Wine version?
http://bugs.winehq.org/show_bug.cgi?id=22798
--- Comment #2 from Clarence Risher sparr0@gmail.com 2010-05-20 16:55:19 --- I added a version to the drop-down list.
Also, my first submission of the form was incomplete (I forgot to fill out "what was not tested"), so it presented it to me again. The second time, the site had added the new version to the bottom of the list.
http://bugs.winehq.org/show_bug.cgi?id=22798
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|P4 |P2 Platform|Other |x86 OS/Version|other |All Severity|trivial |normal
--- Comment #3 from Ken Sharp kennybobs@o2.co.uk 2010-05-20 17:04:33 --- Hmmm, that's not an option here. What browser are you using?
http://bugs.winehq.org/show_bug.cgi?id=22798
--- Comment #4 from Clarence Risher sparr0@gmail.com 2010-05-20 17:09:34 --- I am using Firefox. The ability to add rows to a drop-down is provided by a few web development add-ons. That part is moot, the submission in question could have come from a completely manufactured POST or a modified version of the web page as well.
http://bugs.winehq.org/show_bug.cgi?id=22798
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source Priority|P2 |P4 Platform|x86 |Other OS/Version|All |other Severity|normal |trivial
--- Comment #5 from Ken Sharp kennybobs@o2.co.uk 2010-05-20 17:18:33 --- Fair enough.
Maintainers and admin have the ability to edit old posts which automatically selects the Wine version that was originally submitted, which is what you saw when editing the old post.
I guess there needs to be a verification system put in-place.
However, the likelihood of this happening again are minimal, and if anyone were to do it intentionally it would basically be a waste of time.
Perhaps the submission will show up when 1.1.45 is released.
Even so, submissions shouldn't be made for git versions of Wine. A new Wine is released every fortnight so there's no need to do so.
https://bugs.winehq.org/show_bug.cgi?id=22798
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal Summary|Invalid Wine version |Test report form does not |results in hidden / lost / |validate Wine versions in |invisible test results |testedRelease field |entry |
--- Comment #6 from Rosanne DiMesio dimesio@earthlink.net --- Had there ever been a 1.1.45 the test would have eventually shown up, but since 1.1.44 was followed by 1.2-rc1, it's been invisible until yesterday, when the version was changed to 1.1.44.
The fact that an invalid version prevents a test report from being included in the test results table isn't a bug; invalid test reports shouldn't be listed. The fact that the test report was accepted with an invalid version is the bug. I've edited the summary to reflect that and have set the severity to normal.
http://bugs.winehq.org/show_bug.cgi?id=22798
--- Comment #7 from Ken Sharp imwellcushtymelike@gmail.com --- This is still the case, though it does actually have its uses (it should maybe be allowed for admin).
http://bugs.winehq.org/show_bug.cgi?id=22798
Stian Low wineryyyyy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com
--- Comment #8 from Stian Low wineryyyyy@gmail.com --- (In reply to Ken Sharp from comment #7)
This is still the case, though it does actually have its uses (it should maybe be allowed for admin).
Regarding why versions are hackable see my comments at: https://bugs.winehq.org/show_bug.cgi?id=58510 Submitting new test results lists all versions of Wine
There indeed is no validation for wine version for AppDB test results as versions are input to the DB table as strings rather than mapping to ids that would provide the validation. I replicated this invalidation of versions with the latest Bugzilla version list extracted from HTML.
Validation can be added against either the versions list of current method via Bugzilla HTML or the versions list of the old way of maintaining a copy of the bugzilla DB table in AppDB.
It's probably such a rare case that priority has always been very low to fix.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla