[Bug 54361] New: Winebus doesn't enumerate evdev devices in a --without-sdl build unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

Bug ID: 54361
           Summary: Winebus doesn't enumerate evdev devices in a
                    --without-sdl build unless SDL also disabled by
                    winebus registry key
           Product: Wine
           Version: 8.0-rc5
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Not sure what info to add.

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Winebus doesn't enumerate   |Winebus doesn't enumerate
                   |evdev devices in a          |hid devices (in a
                   |--without-sdl build unless  |--without-sdl build) unless
                   |SDL also disabled by        |SDL also disabled by
                   |winebus registry key        |winebus registry key

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |9a78467975100321773d11e0a3e
                   |                            |2a427498a00cc

--- Comment #1 from [e-mail] ---
Looking at the history this seems to be a regression of

commit 9a78467975100321773d11e0a3e2a427498a00cc
Author: Rémi Bernon 
Date:   Mon Aug 23 10:49:36 2021 +0200

winebus.sys: Create the SDL bus thread in main.c.

It is missing a ! before sdl_driver_init()

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

--- Comment #2 from [e-mail] ---
It isn't the conditional, but that commit changes the result of sdl_driver_init
in a --without-sdl build to STATUS_SUCCESS, because the - nonfunctional - SDL
thread actually starts successfully (signalling init_done):

0084:trace:hid:bus_main_thread L"SDL" main loop starting
0084:warn:hid:sdl_bus_init SDL support not compiled in!
0084:trace:hid:bus_main_thread L"SDL" main loop started
0084:warn:hid:bus_main_thread L"SDL" bus init returned status 0xc0000002
0084:warn:hid:bus_main_thread L"SDL" bus wait returned status 0xc0000002

Before the commit sdl_driver_init just directly returned an error in the
--without-sdl case.

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

--- Comment #3 from [e-mail] ---
Created attachment 73966
  --> https://bugs.winehq.org/attachment.cgi?id=73966
POC patch to correct the regression

This patch fixes the regression and unconditionally initializes udev and iohid
when sdl is not present.

I suspect main.c is intentionally not sprinkled with #ifdef, so this approach
might not be acceptable.

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |31c61075be084b3f12a6d624bdc
                   |                            |0e7e601345e3a
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Rémi Bernon  ---
Should be fixed after 31c61075be084b3f12a6d624bdc0e7e601345e3a

[Bug 54361] Winebus doesn't enumerate hid devices (in a --without-sdl build) unless SDL also disabled by winebus registry key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54361

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 9.0-rc2.