[Bug 29364] New: Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

Bug #: 29364
           Summary: Crystal Key 2 crashes on start (unless screen
                    resolution=800x600)
           Product: Wine
           Version: 1.3.35
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: regression
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: e6fb4537f00cd1e94ff11dd85b7b07b58245ec45

Created attachment 38002
  --> http://bugs.winehq.org/attachment.cgi?id=38002
terminal output

Crystal Key 2 (The Far Realm) is an adventure game, developed by Kheops Studio
in 2004.

The game shows a black screen on startup for a second or two, then it crashes
(instead of showing the company logos).

Workaround: screen resolution must be set to 800x600 before launching the game
(that's the game's own resolution), or setting a virtual desktop sized to
800x600.

No demo available.

The result of the regression test:

e6fb4537f00cd1e94ff11dd85b7b07b58245ec45 is the first bad commit
commit e6fb4537f00cd1e94ff11dd85b7b07b58245ec45
Author: Henri Verbeet 
Date:   Mon Dec 12 20:53:55 2011 +0100

ddraw: Move clipper handling to ddraw.

:040000 040000 a724d58aa4e05bb05f3b21404e55f3b78f9ea3c9
e00012e8b149f8843d339e5fd840d655ded4fdc8 M    dlls
:040000 040000 3a089441873c2b2b6813fe1a7cbf69487991e404
f51d08448a9b83231bc7c509c12a9f282a5520e7 M    include

The patch can be reverted cleanly on 1.3.35 and that fixed the problem (the
game could start at any resolutions).

Fedora 16 x86
Nvidia 250 / driver 290.10
X.Org X Server 1.11.2
Gnome 3 + Mutter (compositing) / Gnome 2 + Metacity (non-compositing)

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID
    Regression SHA1|e6fb4537f00cd1e94ff11dd85b7 |
                   |b07b58245ec45               |

--- Comment #1 from GyB  2012-01-11 01:22:57 CST ---
I tend to close this bug report as invalid.

With today's git (wine-1.3.36-269-g662f3ab2) I noticed that the game starts
fine whatever screen resolution is set. First I thought that the fix came from
one of Henri's ddraw patches.
Then I realized that the game still crashes once in a while with the same
backtrace as attached in comment #0. The crashes seem to happen randomly
between runs.
This made me curious to redo the regression test between 1.3.34 and 1.3.35: it
turned out that the game behaved such an unpredictable way during regression
testing. This invalidates the result of the former regression test.

There must be something causing the game to crash from time to time. As this is
not fully reproducible, I'm marking this bug report as invalid.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

--- Comment #2 from Henri Verbeet  2012-01-11 04:37:05 CST ---
Well, the backtrace looks like it might be legitimate. Did this happen before
82dd612d?

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

--- Comment #3 from Henri Verbeet  2012-01-11 05:29:57 CST ---
Created attachment 38324
  --> http://bugs.winehq.org/attachment.cgi?id=38324
patch

Actually, does the attached patch make it any better?

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |

--- Comment #4 from GyB  2012-01-11 06:22:06 CST ---
(In reply to comment #3)
> Created attachment 38324 [details]
> patch
>
> Actually, does the attached patch make it any better?

Yes, the patch seems to handle the problem. This time I made 20 attempts to
start the game, and the game never crashed with your patch. I tried with
full-screen as well as with virtual desktop mode, using different desktop
sizes.
> Well, the backtrace looks like it might be legitimate. Did this happen before
> 82dd612d?

No, the game doesn't crash either with 82dd612d or with 1.3.34. The commit
causing the problem must be newer than 1.3.34.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

--- Comment #5 from Henri Verbeet  2012-01-12 14:08:20 CST ---
Should be fixed by be3a9b5ecb7f15f908323cf4b7ad09f3035a62ca.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.fileplanet.com/1
                   |                            |46965/140000/fileinfo/Retur
                   |                            |n-to-Mysterious-Island-Demo

--- Comment #6 from GyB  2012-01-12 14:21:23 CST ---
(In reply to comment #5)
> Should be fixed by be3a9b5ecb7f15f908323cf4b7ad09f3035a62ca.

This is the most insidious bug I've ever encountered...
The crashes do still occur with Crystal Key 2 as before. They happen randomly:
the game starts fine 1..2..n times in a row, then it began crashing several
times in a row, then it starts again normally.

I found that the demo for Return to Mysterious Island shares the same problem,
it *sometimes* crashes with the same backtrace as Crystal Key 2.
Henri, could you give it a try to see if you can reproduce the problem with the
demo of RtMI?

The demo uses 1024x768 resolution by default, so make sure you set a higher
screen resolution than that. As with Crystal Key 2 the crashes don't always
happen. You should try both full-screen and virtual desktop mode when testing.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

--- Comment #7 from Henri Verbeet  2012-01-26 15:01:24 CST ---
RtMI should be fixed by faa040cd9e9f34a6abdf80833912bfdd581b9921. If this is
the same bug, running with WINEDEBUG=warn+heap should help with making it more
reproducible.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |faa040cd9e9f34a6abdf8083391
                   |                            |2bfdd581b9921
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from GyB  2012-01-26 21:52:35 CST ---
I'm glad you managed to reproduce the problem on your side. At first I thought
this is gonna be invalid because the bug not always occured.
Crystal Key 2 also starts fine now, tested with wine-1.3.37-447-ge79644e.

Thank you for your effort to fix this problem.

[Bug 29364] Crystal Key 2 crashes on start (unless screen resolution=800x600)

http://bugs.winehq.org/show_bug.cgi?id=29364

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2012-01-27 14:17:37 CST ---
Closing bugs fixed in 1.4-rc1.