[Bug 14994] New: Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Summary: Haskell's removeDirectoryRecursive fails on Wine
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15616)
 --> (http://bugs.winehq.org/attachment.cgi?id=15616)
testcase

attached is a test executable which does the shell equivalent of

mkdir -p wine-bug/1
touch wine-bug/1/xyz
rm -rf wine-bug

Works fine on Windows XP, fails under wine-1.1.2-551-g34aa6b7 with the message
"Directory not empty"

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #1 from Jeff Zaroyko   2008-08-24 20:09:54 ---
Created an attachment (id=15617)
 --> (http://bugs.winehq.org/attachment.cgi?id=15617)
source

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15617|text/x-haskell              |text/plain
          mime type|                            |

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #2 from Vitaliy Margolen   2008-08-24 21:02:00 ---
How about source in c?

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #3 from Jeff Zaroyko   2008-08-24 21:14:36 ---
(In reply to comment #2)
> How about source in c?

For the moment, all I have is Haskell and the binary which reproduces the
problem, which was triggered in a much larger Haskell program (Cabal) so I've
kindly reproduced it in a few lines instead.

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #4 from Jeff Zaroyko   2008-08-26 04:08:54 ---
Created an attachment (id=15656)
 --> (http://bugs.winehq.org/attachment.cgi?id=15656)
patch for integration into wine's testsuite

Wine improperly returns success when failing to unlink a non-empty directory.

The affected programs use unlink from msvcrt, attached test shows the problem.

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #5 from Vijay Kamuju   2008-08-26 12:09:50 ---
please send the test cases to [e-mail]

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #6 from Jeff Zaroyko   2008-08-26 18:19:17 ---
(In reply to comment #5)
> please send the test cases to [e-mail]

http://www.winehq.org/pipermail/wine-patches/2008-August/060108.html

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #7 from Jeff Zaroyko   2008-08-28 17:57:16 ---
Fix and additional test sent to wine-patches:
http://winehq.org/pipermail/wine-patches/2008-August/060308.html

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

--- Comment #8 from Jeff Zaroyko   2008-09-16 18:53:19 ---
Created an attachment (id=16130)
 --> (http://bugs.winehq.org/attachment.cgi?id=16130)
proposed patch

Additional tests for NtDeleteFile, DeleteFileW and _unlink behaviours have been
committed.  This patch fixes the bug and makes those tests succeed.

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|-unknown                    |msvcrt
         Resolution|                            |FIXED

--- Comment #9 from Jeff Zaroyko   2008-09-18 09:15:27 ---
fix has been committed

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2008-09-19 11:17:42 ---
Closing bugs fixed in 1.1.5.

[Bug 14994] Haskell's removeDirectoryRecursive fails on Wine

http://bugs.winehq.org/show_bug.cgi?id=14994

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified