[Bug 22169] New: glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Summary: glPointSize errors
           Product: Wine
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

fixme:d3d:state_pscale >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from
glPointSize(...); @ state.c / 1518

Wine is spamming this message to me while running Halo 1. The problem seems to
be that glPointSize is being passed 0, which according to the documentation
(http://www.opengl.org/sdk/docs/man/xhtml/glPointSize.xml) is invalid. It is
pretty easy to see from the definition of state_pscale that the value which is
passed to glPointSize (pointSize.f) is not even touched if
stateblock->renderState[WINED3DRS_POINTSCALEENABLE] is not true.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

--- Comment #1 from Henri Verbeet   2010-03-26 14:23:52 ---
(In reply to comment #0)
> (http://www.opengl.org/sdk/docs/man/xhtml/glPointSize.xml) is invalid. It is
> pretty easy to see from the definition of state_pscale that the value which is
> passed to glPointSize (pointSize.f) is not even touched if
> stateblock->renderState[WINED3DRS_POINTSCALEENABLE] is not true.

Not entirely, it gets the initial value from
"stateblock->renderState[WINED3DRS_POINTSIZE]", interpreted as float. That's
what the union is for. Does this actually result in rendering errors in the
game? A point size of 0 doesn't sound very useful, maybe we should just ignore
those. Needs tests.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

--- Comment #2 from Ari Entlich   2010-03-26 16:23:26 ---
Ahh yes of course, I see now.

And no, it doesn't seem to cause rendering errors.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Vitaliy Margolen   2010-03-26 19:30:13 ---
> And no, it doesn't seem to cause rendering errors.

Then please don't open bugs for just some random messages you see from Wine.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
          Component|directx-d3d                 |-unknown
           Platform|All                         |Other

--- Comment #4 from Vitaliy Margolen   2010-03-26 19:30:24 ---
Closing

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Ari Entlich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
          Component|-unknown                    |directx-d3d
           Platform|Other                       |All
         Resolution|INVALID                     |

--- Comment #5 from Ari Entlich   2010-03-27 11:44:41 ---
An error occurred. A message was printed. It is therefore a bug. I've seen wine
developers react similarly to this before; I wonder why some of them don't
understand what their bug tracker is for.

Give it a low priority if you want, but do not close it.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #6 from Juan Lang   2010-03-27 12:36:06 ---
You haven't said what the error is, other than a printout to the console.  We
don't consider those bugs.  Run 'wine foo 2>/dev/null' if it bothers you.

Closing invalid again.  Please don't reopen unless you can describe an
application level problem.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Juan Lang   2010-03-27 12:36:30 ---
Re-closing invalid bug.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

--- Comment #8 from Henri Verbeet   2010-03-27 13:41:05 ---
I think GL errors should be considered bugs, although in this case perhaps not
a very important one. We shouldn't make invalid GL calls. I'll send a patch to
change checkGLcall() to reflect that.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Ari Entlich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #9 from Ari Entlich   2010-03-27 13:53:47 ---
First of all, that is an absurd thing to expect of your users. Second of all, I
did much more than give you some console output and say FIX IT.

I'm really glad that wine developers are so invested in the quality of their
project. Really.

(In reply to comment #6)
> You haven't said what the error is, other than a printout to the console.  We
> don't consider those bugs.  Run 'wine foo 2>/dev/null' if it bothers you.
>
> Closing invalid again.  Please don't reopen unless you can describe an
> application level problem.

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

--- Comment #10 from Juan Lang   2010-03-27 14:48:20 ---
(In reply to comment #9)
> First of all, that is an absurd thing to expect of your users. Second of all, I
> did much more than give you some console output and say FIX IT.
>
> I'm really glad that wine developers are so invested in the quality of their
> project. Really.

Flaming doesn't win you many friends.  In fact we are concerned about fixmes,
as a quick search of wine-devel for fixme will tell you.  Treating fixmes as
not bugs is our stated policy:
http://wiki.winehq.org/FAQ#head-51e2c09a43f0ac997f818617bec098e97170c503

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|directx-d3d                 |-unknown
           Platform|All                         |Other
         Resolution|                            |INVALID
           Severity|minor                       |enhancement

--- Comment #11 from Vitaliy Margolen   2010-03-27 21:51:15 ---
Not a bug

[Bug 22169] glPointSize errors

http://bugs.winehq.org/show_bug.cgi?id=22169

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Vitaliy Margolen   2010-03-27 21:52:11 ---
Closing. Don't reopen.

You've been told not to open bugs for _any_ messages you see from Wine unless
you actually have a problem. That's what expected from user.