https://bugs.winehq.org/show_bug.cgi?id=50151
Bug ID: 50151 Summary: World of Tanks fails to launch if LC_LANG/LC_ALL are set ja_JP Product: Wine Version: 5.21 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: ankouslash@yahoo.co.jp Distribution: ---
Created attachment 68659 --> https://bugs.winehq.org/attachment.cgi?id=68659 WoT's python.log including failed case and launched case
Since wine-4.20, World of Tanks fails to launch if LC_LANG and LC_ALL are set ja_JP.UTF-8. Error is recorded in python.log of WoT, please see attached.
Steps to reproduce: 1. Launch Wargaming.net Game Center 2. Click"PLAY" button in WORLD OF TANKS tab
Actual result: World of Tanks fails while syncing data on launching.
In the following case, WoT is launched properly: - Use wine-4.19 - Use latest wine with LC_LANG/LC_ALL=en_US.UTF-8
Version: wine & wine-staging 4.20-5.21 Platform: Arch Linux (64bit)
https://bugs.winehq.org/show_bug.cgi?id=50151
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #1 from Gijs Vermeulen gijsvrm@gmail.com --- Could you try and do a regression test?
https://wiki.winehq.org/Regression_Testing
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #2 from Mario Motohashi ankouslash@yahoo.co.jp --- Unfortunately, wine-4.19, wine-4.20 and some commits designated by git-bisect fail to build on my system (git HEAD can be built).
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #3 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Mario Motohashi from comment #2)
Unfortunately, wine-4.19, wine-4.20 and some commits designated by git-bisect fail to build on my system (git HEAD can be built).
Can you try including "-fcommon" in CFLAGS and rerunning the bisect?
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #4 from Mario Motohashi ankouslash@yahoo.co.jp --- (In reply to Gijs Vermeulen from comment #3)
(In reply to Mario Motohashi from comment #2)
Unfortunately, wine-4.19, wine-4.20 and some commits designated by git-bisect fail to build on my system (git HEAD can be built).
Can you try including "-fcommon" in CFLAGS and rerunning the bisect?
It still failed.
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #5 from Mario Motohashi ankouslash@yahoo.co.jp --- Created attachment 69010 --> https://bugs.winehq.org/attachment.cgi?id=69010 last part of failed build log
Attached is last part of failed building wine-4.20 log.
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #6 from Zebediah Figura z.figura12@gmail.com --- You may need to delete existing object files first (e.g. `make clean`).
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #7 from Gijs Vermeulen gijsvrm@gmail.com --- Also try adding -fcommon to CROSSCFLAGS as well.
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #8 from Mario Motohashi ankouslash@yahoo.co.jp --- (In reply to Gijs Vermeulen from comment #7)
Also try adding -fcommon to CROSSCFLAGS as well.
CROSSCFLAGS solved my build problem, thx. And, I was wrong. This issue occurs from wine-4.21, not 4.20.
git bisect reports as follow: c37268f0aa6da3825aa11551537b8e18aa62bdca is the first bad commit commit c37268f0aa6da3825aa11551537b8e18aa62bdca Author: Piotr Caban piotr@codeweavers.com Date: Tue Nov 19 23:14:42 2019 +0100
msvcrt: Use correct __lc_time_data fields in strftime functions.
Signed-off-by: Piotr Caban piotr@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/msvcrt/msvcrt.h | 2 + dlls/msvcrt/time.c | 164 +++++++++++++++++++++++++++++++++++---------------- 2 files changed, 115 insertions(+), 51 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=50151
Mario Motohashi ankouslash@yahoo.co.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |c37268f0aa6da3825aa11551537 | |b8e18aa62bdca
https://bugs.winehq.org/show_bug.cgi?id=50151
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com URL| |https://worldoftanks.com/en | |/game/download/ Version|5.21 |4.21
https://bugs.winehq.org/show_bug.cgi?id=50151
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=50151
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=50409
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #9 from Piotr Caban piotr.caban@gmail.com --- I can reproduce the problem. The game uses locale set to: LC_COLLATE=C;LC_CTYPE=C;LC_MONETARY=C;LC_NUMERIC=C;LC_TIME=Japanese_Japan.932 and asks for week day using "%a" format. After the patch, we're using WCHAR name and convert it to current encoding. This fails since LC_CTYPE is set to C locale. I will do some testing to figure out what's the correct fix.
https://bugs.winehq.org/show_bug.cgi?id=50151
--- Comment #10 from Piotr Caban piotr.caban@gmail.com --- The game works for me in Japanese locale now (with 560ac90ba059f663f5d9221c619355051d20678f commit). Please retest.
https://bugs.winehq.org/show_bug.cgi?id=50151
Mario Motohashi ankouslash@yahoo.co.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #11 from Mario Motohashi ankouslash@yahoo.co.jp --- (In reply to Piotr Caban from comment #10)
The game works for me in Japanese locale now (with 560ac90ba059f663f5d9221c619355051d20678f commit). Please retest.
Confirmed. WoT is launched now. Thx
https://bugs.winehq.org/show_bug.cgi?id=50151
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msvcrt Fixed by SHA1| |560ac90ba059f663f5d9221c619 | |355051d20678f
https://bugs.winehq.org/show_bug.cgi?id=50151
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.0-rc6.