[Bug 50163] New: Regression: Stack overflow in Mod Organizer 2

List overview All Threads

newer

older

[Bug 50542] New:...

[Bug 44278] New: Aldi Steuer 2017...

WineHQ Bugzilla

22 Nov 2020 22 Nov '20

10:02 a.m.

https://bugs.winehq.org/show_bug.cgi?id=50163

Bug ID: 50163 Summary: Regression: Stack overflow in Mod Organizer 2 Product: Wine Version: 5.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: rtpublic1@gmail.com Distribution: ---

Created attachment 68680 --> https://bugs.winehq.org/attachment.cgi?id=68680 Patch reverting the bad commit on top of 5.22

Since commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3, Mod Organizer 2 experiences a stack overflow during startup in the Python plugin (enabled by default).

df2b13fa77172953fed6e15c65fd6380b2d2f0d3 is the first bad commit commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3 Author: Chip Davis cdavis@codeweavers.com Date: Wed Nov 18 17:26:33 2020 +0100

msvcrt: Increment refcounts for all locale data in _get_current_locale().

Signed-off-by: Chip Davis cdavis@codeweavers.com Signed-off-by: Piotr Caban piotr@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org

dlls/msvcr90/tests/msvcr90.c | 52 ++++++++++++++++++++------------------------ dlls/msvcrt/locale.c | 19 +++++++++++++--- 2 files changed, 39 insertions(+), 32 deletions(-)

The previous commit (16598c2af6ddf0e32c5c72b9067cd2f40a470591) works. Also, reverting the bad commit on top of 5.22 works. The reverting patch is attached, just in case.

Installer download: https://github.com/ModOrganizer2/modorganizer/releases/download/v2.3.2/Mod.O... $ md5sum Mod.Organizer-2.3.2.exe ca0b3a364bc5cac33299b14202e28620 Mod.Organizer-2.3.2.exe

The installer tries to download "Visual C++ 2015-2019 Redistributable (x64)" and install it. Installation may or may not fail, I have not found any pattern here. If installing fails, click Ignore to continue. It does not affect the stack overflow either way.

After installing, start C:\Modding\MO2\ModOrganizer.exe.

If you get asked to choose an "instance", select "Portable".

The first time, you may get a crash with some .NET exception. That is a separate issue. Restart MO2, and it will ask you to disable the csharp plugin. Do so to avoid that crash.

If you get a window asking to select a game, or asking, the stack overflow does not appear and the issue is gone.

If you restart after the stack overflow, MO2 will ask to disable the python plugin (say no) and whether you wish to reinitialize the plugin (say yes to cause the crash again).

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

22 Nov 22 Nov

10:04 a.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

--- Comment #1 from rtpublic1@gmail.com --- Created attachment 68681 --> https://bugs.winehq.org/attachment.cgi?id=68681 Console output when running v5.22 without reverting (stack overflow)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:05 a.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

--- Comment #2 from rtpublic1@gmail.com --- Created attachment 68682 --> https://bugs.winehq.org/attachment.cgi?id=68682 Console output when running v5.22 plus reverting the bad commit (no stack overflow)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:05 a.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

rtpublic1@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:19 a.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

Gijs Vermeulen gijsvrm@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

23 Nov 23 Nov

9:38 a.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

--- Comment #3 from Piotr Caban piotr.caban@gmail.com --- I guess it's because we don't increase the locale->locinfo->lc_category[i].wrefcount in get_current_locale. I'll test with the application before sending the patch.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5:04 p.m.

New subject: [Bug 50163] Regression: Stack overflow in Mod Organizer 2

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |ankouslash@yahoo.co.jp

--- Comment #4 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- *** Bug 50170 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5:11 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks)

https://bugs.winehq.org/show_bug.cgi?id=50163

Zebediah Figura z.figura12@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5:12 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks)

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

--- Comment #5 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,

Also affects World of Tanks (duplicate bug 50170). Mod Organizer 2 is a smaller download. Adding link and download keyword and confirming.

Regards.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:04 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks)

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fabienmoal@wanadoo.fr

--- Comment #6 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- *** Bug 50164 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:04 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

24 Nov 24 Nov

9:13 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

Piotr Caban piotr.caban@gmail.com changed:

--- Comment #7 from Piotr Caban piotr.caban@gmail.com --- Both Mod Organizer and SWTOR is fixed by aa8891783046459508f91f47cc588b35ee8dea4e. I didn't test World of Tanks. Marking as fixed.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:33 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

--- Comment #8 from Mario Motohashi ankouslash@yahoo.co.jp --- (In reply to Piotr Caban from comment #7)

...

Both Mod Organizer and SWTOR is fixed by aa8891783046459508f91f47cc588b35ee8dea4e. I didn't test World of Tanks. Marking as fixed.

WoT works as well. Thx

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

25 Nov 25 Nov

1 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

Vijay Kamuju infyquest@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |kjandrews0@gmail.com

--- Comment #9 from Vijay Kamuju infyquest@gmail.com --- *** Bug 50185 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2:11 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

Chris Xiong chirs241097@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |chirs241097@gmail.com

--- Comment #10 from Chris Xiong chirs241097@gmail.com --- *** Bug 50178 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

29 Nov 29 Nov

11:32 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR)

https://bugs.winehq.org/show_bug.cgi?id=50163

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |aros@gmx.com

--- Comment #11 from Nikolay Sivov bunglehead@gmail.com --- *** Bug 50188 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:32 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Nikolay Sivov bunglehead@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4 Dec 4 Dec

8:36 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #12 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.0-rc1.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5 Dec 5 Dec

5:12 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq.org@eternaldusk.com

--- Comment #13 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- *** Bug 50219 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10 Dec 10 Dec

12:27 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Olivier F. R. Dierick o.dierick@piezo-forte.be changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |monsterovich@gmail.com

--- Comment #14 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- *** Bug 50300 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

12 Jan 12 Jan

11:29 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dudul04@yahoo.fr

--- Comment #15 from Alexandre Julliard julliard@winehq.org --- *** Bug 50165 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:30 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |n296869@rtrtr.com

--- Comment #16 from Alexandre Julliard julliard@winehq.org --- *** Bug 50478 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

14 Jan 14 Jan

11:47 a.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |htl10@users.sourceforge.net

--- Comment #17 from Alexandre Julliard julliard@winehq.org --- *** Bug 50476 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1 Feb 1 Feb

9:08 p.m.

New subject: [Bug 50163] Multiple applications crash with a stack overflow (Mod Organizer 2, World of Tanks, SWTOR, Audacity)

https://bugs.winehq.org/show_bug.cgi?id=50163

Anastasius Focht focht@gmx.net changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1438

Age (days ago)

1509

Last active (days ago)

wine-bugs@winehq.org

23 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla