[Bug 53222] New: shell32:shlfolder - test_SHChangeNotify() gets unexpected WM_USER_NOTIFY messages on Windows 10
https://bugs.winehq.org/show_bug.cgi?id=53222
Bug ID: 53222 Summary: shell32:shlfolder - test_SHChangeNotify() gets unexpected WM_USER_NOTIFY messages on Windows 10 Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
shell32:shlfolder - test_SHChangeNotify() gets unexpected WM_USER_NOTIFY messages on Windows 10. The exact failures vary a bit though:
shlfolder.c:5027: SHChangeNotify tests (0) ... shlfolder.c:5014: RMDIR: took 2 tries shlfolder.c:4964: verifying pidls for: RMDIR shlfolder.c:4977: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10)
or
shlfolder.c:4978: SHChangeNotify tests (0) shlfolder.c:4915: verifying pidls for: MKDIR shlfolder.c:4928: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 40000)
or
shlfolder.c:5027: SHChangeNotify tests (0) shlfolder.c:4964: verifying pidls for: MKDIR shlfolder.c:5014: MKDIR: took 2 tries shlfolder.c:4964: verifying pidls for: MKDIR shlfolder.c:4977: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 8)
or
shlfolder.c:4978: SHChangeNotify tests (1) ... shlfolder.c:4965: CREATE: took 0 tries shlfolder.c:4915: verifying pidls for: RMDIR shlfolder.c:4928: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
or
shlfolder.c:5014: CREATE: took 3 tries shlfolder.c:4960: Test failed: CREATE: expected notification type 2, got: 40000 shlfolder.c:4964: verifying pidls for: CREATE shlfolder.c:4967: Test failed: GetDisplayNameOf failed: 0x80070057 shlfolder.c:4977: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
https://test.winehq.org/data/patterns.html#shell32:shlfolder
The failures have been seen on Windows 10 1507, 21H1 and 21H2 but it is likely that the other Windows 10 versions behave the same way.
https://bugs.winehq.org/show_bug.cgi?id=53222
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=53222
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr@codeweavers.com
--- Comment #1 from François Gouget fgouget@codeweavers.com --- There is also a variant with an unexpected notification type:
shlfolder.c:5057: SHChangeNotify tests (0) ... shlfolder.c:4990: Test failed: RMDIR: expected notification type 10, got: 40000 shlfolder.c:4994: verifying pidls for: RMDIR shlfolder.c:4997: Test failed: GetDisplayNameOf failed: 0x80070057 shlfolder.c:5007: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3) shlfolder.c:5044: RMDIR: took 0 tries
Where: 0x10 == SHCNE_RMDIR 0x40000 == SHCNE_FREESPACE 0x80070057 == E_INVALIDARG and for older failure modes: 0x1 == SHCNE_RENAMEITEM 0x2 == SHCNE_CREATE 0x8 == SHCNE_MKDIR
SHCNE_FREESPACE indicates that the amount of free space on the drive has changed. So I guess that means some other process on the machine wrote some file and our test was not prepared to receive this type of notification.
Our test should find a way to be more specific about the notifications it is interested in (is requesting notifications only for a specific directory possible?); or it should simply ignore all notifications that don't match one of our test paths; or retry a few times and hope really hard that Windows Defender or some other background task did not decide to do some maintenance while the test is running.
https://bugs.winehq.org/show_bug.cgi?id=53222
--- Comment #2 from François Gouget fgouget@codeweavers.com --- Also this failure happened on w864 on 2022-07-11. That makes sense, older Windows versions also have background tasks, just a lot less than Windows 10 apparently.
https://bugs.winehq.org/show_bug.cgi?id=53222
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #3 from Piotr Caban piotr.caban@gmail.com --- It's partially addressed by b7380acb6c053ffacc96ee49bda8fc4cda1ef1c7. The tests are still sometimes failing on testbot but it's less likely now.
-
WineHQ Bugzilla