[Bug 52008] New: Star Ocean The Last Hope International crashes on startup after Wine 6.17
https://bugs.winehq.org/show_bug.cgi?id=52008
Bug ID: 52008 Summary: Star Ocean The Last Hope International crashes on startup after Wine 6.17 Product: Wine Version: 6.21 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs@winehq.org Reporter: hibbsncc1701@gmail.com Distribution: ---
On Wine 6.17 the game will start normally. (Although it complains about not being able to save a 2KB system save file. This can be bypassed, but the game will not save the player's progress. That should be tracked in a different bug.)
On Wine 6.18 and the current git, the game crashes on startup before the company logos. Bisect reveals 984f608c2885c80284ca8f35d6ad72d5193b3658 as the first bad commit.
https://bugs.winehq.org/show_bug.cgi?id=52008
Patrick Hibbs hibbsncc1701@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |984f608c2885c80284ca8f35d6a | |d72d5193b3658 Distribution|--- |Ubuntu
https://bugs.winehq.org/show_bug.cgi?id=52008
--- Comment #1 from Patrick Hibbs hibbsncc1701@gmail.com --- Created attachment 71007 --> https://bugs.winehq.org/attachment.cgi?id=71007 Backtrace of error on git master as of 11/9/2021
Sorry for taking so long with the backtrace. Winedbg didn't want to cough it up until I killed it via the terminal.
https://bugs.winehq.org/show_bug.cgi?id=52008
--- Comment #2 from Patrick Hibbs hibbsncc1701@gmail.com --- Created attachment 71015 --> https://bugs.winehq.org/attachment.cgi?id=71015 Shell32 trace on git master
OK after debugging with WINEDEBUG="+shell", we find out that it crashed attempting to resolve the path to the My Documents directory.
Looking at the prefix I found that the "My Documents" folder was a broken symlink. (Caused due to a user home directory migration.)
Fixing the symlink allowed the game to run correctly, and even fixed the saving issue. (Which means the broken symlink was to blame here as well.)
Is this the correct behavior? It would seem to me that the proper behavior would be to either:
1. Fail to resolve the broken symlink and return an error to the caller.
2. Delete the broken symlink, fall back to creating a folder within the prefix's user profile and using it instead. (Or maybe using the folder redirection support to do this so it's visible in winecfg.)
In any case, wine previously allowed this. Even if it could not open the directory, the path would still be "resolved" as far as the caller is concerned. At the very least, a warning in the console would be a nice user friendly improvement here. So that wine doesn't get inundated with "I broke my prefix" bug reports. :P
https://bugs.winehq.org/show_bug.cgi?id=52008
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org, | |xerox.xerox2000x@gmail.com Keywords| |regression
--- Comment #3 from Louis Lenders xerox.xerox2000x@gmail.com --- Hi , thanks for regressiontest. Added some info. Not sure if bugreport is valid because of that broken symlink, but i guess we`ll find out
commit 984f608c2885c80284ca8f35d6ad72d5193b3658 Author: Alexandre Julliard julliard@winehq.org Date: Wed Sep 15 09:55:32 2021 +0200
shell32: Use the standard shell folder implementation for Unix folders.
Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=52008
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Star Ocean The Last Hope |Broken symlink to 'My |International crashes on |Documents' causes app to |startup after Wine 6.17 |crash
https://bugs.winehq.org/show_bug.cgi?id=52008
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |681d2dfd9d0f6df0a0f34a75166 | |3b43369de85b2 Status|UNCONFIRMED |RESOLVED
--- Comment #4 from Alexandre Julliard julliard@winehq.org --- Most likely fixed by 681d2dfd9d0f6df0a0f34a751663b43369de85b2.
https://bugs.winehq.org/show_bug.cgi?id=52008
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc2.
-
WineHQ Bugzilla