[Bug 27536] New: XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Summary: XMLHTTP POST, server receive incorrect data
           Product: Wine
           Version: 1.3.22
          Platform: x86
               URL: http://http://netikka.net/dev/upload2.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Example: http://netikka.net/dev/upload2.exe

xmlhttp.open('POST', 'http://netikka.net/dev/debug/debug.php', true);
xmlhttp.setRequestHeader('Content-Type','application/x-www-form-urlencoded');
xmlhttp.send('test=123');

Server receive: Array([t] =>  1 2 3)

Correct (Windows): Array([test] => 123)

Run, click, results can be viewed: http://netikka.net/dev/debug/request.txt

winetricks msxml6 helps

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #1 from [e-mail] 2011-06-19 07:50:06 CDT ---
Created an attachment (id=35200)
 --> (http://bugs.winehq.org/attachment.cgi?id=35200)
Difference in binary (jpg), print_r($_REQUEST, TRUE)

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase
           Severity|normal                      |minor

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #2 from [e-mail] 2011-06-25 14:25:38 CDT ---
With these changes to "httprequest.c" POST is working.

- LONG size = SysStringLen(V_BSTR(body)) * sizeof(WCHAR);
+ LONG size = SysStringLen(V_BSTR(body));

- memcpy(ptr, V_BSTR(body), size);
+ char ansistr[size];
+ WideCharToMultiByte(CP_ACP, 0, V_BSTR(body), -1, ansistr, sizeof(ansistr),
NULL, NULL);
+ memcpy(ptr, ansistr, size);

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|http://http://netikka.net/d |http://netikka.net/dev/uplo
                   |ev/upload2.exe              |ad2.exe
                 CC|                            |[e-mail]

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #3 from [e-mail] 2011-10-26 13:21:17 CDT ---
Created attachment 37130
  --> http://bugs.winehq.org/attachment.cgi?id=37130
Small POST sample including Lazarus source

Still in 1.3.31
. If any application uses POST function to send login information,
registration, etc.. server is going to receive garbage and there is no way to
see that.

Attached small sample exe with Lazarus source.

wine posttest.exe -> click button -> it will show server response.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #4 from Bruno Jesus  2011-10-26 17:52:39 CDT ---
I can confirm this issue using the program attached. You should rebase your
patch and attach here so it gets more attention IMO.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #5 from [e-mail] 2011-10-27 01:07:27 CDT ---
Created attachment 37144
  --> http://bugs.winehq.org/attachment.cgi?id=37144
Patch for httprequest.c

Here is the patch attached, it still works.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Jerome Leclanche  2011-10-27 02:55:28 CDT ---
Please send the patch to the [e-mail] mailing list.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #7 from Bruno Jesus  2011-10-27 05:33:29 CDT ---
I think I was not clear. Your actual patch does not meet the wine coding
standards. For example, you can't declare a variable in the middle of the code.

Please read:
http://wiki.winehq.org/SubmittingPatches#head-7a578af49f1d1ab7f36f4b1f98b754...

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #8 from [e-mail] 2011-10-27 05:56:04 CDT ---
Yes, that's why I'd prefer to leave it to people who know what they are doing.
Could you fix that patch and send it, please? I don't really care who fixes
this

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #9 from Bruno Jesus  2011-10-27 06:02:41 CDT ---
I'll try but Alexandre may complain we need a test case =)
What about posting non-ascii characters like chinese. Do they arrive OK without
your patch or after your patch?

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #10 from Jerome Leclanche  2011-10-27 06:03:47 CDT ---
(In reply to comment #9)
I think those are supposed to be uriencoded in POST.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #11 from Nikolay Sivov  2011-12-18 13:47:35 CST ---
Created attachment 38021
  --> http://bugs.winehq.org/attachment.cgi?id=38021
patch

Please try this patch, before that apply this one -
http://bugs.winehq.org/attachment.cgi?id=38019. And let me know if you still
see any issues.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

--- Comment #12 from [e-mail] 2011-12-18 15:26:54 CST ---
Yes, works fine now, many thanks!

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c00bbef3e4cced74c7d0995d511
                   |                            |494433214cd2b
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Nikolay Sivov  2011-12-19 13:49:41 CST ---
Fixed with c00bbef3e4cced74c7d0995d511494433214cd2b.

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29395

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Bug 27536 depends on bug 29395, which changed state.

Bug 29395 Summary: msxml3/domdoc tests hang indefinitely
http://bugs.winehq.org/show_bug.cgi?id=29395

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

[Bug 27536] XMLHTTP POST, server receive incorrect data

http://bugs.winehq.org/show_bug.cgi?id=27536

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2011-12-30 12:57:07 CST ---
Closing bugs fixed in 1.3.36.

[Bug 27536] XMLHTTP POST, server receive incorrect data

https://bugs.winehq.org/show_bug.cgi?id=27536

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]