http://bugs.winehq.org/show_bug.cgi?id=10661
Summary: regedit imports wrong binary data from .reg files (affects FAR Manager) fix proposed Product: Wine Version: unspecified Platform: PC OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-programs AssignedTo: wine-bugs@winehq.org ReportedBy: mlg7@yandex.ru
regedit requires that a continuation line starts with exactly two spaces. If the number of spaces is not 2, it imports wrong binary data.
This bug affects the FAR Manager, namely, its encoding tables (localization). (some texts in Russian cannot be read; I think, the same problem exists for other European languages)
http://source.winehq.org/source/programs/regedit/regproc.c reads (line 570):
570 if ((c = fgetc (in)) == EOF || c != ' ' || 571 (c = fgetc (in)) == EOF || c != ' ') 572 fprintf(stderr,"%s: ERROR - invalid continuation.\n", 573 getAppName());
It should be:
do { c=fgetc(in); } while(c==' '||c=='\t'); if(c==EOF){fprintf(stderr,"%s: ERROR - invalid continuation.\n", getAppName());} ungetc(c,in);
http://bugs.winehq.org/show_bug.cgi?id=10661
--- Comment #1 from Vijay Kamuju infyquest@gmail.com 2007-12-03 19:15:07 --- Please send the fix to wine-patches in a proper diff format.
http://bugs.winehq.org/show_bug.cgi?id=10661
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2007-12-03 23:41:07 --- (In reply to comment #0)
http://source.winehq.org/source/programs/regedit/regproc.c reads (line 570): 570 if ((c = fgetc (in)) == EOF || c != ' ' || 571 (c = fgetc (in)) == EOF || c != ' ') 572 fprintf(stderr,"%s: ERROR - invalid continuation.\n", 573 getAppName()); It should be: do { c=fgetc(in); } while(c==' '||c=='\t'); if(c==EOF){fprintf(stderr,"%s: ERROR - invalid continuation.\n", getAppName());} ungetc(c,in);
It should be pretty easy to rewrite the fix to avoid the ungetc() at the end, and use the same whitespace formatting rules as the existing code does.
http://bugs.winehq.org/show_bug.cgi?id=10661
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #3 from Austin English austinenglish@gmail.com 2008-06-04 11:16:50 --- Is this still an issue in 1.0-rc3 or newer wine?
http://bugs.winehq.org/show_bug.cgi?id=10661
Alexander Nicolaysen Sørnes alex@thehandofagony.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@thehandofagony.com Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #4 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2008-07-11 09:10:41 --- Yes, the code in regedit hasn't changed. I can send a patch for it.
http://bugs.winehq.org/show_bug.cgi?id=10661
--- Comment #5 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2008-08-25 16:56:38 --- patch sent
http://bugs.winehq.org/show_bug.cgi?id=10661
Alexander Nicolaysen Sørnes alex@thehandofagony.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #6 from Alexander Nicolaysen Sørnes alex@thehandofagony.com 2008-08-28 17:17:43 --- patch applied
http://bugs.winehq.org/show_bug.cgi?id=10661
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2008-09-05 10:38:45 --- Closing bugs fixed in 1.1.4.
http://bugs.winehq.org/show_bug.cgi?id=10661
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|All |other
--- Comment #8 from Austin English austinenglish@gmail.com 2012-02-23 15:21:19 CST --- Removing deprecated 'All' OS.