[Bug 26236] New: World of Warcraft mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

Summary: World of Warcraft mouse cursor rendered upside down
                    (bisected)
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This seems to affect only the mouse cursor (everything else looks normal).  A
git bisect leads to:

3c239fa0cd00a80cdccde9f7a19e9bbf862bac4f is the first bad commit
commit 3c239fa0cd00a80cdccde9f7a19e9bbf862bac4f
Author: John Edmonds 
Date:   Sun Feb 20 22:31:26 2011 -0500

gdi32: Fixed GetDIBits for top-down bitmaps.

:040000 040000 218a5fe4328e276b38cb150d2141cf84032a063a
bb9ea3e58400949bb0e8e6a40399923686b64a53 M      dlls

[Bug 26236] World of Warcraft mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

jim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26236] World of Warcraft mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

jim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 26236] World of Warcraft mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Juan Lang  2011-02-24 15:49:33 CST ---
*** Bug 26230 has been marked as a duplicate of this bug. ***

[Bug 26236] World of Warcraft mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from André H.  2011-02-24 15:56:23 CST ---
it also renders icons from an open/save dialog upside down (e.g. notepad)

[Bug 26236] shell icons and mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|World of Warcraft mouse     |shell icons and mouse
                   |cursor rendered upside down |cursor rendered upside down
                   |(bisected)                  |(bisected)

[Bug 26236] shell icons and mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] 2011-02-24 16:30:40 CST ---
And it makes "World of Warcraft" more interesting to play, too... :-).

WoW renders a number of different custom mouse cursors, depending on what
you're doing at the time. And as of last night / this morning, they're all
upside down.

[Bug 26236] shell icons and mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #4 from Jack Edmonds  2011-02-24 17:41:19 CST ---
Created an attachment (id=33437)
 --> (http://bugs.winehq.org/attachment.cgi?id=33437)
Makes icons in the save/open file dialogs appear right side up.

This patch seems to fix the problem with upside-down icons in file dialogs
(tested from notepad), however it fails the tests I wrote.

I don't have World of Warcraft so would you mind checking if this fixes the
problem in that program?

[Bug 26236] shell icons and mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #5 from [e-mail] 2011-02-24 18:52:35 CST ---
(In reply to comment #4)
> I don't have World of Warcraft so would you mind checking if this fixes the
> problem in that program?

Yes, that patch puts Warcraft's mouse icons back the right way up. Thanks.

[Bug 26236] shell icons and mouse cursor rendered upside down (bisected)

http://bugs.winehq.org/show_bug.cgi?id=26236

Jack Edmonds  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33437|0                           |1
        is obsolete|                            |

--- Comment #6 from Jack Edmonds  2011-02-24 21:07:02 CST ---
Created an attachment (id=33438)
 --> (http://bugs.winehq.org/attachment.cgi?id=33438)
Makes icons in the save/open file dialogs appear right side up.

This patch should also fix the problem (please tell me if it doesn't) and pass
all the existing tests.

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.3.14
            Summary|shell icons and mouse       |Shell icons and mouse
                   |cursor rendered upside down |cursor rendered upside down
                   |(bisected)                  |

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #7 from [e-mail] 2011-02-25 03:07:45 CST ---
(In reply to comment #6)
> This patch should also fix the problem (please tell me if it doesn't) and pass
> all the existing tests.

Yes, this patch works for me too. Thanks.

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #8 from André H.  2011-02-25 12:08:24 CST ---
(In reply to comment #6)
> Created an attachment (id=33438)

--> (http://bugs.winehq.org/attachment.cgi?id=33438) [details]
> Makes icons in the save/open file dialogs appear right side up.
>
> This patch should also fix the problem (please tell me if it doesn't) and pass
> all the existing tests.

Patch looks fine, submit it please.
(i didn't test it, but i guess you tested the open/save dialogs and testsuite
and rankincj says WOW works with it)

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #9 from jim  2011-02-25 12:13:22 CST ---
The patch works for me as well.

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

--- Comment #10 from jim  2011-03-04 16:51:44 CST ---
The fix is in the Wine tree now.  Fixed.

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

jim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from jim  2011-03-04 16:54:25 CST ---
Fixed. Sorry for double post.

[Bug 26236] Shell icons and mouse cursor rendered upside down

http://bugs.winehq.org/show_bug.cgi?id=26236

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-03-18 14:39:13 CDT ---
Closing bugs fixed in 1.3.16.