[Bug 48335] New: Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

Bug ID: 48335
           Summary: Serious Sam Classic TFE/TSE crash on saving the game
           Product: Wine
           Version: 5.0-rc2
          Hardware: x86
               URL: https://archive.org/download/SeriousSamDemo/SeriousSam
                    Demo.exe
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66067
  --> https://bugs.winehq.org/attachment.cgi?id=66067
terminal output

The classic versions of Serious Sam (The First Encounter, The Second Encounter)
both crash when trying to perform a manual save from the menu. Autosave and
quicksave (F6) functions work properly.

Workaround: the game comes bundled with it's own version of msvcrt.dll. The
crash doesn't occur when using native msvcrt.

Can be reproduced with the demo version: start a single-player game, press
<Esc> after the game started and click on <Save> in the menu.

I tested the game with old versions of Wine and found that the crash occurs
since
https://source.winehq.org/git/wine.git/commit/22962616004e9419568808eff0bf79...

SeriousSamDemo.exe   (79M)
md5sum: ef1eb16e29941e140f4ac8fc8aac5dbc

[Bug 48335] Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
    Regression SHA1|                            |22962616004e9419568808eff0b
                   |                            |f799b33282bcf

[Bug 48335] Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

--- Comment #1 from Piotr Caban  ---
The regression is caused by 2d4b48a58d8a4a79eaf922f6b9c0375a38bce9b9.

This commit assumes that the nested_trylevel contains catchblock trylevel (that
the nested exception raised from). While in current wine it contains current
frame trylevel (or 0 if there's no nested exception). Anyway current code
doesn't make sense.

[Bug 48335] Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6babdb5508bd2f1b659218483f5
                   |                            |df76859898712
             Status|NEW                         |RESOLVED

--- Comment #2 from Béla Gyebrószki  ---
Thank you Piotr for fixing this bug.

[Bug 48335] Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 5.0-rc6.

[Bug 48335] Serious Sam Classic TFE/TSE crash on saving the game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48335

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|22962616004e9419568808eff0b |2d4b48a58d8a4a79eaf922f6b9c
                   |f799b33282bcf               |0375a38bce9b9