[Bug 23904] New: Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Summary: Starcraft II game screens are rendered upside-down in
                    1.3.0
           Product: Wine
           Version: 1.3.0
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=30009)
 --> (http://bugs.winehq.org/attachment.cgi?id=30009)
Regression test result

Version 1.3.0 introduces a bug with Starcraft 2, where the actual game screens
are rendered mostly upside down. Version 1.2-rc7 (and presumably 1.2 itself)
doesn't have this problem.

I'm currently using an ATI 4870 card with the proprietary drivers, on an x86_64
machine running Debian Sid.

Relevant-looking registry settings are:
"OffScreenRenderingMode"="backbuffer"
"DirectDrawRenderer"="opengl"

This bug (as well as another problem with setting the in-game shader settings
above 'low') does not appear when "OffScreenRenderingMode" is set to "fbo". In
"fbo" mode, however, the majority of screen real-estate is too garbled to be
usable.

Since this is a regression I performed a regression test and the results are
attached. I'll also try to upload a screenshot of the bug.

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #1 from David   2010-08-04 16:42:03 ---
Created an attachment (id=30010)
 --> (http://bugs.winehq.org/attachment.cgi?id=30010)
Screenshot of bug 23904

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jerome Leclanche   2010-08-04 16:49:02 ---
I'm positive this has something to do with OSRM (this might even be a dupe). In
WoW you can reproduce this with some of the FFX; eg. using invisibility using
backbuffer osrm.

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jerome Leclanche   2010-08-04 16:49:26 ---
CC [e-mail]

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #4 from Jeff Zaroyko   2010-08-04 16:54:55 ---
0f51c29a99299384e840e148f02aae66bfb45be is the first bad commit
commit 20f51c29a99299384e840e148f02aae66bfb45be
Author: Matteo Bruni 
Date:   Mon Jun 28 21:13:56 2010 +0200

wined3d: Setup target if offscreen rendering setting changed.

:040000 040000 fb7e4b4d38bf4a055bf3c6d72ae13e844cc7171e
cd0eeead99901e6336ec23a3fbd14344cbe1de82 M    dlls

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Tomas Zijdemans  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Tomas Zijdemans   2010-08-07 07:28:47 ---
I also get this on 1.2 with my intel 4500mhd.

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

Tomas Zijdemans  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Tomas Zijdemans   2010-08-07 07:29:27 ---
*** This bug has been confirmed by popular vote. ***

[Bug 23904] Starcraft II game screens are rendered upside-down in 1.3.0

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #7 from Matteo Bruni   2010-08-07 17:55:46 ---
Created an attachment (id=30046)
 --> (http://bugs.winehq.org/attachment.cgi?id=30046)
Possible regression fix

The attached patch fixes the regression with ORM=backbuffer for me, let me know
if it doesn't work for you. Anyway, from what I can see backbuffer mode is
still quite broken overall...

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
            Summary|Starcraft II game screens   |Starcraft II game screens
                   |are rendered upside-down in |are rendered upside-down
                   |1.3.0                       |

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

Kohen David  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Kohen David   2010-08-08 05:30:46 ---
I'll try the patch when I'll get back home...

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #9 from David   2010-08-08 08:44:12 ---
Fix seems to work for me. Cheers!

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

asow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alienswarmonwine@mailinator
                   |                            |.com

--- Comment #10 from asow   2010-08-14 22:11:12 ---
This also seems to be happening with Alien Swarm, installed from Steam.  Can
anyone verify if the patch mentioned here fixes that as well?  If so, would
this be something that might be included in an upcoming 1.3.x release of wine?

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

asow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|alienswarmonwine@mailinator |
                   |.com                        |

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

Christian Trefzer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Christian Trefzer   2010-08-16 22:32:57 ---
(In reply to comment #7)
> Created an attachment (id=30046)

--> (http://bugs.winehq.org/attachment.cgi?id=30046) [details]
> Possible regression fix
>
> The attached patch fixes the regression with ORM=backbuffer for me, let me know
> if it doesn't work for you. Anyway, from what I can see backbuffer mode is
> still quite broken overall...

I'd like to confirm the fix.  Had the same trouble with 1.3.0 on Catalyst,
applying the patch solves the issue.  Thanks a bunch!

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #12 from Jerome Leclanche   2010-08-16 23:34:51 ---
(In reply to comment #11)
> (In reply to comment #7)
> > Created an attachment (id=30046)

--> (http://bugs.winehq.org/attachment.cgi?id=30046) [details] [details]
> > Possible regression fix
> >
> > The attached patch fixes the regression with ORM=backbuffer for me, let me know
> > if it doesn't work for you. Anyway, from what I can see backbuffer mode is
> > still quite broken overall...
>
> I'd like to confirm the fix.  Had the same trouble with 1.3.0 on Catalyst,
> applying the patch solves the issue.  Thanks a bunch!

Can you test in current git? The patch was mostly applied.

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

--- Comment #13 from Christian Trefzer   2010-08-17 12:38:25 ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #7)
> > > Created an attachment (id=30046)

--> (http://bugs.winehq.org/attachment.cgi?id=30046) [details] [details] [details]
> > > Possible regression fix
> > >
> > > The attached patch fixes the regression with ORM=backbuffer for me, let me know
> > > if it doesn't work for you. Anyway, from what I can see backbuffer mode is
> > > still quite broken overall...
> >
> > I'd like to confirm the fix.  Had the same trouble with 1.3.0 on Catalyst,
> > applying the patch solves the issue.  Thanks a bunch!
>
> Can you test in current git? The patch was mostly applied.

Just installed from git, looks good there as well wrt. upside-down GL stuff. 
Seems like the issue is "mostly" fixed :)

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Detlef Riekenberg   2010-08-17 12:50:12 ---
Reported FIXED
Thanks Adys

[Bug 23904] Starcraft II game screens are rendered upside-down

http://bugs.winehq.org/show_bug.cgi?id=23904

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2010-08-20 12:39:39 ---
Closing bugs fixed in 1.3.1.