http://bugs.winehq.org/show_bug.cgi?id=34324
Bug #: 34324 Summary: QQ2013 SP1 can't install Product: Wine Version: 1.7.0 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: litimetal@gmail.com Classification: Unclassified
Created attachment 45686 --> http://bugs.winehq.org/attachment.cgi?id=45686 screenshot.png
0. download from http://dldir1.qq.com/qqfile/qq/QQ2013/QQ2013SP1/7950/QQ2013SP1.exe $ sha1sum QQ2013SP1.exe a93d2c38ebc40b422497cc56558c57af3e8b67a5 QQ2013SP1.exe 1. winetricks cjkfonts 2. wine QQ2013SP1.exe, and the installer says 'Invaild path. No permission to write to such a folder.'
http://bugs.winehq.org/show_bug.cgi?id=34324
lizhenbo litimetal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer URL| |http://dldir1.qq.com/qqfile | |/qq/QQ2013/QQ2013SP1/7950/Q | |Q2013SP1.exe CC| |fracting@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #1 from lizhenbo litimetal@gmail.com 2013-08-21 19:23:22 CDT --- Created attachment 45687 --> http://bugs.winehq.org/attachment.cgi?id=45687 terminal_output.txt
http://bugs.winehq.org/show_bug.cgi?id=34324
Johan Gardhage johan.gardhage@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johan.gardhage@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34324
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jactry92@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34324
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wzhy90@qq.com
--- Comment #2 from Qian Hong fracting@gmail.com 2013-09-15 10:00:29 CDT --- *** Bug 34523 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #3 from lizhenbo litimetal@gmail.com 2013-10-09 03:06:47 CDT --- I found this -- [8:45:1009/133739:76776528:INFO:check_path.cpp(405)] Delete file :C:\Program Files\qqtest , failed with 3 -- So I tried `touch qqtest` in C:\Program Files, and when I clicked Install(安装), this file is deleted. I'm wondering the meaning of 'failed with 3' now
http://bugs.winehq.org/show_bug.cgi?id=34324
lilydjwg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lilydjwg@gmail.com
--- Comment #4 from lilydjwg@gmail.com 2013-10-23 23:12:59 CDT --- I find that line too. Creating a file with the name "qqtest" under the specified directory works around this.
http://bugs.winehq.org/show_bug.cgi?id=34324
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|-unknown |shell32 Ever Confirmed|0 |1
--- Comment #5 from Qian Hong fracting@gmail.com 2013-10-24 04:03:38 CDT --- Thanks for testing.
Seems like a shell32 bug: 000b:Call shell32.SHFileOperationW(0dd6d624) ret=00491ad0 000b:Call ntdll.RtlAllocateHeap(00110000,00000008,00000380) ret=7e1c1a9c 000b:Ret ntdll.RtlAllocateHeap() retval=04ef37e0 ret=7e1c1a9c 000b:Call shlwapi.PathIsRelativeW(0dd6d644 L"C:\Program Files\qqtest") ret=7e1c1acc 000b:Ret shlwapi.PathIsRelativeW() retval=00000000 ret=7e1c1acc 000b:Call shlwapi.StrPBrkW(0dd6d298 L"C:\Program Files\qqtest",7e1f00e4 L"*?") ret=7e1c1b82 000b:Ret shlwapi.StrPBrkW() retval=00000000 ret=7e1c1b82 000b:Call comctl32.359(0dd6d298 L"C:\Program Files\qqtest",00000000,0000005c) ret=7e1c16ab 000b:Ret comctl32.359() retval=0dd6d2b8 ret=7e1c16ab 000b:Call KERNEL32.GetFileAttributesW(04ef2288 L"C:\Program Files\qqtest") ret=7e1c1bfd 000b:Ret KERNEL32.GetFileAttributesW() retval=ffffffff ret=7e1c1bfd 000b:Call shlwapi.PathCombineW(0dd6d260,04ef2288 L"C:\Program Files\qqtest",7e1f00e0 L"*") ret=7e1c0429 000b:Ret shlwapi.PathCombineW() retval=0dd6d260 ret=7e1c0429 000b:Call KERNEL32.FindFirstFileW(0dd6d260 L"C:\Program Files\qqtest\*",0dd6d010) ret=7e1c0444 000b:Ret KERNEL32.FindFirstFileW() retval=ffffffff ret=7e1c0444 000b:Ret shell32.SHFileOperationW() retval=00000003 ret=00491ad0
I'll take a look on it.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #6 from Qian Hong fracting@gmail.com 2013-10-24 05:21:20 CDT --- Created attachment 46397 --> http://bugs.winehq.org/attachment.cgi?id=46397 Patch: hack SHFileOperation.
Hello, please test this patch, thanks!
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #7 from lilydjwg@gmail.com 2013-10-24 05:44:20 CDT --- (In reply to comment #6)
Created attachment 46397 [details] Patch: hack SHFileOperation.
Hello, please test this patch, thanks!
This patch fixes the problem :-)
Note: I tried to install with an unclean wine prefix (with QQ and TM etc) and got errors. Retry with a clean prefix succeeded.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #8 from lizhenbo litimetal@gmail.com 2013-11-26 10:00:57 CST --- patch commited http://source.winehq.org/patches/data/100731
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #9 from Bruno Jesus 00cpxxx@gmail.com 2013-11-26 10:10:56 CST --- (In reply to comment #8)
patch commited http://source.winehq.org/patches/data/100731
You mean "patch sent" =) It was not commited yet.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #10 from Jactry Zeng jactry92@gmail.com 2013-12-01 10:08:14 CST --- Also affects to installer of TM2013 Preview2. http://dldir1.qq.com/qqfile/qq/tm/2013Preview2/7246/TM2013Preview2.exe
http://bugs.winehq.org/show_bug.cgi?id=34324
Alex Miller copmill26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |copmill26@gmail.com
--- Comment #11 from Alex Miller copmill26@gmail.com 2013-12-01 19:52:02 CST --- This bug is still present in git. It also affects QQ2013 SP5 (the latest version).
I can confirm that Qian Hong's patch fixes the problem.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #12 from lilydjwg@gmail.com 2013-12-01 23:50:59 CST --- I can confirm that lizhenbo's patch fixes the problem with QQ2013 SP1 too. I can also confirm that this patch fixes the same problem with TM2013preview2.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #13 from Qian Hong fracting@gmail.com 2013-12-02 00:27:17 CST --- Thanks for testing. Both patches are not 100% correct, they need some more work. Zhenbo is still working hard on improving the patch.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #14 from lizhenbo litimetal@gmail.com --- Created attachment 47626 --> http://bugs.winehq.org/attachment.cgi?id=47626 patch for this problem
I've send a mail to wine-devel[1], but got no response. In #winehackers, stefand suggested me not to call SetLastError(), and I'm trying to find a solution now.
Could anyone give me some advice? Thank you. [1]: http://comments.gmane.org/gmane.comp.emulators.wine.devel/97371
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #15 from lizhenbo litimetal@gmail.com --- Created attachment 47643 --> http://bugs.winehq.org/attachment.cgi?id=47643 patch without SetLastError
http://bugs.winehq.org/show_bug.cgi?id=34324
lizhenbo litimetal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #47643|0 |1 is obsolete| |
--- Comment #16 from lizhenbo litimetal@gmail.com --- Created attachment 47644 --> http://bugs.winehq.org/attachment.cgi?id=47644 patch without SetLastError
Sorry, I've made a typo using git
https://bugs.winehq.org/show_bug.cgi?id=34324
Jarkko K jarkko_korpi@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi@hotmail.com
--- Comment #17 from Jarkko K jarkko_korpi@hotmail.com --- I tried QQ2013SP1.exe with 1.7.18, still not working and showing
[49:11:0506/033121:57460339:INFO:check_path.cpp(405)] Delete file :C:\Program Files\qqtest , failed with 3
So the patch haven't merged.
You are so close fixing this, what's the issue now? Where did you find the documention how to do this?
https://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #18 from lizhenbo litimetal@gmail.com --- (In reply to Jarkko K from comment #17)
I tried QQ2013SP1.exe with 1.7.18, still not working and showing
[49:11:0506/033121:57460339:INFO:check_path.cpp(405)] Delete file :C:\Program Files\qqtest , failed with 3
So the patch haven't merged.
You are so close fixing this, what's the issue now? Where did you find the documention how to do this?
It seems that my patch is a little dirty.
I'm glad if you can join this. I've found that MSDN is buggy here, so I suggest to depend on wine's test cases/
http://bugs.winehq.org/show_bug.cgi?id=34324
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #19 from Bruno Jesus 00cpxxx@gmail.com --- Created attachment 48457 --> http://bugs.winehq.org/attachment.cgi?id=48457 another patch
Zhenbo, this is an updated version of your patch. It is working for me, please test the application again with it.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #20 from lizhenbo litimetal@gmail.com --- (In reply to Bruno Jesus from comment #19)
Created attachment 48457 [details] another patch
Zhenbo, this is an updated version of your patch. It is working for me, please test the application again with it.
This patch works for me. Thank you very much.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #21 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to lizhenbo from comment #20)
This patch works for me. Thank you very much.
Since the patch is originally yours please send it to wine-patches, lets see if it have some feedback or is commited as-is.
http://bugs.winehq.org/show_bug.cgi?id=34324
--- Comment #22 from Bruno Jesus 00cpxxx@gmail.com --- Patch commited: http://source.winehq.org/git/wine.git/?a=commit;h=2ba9ee018bce4953feb728595f...
http://bugs.winehq.org/show_bug.cgi?id=34324
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #23 from Qian Hong fracting@gmail.com --- Fixed, thanks Zhenbo and Bruno!
http://bugs.winehq.org/show_bug.cgi?id=34324
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2ba9ee018bce4953feb728595f4 | |a4a6e47b186a1
https://bugs.winehq.org/show_bug.cgi?id=34324
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #24 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.24.
https://bugs.winehq.org/show_bug.cgi?id=34324
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=37291