[Bug 20771] New: the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Summary: the menu bar doesn't work in M. Flight Simulator 98
           Product: Wine
           Version: 1.1.33
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Either in window mode or in full screen I can't select a menu entry. The menu
bar is shown but the menus don't pop up.

This is a regression between 1.1.31 and 1.1.33.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Jérôme Bouat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20769

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #1 from Austin English   2009-11-20 12:15:26 ---
Regression test?
http://wiki.winehq.org/RegressionTesting

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #2 from Jérôme Bouat   2009-11-27 09:56:22 ---
Here it is:
-----
j@j-lt:~/wine-git$ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[db79a9f2e9a5f4d82c0a910fd92ce8449cdf74e3] user32: Use client-side user handles
for menus.
j@j-lt:~/wine-git$
-----

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #3 from Andrew Nguyen   2009-11-27 09:58:25 ---
The bisect is not complete until git bisect explicitly names a bad commit.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #4 from Jérôme Bouat   2009-11-27 11:01:18 ---
Ok, new to git.

Then I think this is the final result:
-----
j@j-lt:~/wine-git$ git bisect bad
db79a9f2e9a5f4d82c0a910fd92ce8449cdf74e3 is first bad commit
commit db79a9f2e9a5f4d82c0a910fd92ce8449cdf74e3
Author: Alexandre Julliard 
Date:   Mon Oct 12 14:30:34 2009 +0200

user32: Use client-side user handles for menus.

:040000 040000 6613c952d63218ec926bd457ddca36ac1620db55
bd8b23efca3949a16c66a9724c46e808e65b8e60 M    dlls
j@j-lt:~/wine-git$
-----

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Jérôme Bouat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #5 from Jérôme Bouat   2010-02-10 04:35:34 ---
Any update on this bug whose faulty patch has been narrowed ?

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #6 from Jérôme Bouat  2010-11-02 14:39:21 CDT ---
FYI, I will stop using the WineHq Bugzilla application because any logged user
can easily tell a robot to grab email adresses, including mine.

I think an email address should always be a Bugzilla internal in order to
communicate between the bugzilla servers and the user.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #7 from Jörg Höhle  2011-02-19 14:51:04 CST ---
Created an attachment (id=33352)
 --> (http://bugs.winehq.org/attachment.cgi?id=33352)
some overlapping menus, background partly upside down

Likely bug #23471 is a duplicate of this issue.  I own only FS2002, neither '98
nor 2004, but I observe the symptoms described in bug #23471 - on Mac OS.  Cmd
is the alt key on the Apple keyboard, depending on X11.app preferences.  I can
confirm Jérôme's git bisect result.

AJ's offending commit involves release_user_handle_ptr(). My notes (from 1.3.3
time) mention fs2002.exe crash involving it:
Assertion failed: (ptr && ptr != OBJ_OTHER_PROCESS), function
release_user_handle_ptr, file win.c, line 148.

In wine-1.3.14, the top-level menu bar appears for as long as I press the cmd
key, each time with one log line
fixme:ddraw:ddraw7_FlipToGDISurface iface 0x168da0 stub!
But unlike 1.1.31, I then cannot use the mouse or keyboard to select an entry.

With git checkout db79a9f2e9a5f4d82c0a910fd92ce8449cdf74e3^
the menus are selectable even though there are some strange graphical effects,
e.g. the background becomes a bluish taint while the translucent menus  are
shown.  Part of the plane's control panel that was bottommost  gets flipped and
shown beneath the top of the screen (see screenshot). The log is
err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 59
err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 65
fixme:d3d_surface:surface_load_ds_location No up to date depth stencil location

When I exit these menus, the terminal is flooded with a thousand repetitions of
3 lines:
fixme:d3d_surface:surface_init Trying to create a render target that isn't in
the default pool.
fixme:d3d7:IDirect3DImpl_7_CreateDevice (0x185340): Only one Direct3D device
per DirectDraw object supported
fixme:d3d7:IDirect3DImpl_7_CreateDevice (0x185340): Only one Direct3D device
per DirectDraw object supported
until at some point, the cockpit view is resumed - only after I click into the
desktop window.

I don't know how this app behaves natively, but the name
ddraw7_FlipToGDISurface and the behaviour in 1.1.31 make me believe it uses two
"screen views": one for flying and one for menus (like an xterm can flip
between several views).

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |t, [e-mail]

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #8 from Jörg Höhle  2011-02-19 15:51:50 CST ---
Created an attachment (id=33353)
 --> (http://bugs.winehq.org/attachment.cgi?id=33353)
+menu log (100kB when uncompressed)

I've attached a +menu log from the time the Cmd=Alt key is pressed until after
the cockpit view is refreshed with wine-1.3.14.  The one thing that seems odd
is in the middle of it:
warn:menu:MENU_GetMenu invalid menu handle=0x390098

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #9 from Jörg Höhle  2011-02-19 15:55:27 CST ---
Created an attachment (id=33354)
 --> (http://bugs.winehq.org/attachment.cgi?id=33354)
+menu from wine-1.1.31 (130kB uncompressed)

By comparison, +menu prior to regression produces no such +warn line.
trace:menu:EnableMenuItem (0x358, 1507, 0001) !
trace:menu:MENU_SelectItem owner=0x10032 menu=0x358 index=0xffff select=0x0001
trace:menu:MENU_MoveSelection hwnd=0x10032 hmenu=0x358 off=0x0001

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #10 from Jörg Höhle  2011-02-20 15:33:36 CST ---
There's another difference between commit
db79a9f2e9a5f4d82c0a910fd92ce8449cdf74e3^ and 1.3.14: Back then fs2002 would
display the in-game hypertext (not PDF) help files from the main menu and you
could close the help window using either ESC or the close button.

1.3.14 instead, when closing the window, yields:
fixme:cursor:SetSystemCursor (0x10342,00007f00),stub!
Assertion failed: (ptr && ptr != OBJ_OTHER_PROCESS), function
release_user_handle_ptr, file win.c, line 149.
Abort trap

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from joaopa  2011-07-18 10:15:50 CDT ---
still a bug in current wine?

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |db79a9f2e9a5f4d82c0a910fd92
                   |                            |ce8449cdf74e3

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Frédéric Delanoy  2012-02-24 11:21:07 CST ---
*** Bug 23471 has been marked as a duplicate of this bug. ***

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #13 from Frédéric Delanoy  2012-02-24 11:25:35 CST ---
Is this still an issue in recent (1.4-rc4 or later) wine?

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #14 from Frédéric Delanoy  2012-02-24 11:32:44 CST ---
(In reply to comment #6)
> FYI, I will stop using the WineHq Bugzilla application because any logged user
> can easily tell a robot to grab email adresses, including mine.
>
> I think an email address should always be a Bugzilla internal in order to
> communicate between the bugzilla servers and the user.

If you stop using Bugzilla (and responding to questions), how are the devs
supposed to fix your bug. Being non-cooperative really doesn't help much.

Also, if your email appeared at least once on a specific bug page, it doesn't
matter for a bot if it appears additional times...

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #15 from Jörg Höhle  2012-02-27 15:49:09 CST ---
Still present in 1.4-rc5 on MacOS X 10.5.8 with NVidia. Oddly, the screen now
becomes mostly black while holding the Cmd key and the menu appears. Menu
entries are still unselectable. As before, every Cmd/Alt keypress produces:
fixme:ddraw:ddraw7_FlipToGDISurface iface 0x13d908 stub!

There are unrelated graphic issues in 1.4rc5, e.g. I can't correctly grab the
cockpit border to rearrange the respective dimensions of the outside and
cockpit view. The border moves, but nothing is resized. That would require
regression testing. Also, the cockpit flickers a lot, but sometimes not.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Kelytha  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Kelytha  2012-05-09 08:50:38 CDT ---
Can it be related to http://bugs.winehq.org/show_bug.cgi?id=10845 ?

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from [e-mail] 2012-10-04 20:37:06 CDT ---
Confirm, bug still very much a problem on wine, affects flight simulator 98
through 2004 from what i see, im on Wine 1.5.14 cannot access menubar at all.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]       |

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

--- Comment #18 from Frédéric Delanoy  2013-05-25 13:36:29 CDT ---
Is this still an issue in recent (1.5.31 or later) wine?

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Bruno Jesus  2013-05-26 10:42:37 CDT ---
Still in wine 1.5.31.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |cd4d71e4a27e4b9b7d3717f7d2d
                   |                            |764aaed5bff4c
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Alexandre Julliard  2013-06-27 13:40:40 CDT ---
Fixed by cd4d71e4a27e4b9b7d3717f7d2d764aaed5bff4c.

[Bug 20771] the menu bar doesn't work in M. Flight Simulator 98

http://bugs.winehq.org/show_bug.cgi?id=20771

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard  2013-06-28 15:03:27 CDT ---
Closing bugs fixed in 1.6-rc4.