[Bug 22017] New: LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Summary: LiveUpdate can not connect via proxy
           Product: Wine
           Version: 1.1.40
          Platform: x86
               URL: ftp://ftp.symantec.com/public/english_us_canada/liveup
                    date/1.8/lusetup.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=26761)
 --> (http://bugs.winehq.org/attachment.cgi?id=26761)
Wine 1.1.40 console output

LiveUpdate (tested 1.8 but will test others shortly) can not connect to the
Internet via a proxy server (tested Squid 2.7).
Wireshark shows that no attempt is made to connect to the server.

fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_DATA_RECEIVE_TIMEOUT
(120000): STUB
fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECT_TIMEOUT
(120000): STUB

Firefox 3.5.6 on the other hand works fine.

Works fine under Windows XP.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #1 from Ken Sharp   2010-03-12 10:56:15 ---
I should also add that it connects fine directly.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |wininet

--- Comment #2 from Juan Lang   2010-03-12 12:28:12 ---
You quoted part of the log, but this looks a little more relevant:
fixme:wininet:HTTP_Connect Several proxies not implemented.

I'm going to go out on a limb and guess that it's a wininet bug.  What are your
proxy settings, incidentally?  In particular, why do they have a space in them?
 You can anonymize them if you like.  I'm curious if they look like, say:
"http://a http://b", or "a b", or whether the proxy URL itself contains a
space.  Furthermore, are you configuring them through the registry, or is
wininet getting them from the environment?

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #3 from Ken Sharp   2010-03-12 13:15:50 ---
Created an attachment (id=26767)
 --> (http://bugs.winehq.org/attachment.cgi?id=26767)
Wine 1.1.40 +wininet

I should have explained about that fixme.

fixme:wininet:HTTP_Connect Several proxies not implemented.

It only appears when I have set both the HTTP proxy AND the FTP proxy via
LiveUpdate.  Setting only one or the other does not print this line in the
console.  This may be another bug.

The fixmes in my comment probably aren't relevant, they also appear when
connecting directly, I should have paid more attention.

I'm not sure where you got the spaces in the proxy from.  There are no spaces
added when configuring LiveUpdate and I can't see any indication of that in the
log.

LiveUpdate is supposed to fall back to FTP if HTTP fails, but for some reason
it doesn't.

Added a +wininet trace.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #4 from Juan Lang   2010-03-12 14:34:40 ---
Excellent, thanks.  Here's where the trouble starts to appear:

trace:wininet:InternetOpenA ("Symantec LiveUpdate", 0x00000003,
"http=localhost:3128", (null), 0x00000000)

Note the proxy server setting.  This is saved in the appinfo_t in internet.c,
line 810:
        lpwai->lpszProxy = heap_strdupW(lpszProxy);

Later, in HttpOpenRequestW, the proxy code assumes that every proxy setting
begins with "http://".  If it doesn't, it prepends it.  This leads to the
following line in the log:

trace:wininet:InternetCrackUrlW (L"http://http=localhost:3128" 0 0 0x33d40c)

Heh.  Predictably, this fails:

trace:wininet:GetAddress L"http=localhost"
trace:wininet:GetAddress failed to get IPv4 address of L"http=localhost" (No
address associated with hostname), retrying with IPv6

This type of proxy setting is allowed, see "Enabling Internet Functionality" on
MSDN:
http://msdn.microsoft.com/en-us/library/aa383996(VS.85).aspx

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #5 from Juan Lang   2010-03-12 17:26:58 ---
Created an attachment (id=26775)
 --> (http://bugs.winehq.org/attachment.cgi?id=26775)
Patch: Handle proxy entries of the form <proto>=<proxy>, and allow multiple
proxies

How does this patch work for you?

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #6 from Ken Sharp   2010-03-12 17:43:08 ---
Created an attachment (id=26776)
 --> (http://bugs.winehq.org/attachment.cgi?id=26776)
Wine 1.1.40 with patch +wininet

The result is the same.  Attached a new +wininet with the patch applied.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26775|0                           |1
        is obsolete|                            |

--- Comment #7 from Juan Lang   2010-03-12 17:54:36 ---
Created an attachment (id=26777)
 --> (http://bugs.winehq.org/attachment.cgi?id=26777)
Patch: Handle proxy entries of the form <proto>=<proxy>, and allow multiple
proxies (try 2)

Yeah, that's because I left a dumb mistake in there.  Sorry 'bout that.  Mind
trying this one?

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #8 from Ken Sharp   2010-03-12 20:13:57 ---
Yep, that's done it! :-)

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

--- Comment #9 from Juan Lang   2010-03-12 21:25:34 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2010-March/085692.html

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Juan Lang   2010-03-15 12:24:52 ---
Fixed by commit de6a0a86be0847713c58111db5dcc95bf7476d25.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2010-03-19 14:11:07 ---
Closing bugs fixed in 1.1.41.

[Bug 22017] LiveUpdate can not connect via proxy

http://bugs.winehq.org/show_bug.cgi?id=22017

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |de6a0a86be0847713c58111db5d
                   |                            |cc95bf7476d25