[Bug 38114] New: Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Bug ID: 38114
           Summary: Steam doesn't allow to install games in different
                    locations (needs GetVolumePathName implementation)
           Product: Wine
           Version: 1.7.36
          Hardware: x86
               URL: http://media.steampowered.com/client/installer/SteamSe
                    tup.exe
                OS: Linux
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

When you are about to install a game on Steam in vanilla Wine, Steam doesn't
offer the drop-down menu to choose an install location. Games are always
installed in the current prefix under C:\Program Files\Steam.

When using the patch from wine-staging the drop-down menu is available and I
can select a different partition/directory to install games (if the partition
has been set in winecfg's drives tab). 
https://github.com/wine-compholio/wine-staging/blob/master/patches/kernel32-...
> fixme:volume:GetVolumePathNameW (L"\\?\C:\", 0x33df60, 260), stub!
> fixme:volume:GetVolumePathNameW (L"\\?\D:\", 0x33df60, 260), stub!
> fixme:volume:GetVolumePathNameW (L"\\?\E:\", 0x33df60, 260), stub!
> fixme:volume:GetVolumePathNameW (L"\\?\Z:\", 0x33df60, 260), stub!

wine-1.7.36-155-g5cd0457

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #1 from Rosanne DiMesio  ---
Is this a regression since 1.7.36?

All my Steam games have been installed outside their wineprefixes using plain
Wine, and I still get the dropdown menu to select a download location in
1.7.36.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Rosanne DiMesio from comment #1)
> Is this a regression since 1.7.36?
>
> All my Steam games have been installed outside their wineprefixes using
> plain Wine, and I still get the dropdown menu to select a download location
> in 1.7.36.

Not a regression, the drop-down menu to select install location never appeared
for me when installing games in Steam using plain Wine. The menu appears when
using the patch from wine-staging.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #3 from Rosanne DiMesio  ---
Did you add any locations to Settings, Downloads, Steam Library Folders? The
dropdown list doesn't appear unless you have added at least one besides the
default.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #4 from Béla Gyebrószki  ---
(In reply to Rosanne DiMesio from comment #3)
> Did you add any locations to Settings, Downloads, Steam Library Folders? The
> dropdown list doesn't appear unless you have added at least one besides the
> default.

I didn't set anything in Settings>Downloads>Steam Library. It contains only the
default C: drive.
When installing a game with the patch applied, Steam shows a drop-down menu and
let me create a new Steam Library on drive D: etc., even though nothing is
added in Settings>Downloads>Steam Library.
This menu is missing with plain Wine.
If I add additional drive letters in the settings they're available indeed.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Robert Walker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #5 from Rosanne DiMesio  ---
I just tried Steam in an XP VM. The dropdown list does not appear there unless
additional locations are added first via Settings, Downloads, Steam Library, so
the behavior in vanilla Wine matches the behavior in Windows. Steam's Linux
client behaves the same way.

IMO, the bug is in wine-staging for allowing you to do something you couldn't
do in Windows.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #6 from Béla Gyebrószki  ---
(In reply to Rosanne DiMesio from comment #5)
> I just tried Steam in an XP VM. The dropdown list does not appear there
> unless additional locations are added first via Settings, Downloads, Steam
> Library, so the behavior in vanilla Wine matches the behavior in Windows.
> Steam's Linux client behaves the same way.
>
> IMO, the bug is in wine-staging for allowing you to do something you
> couldn't do in Windows.

Well, I don't have Windows installed so couldn't try it, but the native Linux
Steam client does *not* behave as plain Wine: it does offer the drop-down menu
even though only ~/.local/share/Steam is present by default in
Settings>Downloads>Steam Library.

Let it be invalid then...

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #7 from Nikolay Sivov  ---
I'm not sure it's invalid. Are we talking about "Install Game" menu command? It
brings up dialog where you can select existing Steam Library (on particular
drive) or use "Create New Steam Library on drive X:". So what doesn't appear?
You don't get any items in Choose location to install list?

And no, you don't have to add anything in Settings -> Downloads, instead if you
choose "Create New Steam Library" it should appear in Steam Library Folders in
Settings, that's all.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #8 from Béla Gyebrószki  ---
(In reply to Nikolay Sivov from comment #7)
> I'm not sure it's invalid. Are we talking about "Install Game" menu command?
> It brings up dialog where you can select existing Steam Library (on
> particular drive) or use "Create New Steam Library on drive X:". So what
> doesn't appear? You don't get any items in Choose location to install list?
>
> And no, you don't have to add anything in Settings -> Downloads, instead if
> you choose "Create New Steam Library" it should appear in Steam Library
> Folders in Settings, that's all.

Sorry if I was unclear in the original description of the problem.
Yes, I meant the 'Install Game' menu. The drop-down menu to choose install
location doesn't appear at all in plain Wine for me.

This image shows the difference between plain Wine and a patched Wine:
http://i.imgur.com/dxYSueI.jpg

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #9 from Bruno Jesus  ---
Different Steam versions?

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #10 from Rosanne DiMesio  ---
I've tested clicking the Install button for a game, and right-clicking the name
of a game in the Library list. Both bring up the same install dialog, and
neither includes a "Create new Steam Library on Drive X" option in Windows.
Perhaps I'm missing something obvious (it wouldn't be the first time), but I
don't see any other way to bring up the install menu.

I also just tested this on my laptop, which dual boots with Windows 7, just in
case running in a VM made a difference, and got the same behavior as Wine and
XP in a VM.

I did confuse things by mentioning the native client. I do get the option to
create a new Steam Library on the dropdown list in the Linux client, along with
the libraries I've already added, and I may have been mistaken in thinking I
had to add the libraries via settings to get the dropdown list in the first
place.

Nikolay, when you say you get the option to create a new Steam Library on X,
are you talking about the Linux client, or in Windows? Because I don't see that
at all in Windows XP or 7, even after I've added new libraries via Settings.

(In reply to Bruno Jesus from comment #9)
> Different Steam versions?

Steam automatically updates itself. The one I just tested in Windows 7 was
installed fresh today, the ones in the VM and Wine say they are up-to-date. All
my tests were in 32 bit; I don't have 64 bit Windows to test.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #11 from Erich Hoover  ---
(In reply to Rosanne DiMesio from comment #10)
> I've tested clicking the Install button for a game, and right-clicking the
> name of a game in the Library list. Both bring up the same install dialog,
> and neither includes a "Create new Steam Library on Drive X" option in
> Windows. Perhaps I'm missing something obvious (it wouldn't be the first
> time), but I don't see any other way to bring up the install menu. 
> ...

Just to be sure, do you have drives other than "C" that it can install to?  If
"C" is the only writable media it probably won't give you options for other
drives.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #12 from Erich Hoover  ---
(In reply to Erich Hoover from comment #11)
> ..
> Just to be sure, do you have drives other than "C" that it can install to? 
> If "C" is the only writable media it probably won't give you options for
> other drives.

^^ confirmed
(http://www.ghacks.net/2012/12/06/steam-alternative-installation-locations-no...):
"Please note that you only see the option if the system has another partition
or hard drive that is accessible under its own drive letter. You won't get that
option if you only have one partition on the system."

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #13 from Nikolay Sivov  ---
(In reply to Rosanne DiMesio from comment #10)
> I've tested clicking the Install button for a game, and right-clicking the
> name of a game in the Library list. Both bring up the same install dialog,
> and neither includes a "Create new Steam Library on Drive X" option in
> Windows. Perhaps I'm missing something obvious (it wouldn't be the first
> time), but I don't see any other way to bring up the install menu.
>
> I also just tested this on my laptop, which dual boots with Windows 7, just
> in case running in a VM made a difference, and got the same behavior as Wine
> and XP in a VM.

You have to make sure you have several partition, doesn't matter on same HDD or
not. It allows you to create on Library per partition as I understand it. So if
you have only C:, there's nothing to choose from.
> I did confuse things by mentioning the native client. I do get the option to
> create a new Steam Library on the dropdown list in the Linux client, along
> with the libraries I've already added, and I may have been mistaken in
> thinking I had to add the libraries via settings to get the dropdown list in
> the first place.
>
> Nikolay, when you say you get the option to create a new Steam Library on X,
> are you talking about the Linux client, or in Windows? Because I don't see
> that at all in Windows XP or 7, even after I've added new libraries via
> Settings.

I'm talking about Windows client of course, it doesn't make much sense to
compare to Linux native client.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #14 from Rosanne DiMesio  ---
(In reply to Nikolay Sivov from comment #13)
> You have to make sure you have several partition, doesn't matter on same HDD
> or not. It allows you to create on Library per partition as I understand it.
> So if you have only C:, there's nothing to choose from.

I tested XP and 7 with a flash drive plugged in and recognized by Windows in
both cases as E:. I was able to add a Steam library to that drive through
Settings, and once I did, the dropdown menu did appear in the install dialog
with that location as an option to install to.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #15 from Nikolay Sivov  ---
It could be that fixed drives only are listed automatically. USB stick doesn't
appear for me either on Windows 7, but other partitions did and I didn't have
to do anything.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #16 from Erich Hoover  ---
(In reply to Nikolay Sivov from comment #15)
> It could be that fixed drives only are listed automatically. USB stick
> doesn't appear for me either on Windows 7, but other partitions did and I
> didn't have to do anything.

They probably use some other way to detect the drive type then.  I can resubmit
the patch for this if people are ok with it (a quick look over it would be
appreciated).  I wrote it for my own personal drive configuration for Windows
Steam a while back and after it dropped off the list a few times I stopped
sending it in.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #17 from Rosanne DiMesio  ---
One minor problem I encountered with the patch is that it adds drive letters D
through H to the list of drives available to install to from the
Settings>Downloads>Steam Library Folders>Add Folders dialog, even though I
haven't mapped any such drives in winecfg. It won't actually let me create a
folder in any of those phantom drives, and having them listed there does force
me to scroll down to find Z: (which is mapped by default in and does appear to
work as expected in the dialog).

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #18 from Rosanne DiMesio  ---
Ignore my last comment; those nonexistent drives also appear on the list in
plain Wine.

[Bug 38114] Steam doesn't allow to install games in different locations (needs GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38114] Steam client doesn't allow to install games in different locations (needs kernel32.GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
             Status|REOPENED                    |NEW
                 CC|                            |[e-mail]
            Summary|Steam doesn't allow to      |Steam client doesn't allow
                   |install games in different  |to install games in
                   |locations (needs            |different locations (needs
                   |GetVolumePathName           |kernel32.GetVolumePathName
                   |implementation)             |implementation)

--- Comment #19 from Anastasius Focht  ---
Hello folks,

confirming again.
Still present with Wine 1.7.44

Regards

[Bug 38114] Steam client doesn't allow to install games in different locations (needs kernel32.GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

--- Comment #20 from Nikolay Sivov  ---
Erich's patches were committed today, starting
f6c7e247add306e757c6b75e99dd23eba087f9f8. Please retest.

[Bug 38114] Steam client doesn't allow to install games in different locations (needs kernel32.GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f6c7e247add306e757c6b75e99d
                   |                            |d23eba087f9f8
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #21 from Béla Gyebrószki  ---
Selecting install location in Steam works in wine-1.7.45-195-gda5151f, marking
fixed.

[Bug 38114] Steam client doesn't allow to install games in different locations (needs kernel32.GetVolumePathName implementation)

https://bugs.winehq.org/show_bug.cgi?id=38114

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.46.