[Bug 17290] New: DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Summary: DOSBox installer crashes on launch
           Product: Wine
           Version: 1.1.14
          Platform: Other
               URL: http://www.dosbox.com/download.php?main=1
        OS/Version: other
            Status: NEW
          Keywords: download, Installer, source
          Severity: enhancement
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

caret.c:175: ME_GetCursorCoordinates: Assertion
`!(ME_GetParagraph(pCursorRun)->member.para.nFlags & 0x01)' failed.

Native riched20 works around it. A regression according to AppDB, but haven't
verified yet.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

--- Comment #1 from Austin English   2009-02-06 23:57:23 ---
Created an attachment (id=19303)
 --> (http://bugs.winehq.org/attachment.cgi?id=19303)
terminal output/backtrace

Full backtrace.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #2 from Dylan Smith   2009-02-07 01:32:12 ---
Created an attachment (id=19304)
 --> (http://bugs.winehq.org/attachment.cgi?id=19304)
Wrap even without repaint

The assertion that failed made sure the paragraph was wrapped.  This should
have been done earlier on WM_SETFONT, however, the lParam value of 0 indicated
that it should avoid painting, and this same conditional check incorrectly
avoided wrapping the text as well.

I fixed it by separating the rewrap from repaint when handling this and another
message, so it will always rewrap and not cause assertion failures.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Austin English   2009-02-07 01:44:19 ---
Damn, that was quick. I was just posting the regression test results...:

austin@austin-desktop:~/wine-git$ git bisect bad
ea9e062b6c460b17ddc3b820dee80960b74b9369 is first bad commit
commit ea9e062b6c460b17ddc3b820dee80960b74b9369
Author: Dylan Smith 
Date:   Fri Feb 6 01:09:36 2009 -0500

richedit: Removed unnecessary calls to ME_WrapMarkedParagraphs.

These calls to ME_WrapMarkedParagraphs never do anything, and don't make
    sense to be called in these places. These places are for ME_MoveCaret,
    and ME_ArrowHome, which both don't involve any text being modified, and
    all (direct and indirect) calls to these functions are done after the
    text has already been wrapped.

:040000 040000 45e465b6c983b8fe6546963a7c0ffc745a3d4b10
ba718734b4ee94514e23952dca8388c6284b943a M      dlls

Patch works great. Thanks!

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

--- Comment #4 from Dylan Smith   2009-02-07 02:12:50 ---
(In reply to comment #3)
> Damn, that was quick. I was just posting the regression test results...:
>
> austin@austin-desktop:~/wine-git$ git bisect bad
> ea9e062b6c460b17ddc3b820dee80960b74b9369 is first bad commit
> commit ea9e062b6c460b17ddc3b820dee80960b74b9369
> Author: Dylan Smith 
> Date:   Fri Feb 6 01:09:36 2009 -0500
> richedit: Removed unnecessary calls to ME_WrapMarkedParagraphs.
>
> These calls to ME_WrapMarkedParagraphs never do anything, and don't make
> sense to be called in these places. These places are for ME_MoveCaret,
> and ME_ArrowHome, which both don't involve any text being modified, and
> all (direct and indirect) calls to these functions are done after the
> text has already been wrapped.
>
> :040000 040000 45e465b6c983b8fe6546963a7c0ffc745a3d4b10
> ba718734b4ee94514e23952dca8388c6284b943a M      dlls
>
> Patch works great. Thanks!

Seems like the problem in WM_SETFONT and EM_SETRECTNP were there before, but
the unnecessary wrapping that was removed was preventing the assertion failure.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Dylan Smith   2009-02-07 14:02:14 ---
*** Bug 17301 has been marked as a duplicate of this bug. ***

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

--- Comment #6 from [e-mail]  2009-02-07 21:58:57 ---
Also affects the Black & White 2 demo installer. Patch works fine.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Dylan Smith   2009-02-09 11:08:16 ---
My patch is in git as commit c2c2c1117e2a78830a52a8fd8091a7ce1451b54f

The patch has already been confirmed to work, and I tested to make sure, so
I'll mark this as fixed.

[Bug 17290] DOSBox installer crashes on launch

http://bugs.winehq.org/show_bug.cgi?id=17290

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2009-02-13 11:11:30 ---
Closing bugs fixed in 1.1.15.