[Bug 29350] New: Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

Bug #: 29350
           Summary: Ground Control II: opaque water
           Product: Wine
           Version: 1.3.34
          Platform: x86
               URL: http://www.fileplanet.com/141034/140000/fileinfo/Groun
                    d-Control-2:-Operation-Exodus-Demo
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 68e0cd430f2e57e55278acd2422127330628eb6d

Created attachment 37973
  --> http://bugs.winehq.org/attachment.cgi?id=37973
terminal output

Water doesn't appear correctly in the game: as if it was covered by mist
(almost completely opaque). Normally, water should be crystal clear, reflecting
the surrounded terrain, sky etc.
The problem can be observed during the cutscenes as well.
I see something similar in Guild Wars as well in the appeareance of water
(caused by the same commit).

The result of the regression test:

68e0cd430f2e57e55278acd2422127330628eb6d is the first bad commit
commit 68e0cd430f2e57e55278acd2422127330628eb6d
Author: Matteo Bruni 
Date:   Mon Dec 12 20:25:17 2011 +0100

wined3d: Ignore invalid texture transform flags.

:040000 040000 7c106cd0ea2b946d7ea8ff13b34f1c569fffcd80
a724d58aa4e05bb05f3b21404e55f3b78f9ea3c9 M    dlls

The reverted patch fixed the problem (wine-1.3.34-295-g4918d91).

Steps to reproduce the problem with the demo:

1. Install the demo as usual. Install corefonts via winetricks. Launch the
demo.
2. Choose Single Player > Campaigns then select the tutorial mission. Your
starting position is surrounded by water so you can easily observe the problem.

Fedora 16 x86
Nvidia 250 / driver 290.10
X.Org X Server 1.11.2

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

--- Comment #1 from GyB  2011-12-14 12:10:34 CST ---
Created attachment 37974
  --> http://bugs.winehq.org/attachment.cgi?id=37974
screenshot, comparison

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

--- Comment #2 from GyB  2011-12-16 09:33:34 CST ---
Created attachment 37991
  --> http://bugs.winehq.org/attachment.cgi?id=37991
screenshot (wrong floor textures in Bloodrayne 2)

In Bloodrayne 2 the floor appears as repetitive patterns when reflections are
enabled.

wine-1.3.34-353-g6fe14a0

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

--- Comment #3 from Matteo Bruni  2011-12-19 05:31:51 CST ---
Created attachment 38030
  --> http://bugs.winehq.org/attachment.cgi?id=38030
Improve invalid texture transform flags processing

Apparently D3D video drivers try very hard to make some sense from bad flags
settings. I'm writing some tests to investigate that and this patch is the
first result.
It seems to fix Ground Control 2 for me. I'd like to know if it works for you
and whether it helps for the other games too.

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

--- Comment #4 from GyB  2011-12-19 09:50:08 CST ---
(In reply to comment #3)
> Created attachment 38030 [details]
> Improve invalid texture transform flags processing
>
> Apparently D3D video drivers try very hard to make some sense from bad flags
> settings. I'm writing some tests to investigate that and this patch is the
> first result.
> It seems to fix Ground Control 2 for me. I'd like to know if it works for you
> and whether it helps for the other games too.

Thanks, the patch fixes the problem in all 3 games.

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Dmitry Timoshkov  2011-12-25 09:30:14 CST ---
*** Bug 29435 has been marked as a duplicate of this bug. ***

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Vitaliy Margolen  2011-12-28 11:28:19 CST ---
*** Bug 29363 has been marked as a duplicate of this bug. ***

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |472fed41dd6238f9aead069da1d
                   |                            |46f609daf425c
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from GyB  2011-12-28 14:33:45 CST ---
Fixed by
http://source.winehq.org/git/wine.git/commit/472fed41dd6238f9aead069da1d46f6...

Thanks a lot!

[Bug 29350] Ground Control II: opaque water

http://bugs.winehq.org/show_bug.cgi?id=29350

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2011-12-30 12:57:16 CST ---
Closing bugs fixed in 1.3.36.