[Bug 14786] New: mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Summary: mkv2vob halts with the message "error getting mkv info"
           Product: Wine
           Version: 1.1.2
          Platform: PC
               URL: http://forum.doom9.org/showthread.php?t=131782
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15331)
 --> (http://bugs.winehq.org/attachment.cgi?id=15331)
mkv2vob wine output

When using mkv2vob, using defaults (and adjusted settings), selecting a .mkv
and adding it to the list, the application halts with the error "error getting
mkv info"

Since this is one of the more useful mkv applications out there, it might be
nice to get this working with wine.

There was some output, see attachment.

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

--- Comment #1 from Vitaliy Margolen   2008-08-07 08:54:32 ---
What does that program do? And what are the mkv files?

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

--- Comment #2 from Jorn Eilander   2008-08-07 09:00:27 ---
The application is supposed to extract the video and audio stream from a .mkv
file, optionally re-encode the audio, and remux both video and audio stream to
a PS3 compatible .mpg.

It doesn't matter which .mkv file you use, none work (and since most of them
are illegal to post here, i didn't add one O:-))

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #3 from Lei Zhang   2008-08-07 13:26:44 ---
Mkv is a container format like avi. Can you make a very small sample mkv file
to test with? Just a few seconds of blank video will do.

Also, provide exact steps to reproduce the error. People reading this bug and
trying to reproduce it are probably not familiar with mkv2vob at all.

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

eisa01  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from eisa01   2008-12-30 12:27:26 ---
I have this issue on wine 1.1.9 as well, haven't been able to try it on 1.1.11
as I use the darwine builds.

I found some sample files at Perians site, and the official site you can try.
http://trac.perian.org/attachment/ticket/224/sample.mkv
http://www.matroska.org/samples/

Steps to reproduce:
1. Download and install mkv2vob: http://forum.doom9.org/showthread.php?t=131782
2. Open mkv2vob, you need to have Visual Basic 6.0 support installed
3. Under the Add file tab, you choose one of the samples as source file
4. Choose a destination directory
5. Click add file

What should happen is that it should convert the file to a new container, and,
if necessary reencode the video/audio.

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Anastasius Focht   2008-12-30 16:35:09 ---
Hello,

that VB app uses Windows Scripting Host objects to carry out some tasks - hence
you need to install WSH.

Prerequisites: winetricks vb6run wsh56

It seems that Wine's cmd.exe command line args processing can't cope with
double-double quote braindamage, e.g. double quote enclosing double quoted
paths (containing spaces).

Spawned process command line from WSH shell object "exec" method:

--- snip ---
..
0046:trace:process:CreateProcessW app (null) cmdline
L"C:\windows\system32\cmd.exe /D /C ""C:\Program
Files\mkv2vob\tools\mkvinfo.exe" "C:\Program
Files\mkv2vob\mewmew-vorbis-ssa.mkv" >
"C:\windows\temp\mewmew-vorbis-ssa.dos.txt"""
0046:trace:process:find_exe_file looking for L"C:\windows\system32\cmd.exe"
0046:trace:process:find_exe_file Trying native exe
L"C:\windows\system32\cmd.exe"
0046:trace:process:CreateProcessW starting L"C:\windows\system32\cmd.exe" as
Win32 binary (0x10000000-0x10042000)
0018:trace:process:init_current_directory starting in L"C:\Program
Files\mkv2vob\" 0x1c
0018:trace:process:__wine_kernel_init starting process
name=L"C:\windows\system32\cmd.exe"
argv[0]=L"C:\windows\system32\cmd.exe"
0046:trace:process:CreateProcessW started process pid 0047 tid 0018 
..
--- snip ---

There is a double quote pair enclosing the whole /c command string and one
around each path which contains whitespace (like "program files").

Due to use of C runtime argv[], Wine's cmd.exe gets it wrong:

--- snip ---
0018:trace:cmd:wmain Command line parm: 'L"C:\windows\system32\cmd.exe"'
0018:trace:cmd:wmain Command line parm: 'L"/D"'
0018:trace:cmd:wmain Command line parm: 'L"/C"'
0018:trace:cmd:wmain /c command line: 'L"C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt""'
0018:trace:cmd:WCMD_DumpCommands Parsed line:
0018:trace:cmd:WCMD_DumpCommands L"0012FE00 0 00 00000000 C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt" Redir:"
0018:trace:cmd:WCMD_process_commands Executing command: 'L"C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt""'
0018:trace:cmd:WCMD_execute command on entry:L"C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt"" (0x33f5a0), with
'(null)'='(null)'
0018:trace:cmd:WCMD_execute Command: 'L"C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt""'
0018:trace:cmd:WCMD_execute param1: L":\Program", param2:
L"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
0018:trace:cmd:WCMD_run_program Searching in 'L"C:\"' for 'L"Program"'
0018:trace:cmd:WCMD_run_program ASSUMING INTERNAL
0018:trace:process:CreateProcessW app (null) cmdline L"C:\Program
"Files\mkv2vob\tools\mkvinfo.exe C:\Program"
"Files\mkv2vob\mewmew-vorbis-ssa.mkv >
C:\windows\temp\mewmew-vorbis-ssa.dos.txt"" 
--- snip ---

Quickfix for the user: install and run the program from paths not containing
spaces (same applies to output directory).

A solution might be to use GetCommandLineW(), manually applying
quoting/dequoting rules and not use C runtime for (initial) argv processing.

Regards

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Ole Rasmussen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Ole Rasmussen   2010-07-04 11:39:43 ---
Seems to be fixed in 1.2-rc6.
Conversion is flawless no matter which paths I put spaces in (mkv2vob, input
file, output file etc).

Sample file: http://www.filecrop.com/11310629/index.html

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Austin English  2010-11-01 17:26:25 CDT ---
Reported fixed.

[Bug 14786] mkv2vob halts with the message "error getting mkv info"

http://bugs.winehq.org/show_bug.cgi?id=14786

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2010-11-12 13:34:08 CST ---
Closing bugs fixed in 1.3.7.