http://bugs.winehq.org/show_bug.cgi?id=33084
Bug #: 33084 Summary: installer of QQ2013 Beta2: has black spot in the dialog Product: Wine Version: 1.5.24 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus AssignedTo: wine-bugs@winehq.org ReportedBy: jactry92@gmail.com Classification: Unclassified
reproduce: 1. download it from:http://dldir1.qq.com/qqfile/qq/QQ2013/2013Beta2/7048/QQ2013Beta2.exe sha1sum QQ2013Beta2.exe 715e3f1b8577fbb017dba955bb4efedcdfa6de14 QQ2013Beta2.exe
2. 'wine QQ2013Beta2.exe'
What look like as the picture in attachment. And I found 'winetricks -q gdiplus' make it happier.
Wine version: wine-1.5.24-197-gc0a17a4
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #1 from Jactry Zeng jactry92@gmail.com 2013-02-28 08:02:54 CST --- Created attachment 43737 --> http://bugs.winehq.org/attachment.cgi?id=43737 What
http://bugs.winehq.org/show_bug.cgi?id=33084
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #43737|What |What it look like description| |
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #2 from Jactry Zeng jactry92@gmail.com 2013-02-28 08:08:14 CST --- Created attachment 43738 --> http://bugs.winehq.org/attachment.cgi?id=43738 log of +relay+gdiplus
http://bugs.winehq.org/show_bug.cgi?id=33084
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://dldir1.qq.com/qqfile | |/qq/QQ2013/2013Beta2/7048/Q | |Q2013Beta2.exe
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #3 from Vincent Povirk madewokherd@gmail.com 2013-03-02 10:43:40 CST --- Created attachment 43773 --> http://bugs.winehq.org/attachment.cgi?id=43773 possible fix
The attached patch seems to fix it, but I don't really understand why. It seems to me that a fully transparent pixel is a fully transparent pixel, and it shouldn't matter what's in the RGB channels. Nor does the application seem to do anything weird to draw it.
And I can't think of an easy way to generate a test image for this.
Dmitry, you sent a gdiplus change earlier that preserved the RGB channels when converting from ARGB -> RGB. Any thoughts on this?
http://bugs.winehq.org/show_bug.cgi?id=33084
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #4 from Dmitry Timoshkov dmitry@baikal.ru 2013-03-02 23:03:53 CST --- (In reply to comment #3)
Created attachment 43773 [details] possible fix
The attached patch seems to fix it, but I don't really understand why. It seems to me that a fully transparent pixel is a fully transparent pixel, and it shouldn't matter what's in the RGB channels. Nor does the application seem to do anything weird to draw it.
And I can't think of an easy way to generate a test image for this.
It shouldn't be too hard to create a sample PNG image with PLTE and tRNS chunks, and then check the palette returned by WIC for this image.
Dmitry, you sent a gdiplus change earlier that preserved the RGB channels when converting from ARGB -> RGB. Any thoughts on this?
That patch simply avoided sending PARGB to StretchBlt since only GdiAlphaBlend understands PARGB as input, and StretchBlt just ignores alpha from ARGB passed to it (if you mean that memcpy() patch).
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #5 from Jactry Zeng jactry92@gmail.com 2013-03-05 00:32:31 CST --- Created attachment 43809 --> http://bugs.winehq.org/attachment.cgi?id=43809 with "possible fix" patch
(In reply to comment #3) Hi Vincent, Your patch let the black spot disapper, but there was still some problem in the button on title bar. Is this another bug? Thanks.
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru 2013-03-06 01:33:03 CST --- (In reply to comment #3)
The attached patch seems to fix it, but I don't really understand why. It seems to me that a fully transparent pixel is a fully transparent pixel, and it shouldn't matter what's in the RGB channels. Nor does the application seem to do anything weird to draw it.
And I can't think of an easy way to generate a test image for this.
I've sent a palette test for a PNG image with PLTE and tRNS chunks, as expected the test doesn't pass under Wine. Feel free to send a fix.
http://bugs.winehq.org/show_bug.cgi?id=33084
Johan Gardhage johan.gardhage@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johan.gardhage@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=33084
lizhenbo litimetal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |litimetal@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #7 from Vincent Povirk madewokherd@gmail.com 2013-03-19 13:52:49 CDT --- Looks like Dmitry sent a fix: http://source.winehq.org/git/wine.git/commit/18e76792a76291c7a8211b6daa433ba...
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #8 from Jactry Zeng jactry92@gmail.com 2013-03-21 08:03:47 CDT --- Created attachment 43977 --> http://bugs.winehq.org/attachment.cgi?id=43977 With patch
(In reply to comment #7)
Looks like Dmitry sent a fix: http://source.winehq.org/git/wine.git/commit/18e76792a76291c7a8211b6daa433ba...
Thanks. :-) I retest it, and it still hava some flaws look like as the picture in attachment.
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #9 from Jactry Zeng jactry92@gmail.com 2013-03-21 08:11:02 CDT --- Created attachment 43978 --> http://bugs.winehq.org/attachment.cgi?id=43978 With native gdiplus
And I am no sure is it another bug, because I retest it with native gdiplus and it also did't display normally.
http://bugs.winehq.org/show_bug.cgi?id=33084
--- Comment #10 from Jactry Zeng jactry92@gmail.com 2013-03-21 08:37:45 CDT --- Created attachment 43979 --> http://bugs.winehq.org/attachment.cgi?id=43979 In Windows
http://bugs.winehq.org/show_bug.cgi?id=33084
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |18e76792a76291c7a8211b6daa4 | |33ba6532c840f Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #11 from Dmitry Timoshkov dmitry@baikal.ru 2013-07-15 02:33:38 CDT --- The problem with black spot has been fixed, please report any other issues as separate bug reports.
http://bugs.winehq.org/show_bug.cgi?id=33084
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org 2013-08-02 13:18:38 CDT --- Closing bugs fixed in 1.7.0.