[Bug 17683] New: ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Summary: ExpressPCB: does not properly print circuit board traces
           Product: Wine
           Version: 1.1.16
          Platform: PC
               URL: http://www.expresspcb.com/ExpressPCBHtm/Download.htm
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=19883)
 --> (http://bugs.winehq.org/attachment.cgi?id=19883)
A simple input file that will demonstrate the problem.

ExpressPCB allows for the layout of printed circuit boards.  You can either
order the boards made, or print out the pcb layout and make your own.  This
problem relates to making your own boards.

Each circuit board trace has a half-circle at each end of the trace.  The
printed output does not have these half-circles.  Thus, traces do not connect
properly.

This problem occurs in Wine release 1.0 and 1.1.16 under Linux(Ubuntu 8.04). 
The Wine package was installed using the Ubuntu package manager (Synaptic) from
your web site (binary).  The application runs correctly under Windows 98 and
Windows XP.

When you install the application (I used the XP version), two programs are
created (ExpressPCB and ExpressSCH).  This problem relates to ExpressPCB.

To duplicate this problem, run ExpressPCB and open the attached input file:
  File->Open...->(the input file)
Note that the two traces have half-circles at each end of each trace.

Now, print the (very simple) layout.
  File->Print...
  In the resulting dialog box:
    Select the appropriate printer (PDF is ok as the printer)
    Check the box "Bottom copper layer"
    Select a paper size
    Select a paper source
    Check the box "Enlarge to fit page"
    Click OK

Note in the printed output the half-circles are missing.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #1 from [e-mail]  2009-03-13 17:47:56 ---
Created an attachment (id=19919)
 --> (http://bugs.winehq.org/attachment.cgi?id=19919)
Screen shot using the test case

This shows what the traces should look like (as produced using the test case). 
Note that each trace has a semi-circle at each end.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #2 from [e-mail]  2009-03-13 17:51:51 ---
Created an attachment (id=19920)
 --> (http://bugs.winehq.org/attachment.cgi?id=19920)
Output using the test case and the print option.

This is the erroneous output from the print option.  Note that the traces do
not have the semi-circles at either end.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #3 from [e-mail]  2009-03-13 18:07:12 ---
I note that bug #8167 (abandoned) identified the same problem.  Attachments to
that report show output with the same missing semi-circles.  The bug report
referenced a different application and OS.

I suspect that any application generating graphic output and using the same
method (whatever that is) to draw filled semi-circles (maybe full circles?)
will experience the same missing components in their printed output.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #4 from [e-mail]  2009-03-15 13:06:29 ---
Created an attachment (id=19966)
 --> (http://bugs.winehq.org/attachment.cgi?id=19966)
A simple Windows program showing how the problem is generated.

This Windows program requires no user input and provides both print preview and
print options.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #5 from [e-mail]  2009-03-15 13:09:39 ---
Created an attachment (id=19968)
 --> (http://bugs.winehq.org/attachment.cgi?id=19968)
Windows code snipped that was used to generate the problem.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #6 from [e-mail]  2009-03-15 13:15:32 ---
I have created a very simple Windows application that duplicates this bug.  Any
application that draws a line using a pen object will have the problem.  If the
line is narrow then it won't be visible because the half-circle is so small. 
But for a wide trace it is quite obvious that the half-circle has been
discarded.

I have included attachments with this Windows program and a code snippet from
the program showing the required code.

The line is displayed correctly in the application window and using the print
preview.  But when the line is printed, the half-circles have been lost.

Hopefully, this simple program will make debugging the problem much easier.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19968|text/x-c++src               |text/plain
          mime type|                            |

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #7 from Austin English   2009-03-22 11:28:16 ---
(In reply to comment #6)
> I have created a very simple Windows application that duplicates this bug.  Any
> application that draws a line using a pen object will have the problem.  If the
> line is narrow then it won't be visible because the half-circle is so small. 
> But for a wide trace it is quite obvious that the half-circle has been
> discarded.
>
> I have included attachments with this Windows program and a code snippet from
> the program showing the required code.
>
> The line is displayed correctly in the application window and using the print
> preview.  But when the line is printed, the half-circles have been lost.
>
> Hopefully, this simple program will make debugging the problem much easier.

Thanks for that! It should help a lot. That area of the code doesn't get
touched much, so I'm not sure who will be able to take a look at it, or when
:-/.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #8 from Alexandre Julliard   2009-03-24 05:15:32 ---
Created an attachment (id=20099)
 --> (http://bugs.winehq.org/attachment.cgi?id=20099)
Handle pen styles in psdrv.

Give this a try.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #9 from [e-mail]  2009-03-24 13:12:22 ---
(In reply to comment #8)
> Created an attachment (id=20099)

--> (http://bugs.winehq.org/attachment.cgi?id=20099) [details]
> Handle pen styles in psdrv.
>
> Give this a try.

I am not a git user, (heck, I am barely a Linux user) 
but I did a cut and paste per your patch file and ran 
ExpressPCB and my own Windows test program, and things
worked OK (if you ignore all the FIXME messages from
ExpressPCB).  So I would say that the end-cap and join 
problem, in printing, will be fixed with the patch.  I 
was surprised that you could place several postscript 
commands on the same line.

However, in order to check the line join option, I 
created a new Windows program that drew the lines inside
a path group

pDC->BeginPath();

pDC->MoveTo(50, 200);

pDC->LineTo(250, 400);

pDC->LineTo(50, 600);

pDC->EndPath();

pDC->StrokePath();

And while the screen display and the printed output are
correct, the print preview shows the lines WAY to wide.
This problem is independent from the patch since it shows 
up in Wine before the patches.

So do we include that as part of this bug or do we call 
this bug fixed, and submit a new bug report?

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

--- Comment #10 from Alexandre Julliard   2009-03-24 14:27:20 ---
Please file a new bug, if possible with a demo executable like you did here,
this helps a lot.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Alexandre Julliard   2009-03-25 11:04:37 ---
Fixed by 36a41abb9fa0c8544d0ba4662b4938c19f7e8dbb.

[Bug 17683] ExpressPCB: does not properly print circuit board traces

http://bugs.winehq.org/show_bug.cgi?id=17683

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2009-03-27 13:56:35 ---
Closing bugs fixed in 1.1.18.