[Bug 41141] New: gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Bug ID: 41141
           Summary: gcc6: d3drm build warnings
           Product: Wine
           Version: 1.9.16
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 55347
  --> https://bugs.winehq.org/attachment.cgi?id=55347
d3drm/frame.c d3drm/light.c d3drm/meshbuilder.c log

With Debian's gcc update, new warnings appeared.

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Sergey Isakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sergey Isakov  ---
Nonsense
~~~
 ‘255 << 24’ requires 33 bits to represent
~~~
255 = 0xFF
255 << 24 = 0xFF000000 requires 32bit to represent.

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

--- Comment #2 from Nikolay Sivov  ---
(In reply to Sergey Isakov from comment #1)
> Nonsense

Not necessarily. It's undefined behavior according to standard,
because result is signed be default, and 0xff << 24 is not
representable with 32bit signed integer.

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

--- Comment #3 from Sergey Isakov  ---
The mistake is accounting this expression s int. It must be (unsigned int).
Moreover it is not arithmetic value, it is enumerator and 32bit is quite
enouth, sign can be ignored.

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
    Regression SHA1|                            |060ea15ae2c1604d51d3df1460e
                   |                            |99c7d6e6211cf
       Distribution|---                         |Debian

--- Comment #4 from Wylda  ---

Fixed by wine-1.9.22-145-g060ea15

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|060ea15ae2c1604d51d3df1460e |
                   |99c7d6e6211cf               |
      Fixed by SHA1|                            |060ea15ae2c1604d51d3df1460e
                   |                            |99c7d6e6211cf

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc2.

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x

[Bug 41141] gcc6: d3drm build warnings

https://bugs.winehq.org/show_bug.cgi?id=41141

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.7.