[Bug 17907] New: build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

Summary: build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5
           Product: Wine
           Version: 1.1.18
          Platform: PC
        OS/Version: OpenBSD
            Status: NEW
          Keywords: download, source, testcase
          Severity: blocker
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

gcc -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -I/usr/local/include
-I/usr/local/include -I/usr/local/include/libpng  -o sock.o sock.c
In file included from sock.c:28:
../../../include/ws2tcpip.h:60: error: conflicting types for `socklen_t'
/usr/include/sys/types.h:163: error: previous declaration of `socklen_t'
*** Error code 1

Going for the easy way out and using #define USE_WS_PREFIX just breaks things
worse (see attached).

Looks a bit similar to 16661, so some more includes may help, but filing a bug
for now.

Kai, perhaps you could take a look? If you need SSH access, let me know.

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

--- Comment #1 from Austin English   2009-03-31 01:23:10 ---
Created an attachment (id=20224)
 --> (http://bugs.winehq.org/attachment.cgi?id=20224)
make errors

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

--- Comment #2 from Austin English   2009-03-31 01:24:47 ---
Created an attachment (id=20225)
 --> (http://bugs.winehq.org/attachment.cgi?id=20225)
dirty hack

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English   2009-03-31 14:38:26 ---
Fixed by 65e71259df49574bb3c63ca9ba5f9d417b077fff.

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2009-04-10 11:24:52 ---
Closing bugs fixed in 1.1.19.

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

Matias Colli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Matias Colli  2012-05-02 20:52:10 CDT ---
Better solutions that comment socket.c in Makefile.in is change the
dlls/ws2_32/tests/sock.c as see bellow:

- static int do_synchronous_recvfrom ( SOCKET s, char *buf, int buflen,int
flags,struct sockaddr *from, socklen_t *fromlen, int recvlen )
+ static int do_synchronous_recvfrom ( SOCKET s, char *buf, int buflen,int
flags,struct sockaddr *from, int *fromlen, int recvlen )

and so:

-    socklen_t fromLen = sizeof(mem->addr);
+    int fromLen = sizeof(mem->addr);

Matias Colli

[Bug 17907] build broken in dlls/ws2_32/tests/sock.c on OpenBSD 4.5

http://bugs.winehq.org/show_bug.cgi?id=17907

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |65e71259df49574bb3c63ca9ba5
                   |                            |f9d417b077fff
                 CC|                            |[e-mail]

--- Comment #6 from Bruno Jesus  2012-05-02 21:00:14 CDT ---
(In reply to comment #5)
> Better solutions that comment socket.c in Makefile.in is change the
> dlls/ws2_32/tests/sock.c as see bellow:
> ...

Yes, that was the solution adopted when the bug was fixed:
http://source.winehq.org/git/wine.git/commitdiff/65e71259df49574bb3c63ca9ba5...

Try looking for open/reopened/unconfirmed bugs and avoid fixed ones =)