[Bug 28329] New: Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

Summary: Sony Vegas Pro 8.0c: MSI changes break installation
                    (regression)
           Product: Wine
           Version: 1.3.26
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Some changes in MSI code (dlls/msi/*) introduced in below commit break
installation of Sony Vegas Pro 8.0c, leaving most components uninstalled.

fe404d1d88568803e2332b4899e01cd99b2d66a6 is the first bad commit
commit fe404d1d88568803e2332b4899e01cd99b2d66a6
Author: Hans Leidekker 
Date:   Wed Jul 27 10:53:44 2011 +0200

msi: Always check the return value of MSI_IterateRecords.

--

The same problem still exists in 1.3.27 and GIT head.

Reverting the commit makes Sony Vegas Pro installation work again.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

Matti Hämäläinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

Matti Hämäläinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

--- Comment #1 from Matti Hämäläinen  2011-09-09 14:22:12 CDT ---
Forgot to say: The Vegas installer passes and finishes apparently without
errors, but lots of the program components do not get installed at all.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

--- Comment #2 from Hans Leidekker  2011-09-09 15:01:27 CDT ---
Please attach a WINEDEBUG=+msi trace.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

--- Comment #3 from Matti Hämäläinen  2011-09-09 15:47:11 CDT ---
Because the traces are large (7-8MB), I could not attach, providing links
instead:

1) Installation attempt with latest Wine GIT, to a clean prefix with following
native components installed via winetricks (required by Vegas): "corefonts
fontfix msxml3 vcrun2005 vcrun2008 quicktime76 dotnet2" This is the
installation that fails to install all components of Vegas.

http://tnsp.org/~ccr/wine_msi_vegas_issue/broken.txt

2) Same as above, but with that one changeset reverted (again to a clean
prefix, etc):

http://tnsp.org/~ccr/wine_msi_vegas_issue/working.txt

I hope this helps.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

--- Comment #4 from Hans Leidekker  2011-09-09 15:59:16 CDT ---
> err:msi:iterate_load_featurecomponents unknown component L"HKLM.VSTPath"

This suggests that you're not running latest git, which has a fix.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

--- Comment #5 from Matti Hämäläinen  2011-09-09 16:06:13 CDT ---
(In reply to comment #4)
> > err:msi:iterate_load_featurecomponents unknown component L"HKLM.VSTPath"
>
> This suggests that you're not running latest git, which has a fix.

Ahh .. seems Alexandre has pushed in some more changes while I was doing
testing. Will check.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation (regression)

http://bugs.winehq.org/show_bug.cgi?id=28329

Matti Hämäläinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Matti Hämäläinen  2011-09-09 16:34:46 CDT ---
Okay, it seems that your latest changes have fixed this issue. I guess I
bothered to start bisecting this just at the wrong time ... :( My usual luck,
as it is.

Aka: works in 1.3.28

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation

http://bugs.winehq.org/show_bug.cgi?id=28329

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Sony Vegas Pro 8.0c: MSI    |Sony Vegas Pro 8.0c: MSI
                   |changes break installation  |changes break installation
                   |(regression)                |
    Regression SHA1|                            |fe404d1d88568803e2332b4899e
                   |                            |01cd99b2d66a6

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation

http://bugs.winehq.org/show_bug.cgi?id=28329

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-09-23 12:59:23 CDT ---
Closing bugs fixed in 1.3.29.

[Bug 28329] Sony Vegas Pro 8.0c: MSI changes break installation

http://bugs.winehq.org/show_bug.cgi?id=28329

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |258fc7137fa4456b80a87472f20
                   |                            |6cf16405e68af