[Bug 57463] New: winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Bug ID: 57463
           Summary: winebus always crashing with unknown since
                    8b41c2cfddba1f9973246f61e39d4a4d92912da5
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 77463
  --> https://bugs.winehq.org/attachment.cgi?id=77463
crash log of winebus.sys

It will crash at winedevice.exe even execute winecfg

I revert de265dfa0bc41fefec3525cd6a1db5d1e1d57029 and
8b41c2cfddba1f9973246f61e39d4a4d92912da5 in previous version of wine will fix
this crash.

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

--- Comment #1 from TOM  ---
This seems fix the crash issue.

diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c
index 2522e2e6b8b..cac2eed6a12 100644
--- a/dlls/winebus.sys/main.c
+++ b/dlls/winebus.sys/main.c
@@ -597,7 +597,8 @@ static void process_hid_report(DEVICE_OBJECT *device, BYTE
*report_buf, DWORD re

if (!ext->collection_desc.ReportIDs[0].ReportID) last_report =
ext->last_reports[0];
     else last_report = ext->last_reports[report_buf[0]];
-    memcpy(last_report->buffer, report_buf, report_len);
+    if (last_report != NULL)
+        memcpy(last_report->buffer, report_buf, report_len);

if ((irp = pop_pending_read(ext)))
     {

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |de265dfa0bc41fefec3525cd6a1
                   |                            |db5d1e1d57029
                 CC|                            |[e-mail]

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|de265dfa0bc41fefec3525cd6a1 |8b41c2cfddba1f9973246f61e39
                   |db5d1e1d57029               |d4a4d92912da5

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Rémi Bernon  ---
Created attachment 77468
  --> https://bugs.winehq.org/attachment.cgi?id=77468
Additional traces

Thanks for the report, would you mind building with the attached patch to add
more traces, then making a log when it crashes with WINEDEBUG=+hid?

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

--- Comment #3 from TOM  ---
Created attachment 77469
  --> https://bugs.winehq.org/attachment.cgi?id=77469
log for +hid with patched

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

--- Comment #4 from Fabian Maurer  ---
Is this fixed with
https://gitlab.winehq.org/wine/wine/-/commit/c9592bae7f475c1b208de0a72ed29e9...

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

--- Comment #5 from TOM  ---
Yes it fixed, no longer crash

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c9592bae7f475c1b208de0a72ed
                   |                            |29e94e3017094
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Fabian Maurer  ---
Thanks, marking fixed then. Thanks Rémi!

[Bug 57463] winebus always crashing with unknown since 8b41c2cfddba1f9973246f61e39d4a4d92912da5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57463

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 10.0-rc1.