[Bug 39307] New: SkySaga installer doesn't show required disk space (msi builtin 'PrimaryVolumeSpaceRequired' property missing)
https://bugs.winehq.org/show_bug.cgi?id=39307
Bug ID: 39307 Summary: SkySaga installer doesn't show required disk space (msi builtin 'PrimaryVolumeSpaceRequired' property missing) Product: Wine Version: 1.7.51 Hardware: x86-64 OS: Linux Status: NEW Severity: trivial Priority: P2 Component: msi Assignee: wine-bugs@winehq.org Reporter: focht@gmx.net Distribution: ---
Hello folks,
as the summary says.
Found during investigation of other bugs. Similar to bug 33543 except it's not a blocker here but a cosmetic issue.
--- snip --- ... 0035:trace:msi:msi_dialog_add_control L"Static", L"Description", 00090003, L"Setup requires [PrimaryVolumeSpaceRequired] in:", 00020000 ... 0035:trace:msi:MSI_FormatRecordW L"Setup requires [PrimaryVolumeSpaceRequired] in:" ... 0035:trace:msi:msi_get_property property L"PrimaryVolumeSpaceRequired" not found ... 0035:Call user32.CreateWindowExW(00000000,7ce97900 L"Static",00198b80 L"Setup requires in:",50020000,000000d9,000000a4,00000183,00000017,00030080,00000000,00000000,00000000) ret=7ce27193 --- snip ---
MSDN: https://msdn.microsoft.com/en-us/library/windows/desktop/aa370849%28v=vs.85%...
$ sha1sum SkySagaEUInstaller.exe ee55d51213031fdf8d71475434c18ecd7caef9eb SkySagaEUInstaller.exe
$ du -sh SkySagaEUInstaller.exe 11M SkySagaEUInstaller.exe
$ wine --version wine-1.7.51-201-g60d1d6f
Regards
https://bugs.winehq.org/show_bug.cgi?id=39307
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer URL| |http://www.skysagaonline.co | |m/download/SkySagaEUInstall | |er.exe
https://bugs.winehq.org/show_bug.cgi?id=39307
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=39307
--- Comment #1 from Hans Leidekker hans@meelstraat.net --- Should be fixed by 9a5788afc1464e8b8008dd561876f12fb6ad2979.
https://bugs.winehq.org/show_bug.cgi?id=39307
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9a5788afc1464e8b8008dd56187 | |6f12fb6ad2979 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #2 from Anastasius Focht focht@gmx.net --- Hello Hans,
indeed it's fixed by commit https://source.winehq.org/git/wine.git/commitdiff/9a5788afc1464e8b8008dd5618...
Thanks.
--- snip --- ... 0035:trace:msi:msi_set_property 0x15bbf8 L"PrimaryVolumeSpaceRequired" L"19380" -1 ... 0035:trace:msi:msi_dialog_add_control L"Static", L"Description", 00090003, L"Setup requires [PrimaryVolumeSpaceRequired] in:", 00020000 ... 0035:trace:msi:MSI_FormatRecordW L"Setup requires [PrimaryVolumeSpaceRequired] in:" ... 0035:trace:msi:msi_get_property returning L"19380" for property L"PrimaryVolumeSpaceRequired" ... 0035:Call user32.CreateWindowExW(00000000,7ce97ae0 L"Static",00198d58 L"Setup requires 19380 in:",50020000,000000d9,000000a4,00000183,00000017,00030080,00000000,00000000,00000000) ret=7ce272f3 ... --- snip ---
There is still room for improvement though. This number is quite misleading since it's 512 byte units = next bug ;-)
Regards
https://bugs.winehq.org/show_bug.cgi?id=39307
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.53.
https://bugs.winehq.org/show_bug.cgi?id=39307
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.skysagaonline.co |https://web.archive.org/web |m/download/SkySagaEUInstall |/20210714052551/http://www. |er.exe |skysagaonline.com/download/ | |SkySagaEUInstaller.exe
-
wine-bugs＠winehq.org -
WineHQ Bugzilla