http://bugs.winehq.org/show_bug.cgi?id=18555
Summary: Remove irritating fixmes Product: Wine Version: 1.1.21 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: kennybobs@o2.co.uk
Created an attachment (id=21216) --> (http://bugs.winehq.org/attachment.cgi?id=21216) Screenshot of problem when trying to reuse command
I know there is already a bug open regarding noisy fixmes, but it's these two in particular I am referring to:
fixme:ntdll:NtPowerInformation Unimplemented NtPowerInformation action: 16 fixme:powrprof:DllMain (0x7e680000, 0, 0x1) not fully implemented
These two fixmes are a real pain. For example, in a command prompt:
1. Type out 'WINEDLLOVERRIDES="blah,foo,bar=n,b" WINEDEBUG="+doo,+dah" foo.exe&>/tmp/helloworld.log' and run. 2. Exit the application. 3. Press up arrow to repeat command, but backspace to edit part of the command. 4. This happens:
'WINEDLLOVERRIDES="blah,foo,bar=n,b" WINEDEBUG="+doo,+dah" foo.exe&>/tmp/hfixme:powrprof:DllMain (0x7e680000, 0, 0x1) not fully implemented
Maybe it's just my bash (which is actually dash - Ubuntu) but the fixme can not be deleted and I have to CTRL+C to make any sense of what I'm typing again. The fixmes appear multiple times and can often take me by surprise. This is irritating. The fixmes still appear after running wineserver -k and even if WINEDEBUG=fixme-all is in the command line.
These fixmes are fairly useless, can they be silenced?
http://bugs.winehq.org/show_bug.cgi?id=18555
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, FIXME, source
http://bugs.winehq.org/show_bug.cgi?id=18555
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #1 from Anastasius Focht focht@gmx.net 2009-05-21 09:22:20 --- Hello,
there was already a recent bug regarding this nuisance and I explained it there: http://bugs.winehq.org/show_bug.cgi?id=18403#c1
That bug had been closed with the advice to put a request into bug 15435 Same applies here ... you are free to make some noise in bug 15435 ;-)
Regards
http://bugs.winehq.org/show_bug.cgi?id=18555
--- Comment #2 from Ken Sharp kennybobs@o2.co.uk 2009-05-21 13:48:58 --- Created an attachment (id=21220) --> (http://bugs.winehq.org/attachment.cgi?id=21220) Fairly obvious patch
Removes the offending lines. Doesn't replace them with anything useful though.
http://bugs.winehq.org/show_bug.cgi?id=18555
--- Comment #3 from Austin English austinenglish@gmail.com 2009-05-21 15:12:05 --- (In reply to comment #2)
Created an attachment (id=21220)
--> (http://bugs.winehq.org/attachment.cgi?id=21220) [details]
Fairly obvious patch
Removes the offending lines. Doesn't replace them with anything useful though.
I sent a patch converting them to WARN's, and adding a FIXME in a comment above them: http://www.winehq.org/pipermail/wine-patches/2009-May/073229.html
http://bugs.winehq.org/show_bug.cgi?id=18555
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE
--- Comment #4 from Vitaliy Margolen vitaliy@kievinfo.com 2009-05-21 19:08:54 --- How is this fixme any special then 1000s of other fixmes?
Duplicate!
*** This bug has been marked as a duplicate of bug 15435 ***
http://bugs.winehq.org/show_bug.cgi?id=18555
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Vitaliy Margolen vitaliy@kievinfo.com 2009-05-21 19:19:52 --- Closing
http://bugs.winehq.org/show_bug.cgi?id=18555
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED Resolution|DUPLICATE |FIXED Summary|Remove irritating fixmes |Dotnet power profile fixmes | |cause irritation in | |bash/dash Difficulty|--- |Minutes
--- Comment #6 from Ken Sharp kennybobs@o2.co.uk 2009-05-22 08:42:47 --- What an incredibly generic phrase.
Two things make this different: 1. Already explained in the description. 2. This bug is FIXED.
I'll rephrase the title to make it all nice again.
http://source.winehq.org/git/wine.git?a=commit;h=81543b79c21a8c9c9761294fc31...
http://source.winehq.org/git/wine.git?a=commit;h=d4c880dfe4e8a1c547ef32fa1d5...
Thanks Austin.
Fixed.
http://bugs.winehq.org/show_bug.cgi?id=18555
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2009-05-22 11:19:54 --- Closing bugs fixed in 1.1.22.
http://bugs.winehq.org/show_bug.cgi?id=18555
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|FIXME |
http://bugs.winehq.org/show_bug.cgi?id=18555
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dotnet Fixed by SHA1| |d4c880dfe4e8a1c547ef32fa1d5 | |2d6ead214fa76