[Bug 58302] New: winedmo deprecation warnings during compilation

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58302

Bug ID: 58302
           Summary: winedmo deprecation warnings during compilation
           Product: Wine
           Version: 10.8
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: download, source
          Severity: trivial
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

/home/test/wine-git/dlls/winedmo/unix_media_type.c: In function
‘wave_format_ex_init’:
/home/test/wine-git/dlls/winedmo/unix_media_type.c:84:5: warning: ‘channels’ is
deprecated [-Wdeprecated-declarations]
   84 |     format->nChannels = params->channels;
      |     ^~~~~~
In file included from /usr/include/i386-linux-gnu/libavformat/avformat.h:314,
                 from /home/test/wine-git/dlls/winedmo/unix_private.h:28,
                 from /home/test/wine-git/dlls/winedmo/unix_media_type.c:26:
/usr/include/i386-linux-gnu/libavcodec/codec_par.h:172:14: note: declared here
  172 |     int      channels;
      |              ^~~~~~~~
/home/test/wine-git/dlls/winedmo/unix_media_type.c: In function
‘audio_format_from_codec_params’:
/home/test/wine-git/dlls/winedmo/unix_media_type.c:183:5: warning: ‘channels’
is deprecated [-Wdeprecated-declarations]
  183 |     if (!(channels = params->channels)) channels = 1;
      |     ^~
/usr/include/i386-linux-gnu/libavcodec/codec_par.h:172:14: note: declared here
  172 |     int      channels;
      |              ^~~~~~~~
/home/test/wine-git/dlls/winedmo/unix_media_type.c:184:5: warning:
‘channel_layout’ is deprecated [-Wdeprecated-declarations]
  184 |     channel_mask = params->channel_layout;
      |     ^~~~~~~~~~~~
/usr/include/i386-linux-gnu/libavcodec/codec_par.h:166:14: note: declared here
  166 |     uint64_t channel_layout;
      |              ^~~~~~~~~~~~~~

I don't see these on Ubuntu Jammy but I do on Debian Stable, the latter having
newer relevant libraries.

[Bug 58302] winedmo deprecation warnings during compilation

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58302

--- Comment #1 from Rafał Mużyło  ---
As the output clearly suggests, not only is that not a wine bug, but not a bug
in the first place.

As of ffmpeg 6.1.2 (the version I have, not necessarily one when the change was
made), the relevant portion of the header is like:

#if FF_API_OLD_CHANNEL_LAYOUT
...
    attribute_deprecated
    uint64_t channel_layout;
...
    attribute_deprecated
    int      channels;
#endif

At most the maintainer could consider porting to the new API (as hinted by
header comments), but perhaps they consider it too new.

[Bug 58302] winedmo deprecation warnings during compilation

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58302

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Rémi Bernon  ---
> At most the maintainer could consider porting to the new API (as hinted by header comments), but perhaps they consider it too new.

It is the case already, we support both.

[Bug 58302] winedmo deprecation warnings during compilation

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58302

--- Comment #3 from Ken Sharp  ---
> As the output clearly suggests, not only is that not a wine bug, but not a
> bug in the first place.

Compilation warnings are bugs.