https://bugs.winehq.org/show_bug.cgi?id=40096
Bug ID: 40096 Summary: Pendulumania: Black screen Product: Wine Version: 1.7.14 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: wylda@volny.cz Distribution: ---
I was re-testing bug 19733 and noticed a new regression.
Pendulumania is Japanese game and when started you need to select "?????". In wine-1.7.13 you can play the game with horrible psychedelic colors. See https://bugs.winehq.org/attachment.cgi?id=45292
But this was broken by wine-1.7.13-22-g4c4552c:
commit 4c4552c5a1910a9d5adf8eccff0ac62d89ffe376 Author: Ken Thomases ken@codeweavers.com Date: Wed Feb 19 16:14:53 2014 -0600
wined3d: Restore the pixel format of the window whose pixel format was actually changed.
Since this commit till wine-1.7.54 instead of Psychedelic colors it paints only "Pendulumania Working".
Between wine-1.7.54 and wine-1.7.55, where this commit was fixed/reverted, this game shows only black screen.
https://bugs.winehq.org/show_bug.cgi?id=40096
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression URL| |http://www.pcgaming.ws/game | |s/pendulumania.zip CC| |ken@codeweavers.com Distribution|--- |Debian Regression SHA1| |4c4552c5a1910a9d5adf8eccff0 | |ac62d89ffe376
--- Comment #1 from Wylda wylda@volny.cz ---
Black screen is still present in wine-1.9.3.
https://bugs.winehq.org/show_bug.cgi?id=40096
Carlton Hobbs carlton.hobbs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carlton.hobbs@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=40096
Ken Thomases ken@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=35718 Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wined3d-Revert | |_PixelFormat
--- Comment #2 from Ken Thomases ken@codeweavers.com --- Wine-Staging has this commit reverted. Does that fix it?
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #3 from Wylda wylda@volny.cz --- (In reply to Ken Thomases from comment #2)
Wine-Staging has this commit reverted. Does that fix it?
Hi Ken, no wine-staging-1.9.2 does not fix. But reverting proved, that the bisect is correct, ie. 1.7.13-22 (bad) and 1.7.13-21 (good = psychedelic).
Any other ideas what to test?
https://bugs.winehq.org/show_bug.cgi?id=40096
Sergey Isakov isakov-sl@bk.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |isakov-sl@bk.ru
--- Comment #4 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 53593 --> https://bugs.winehq.org/attachment.cgi?id=53593 How it looks with greyscale
Hey folks, I trace dthe problem and found that swapchain->palette = NULL because the application will never call an API ddraw_surface7_SetPalette() and so the palette will never assigned. On the other hand it is the game who request palette format for surface. It seems hope on Windows system palette. But in my case OSX always works in 32bit colors = no palette.
Workaround for me is creating greyscale palette. See the result on the screenshot.
PS: I don't know if stage patch mentioned above have relation to this problem.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #5 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 53594 --> https://bugs.winehq.org/attachment.cgi?id=53594 This is the patch to do the grey palette
https://bugs.winehq.org/show_bug.cgi?id=40096
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Status|STAGED |NEW
--- Comment #6 from Wylda wylda@volny.cz ---
This is the patch to do the grey palette
Nice hack, works for me too under wine-1.9.3. So now you start working on a proper fix ;))
I removed the STAGE status, because the game also doesn't work under wine-staging.
https://bugs.winehq.org/show_bug.cgi?id=40096
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=40096
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #7 from super_man@post.com --- bug 9030 is somehow similar to this one, but I was able to start it 1st time with some random palette.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #8 from Sergey Isakov isakov-sl@bk.ru --- I tested also Web Safe Color Palette but the screen looks psychedelic. No, it seems grey scale is the best solution.
There is also convert_p8_uint_b8g8r8a8_unorm() that can be patched the same way if it may resolve a bug with other game.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #9 from Sergey Isakov isakov-sl@bk.ru --- (In reply to super_man from comment #7)
bug 9030 is somehow similar to this one, but I was able to start it 1st time with some random palette.
No. The game Army Men Demo is not affected by my patch. It works with pictures as should be. Those bug can be closed fixed.
Screens quality in both games can be improved by implementing LINEAR filter and dithering. But these games are not worth of efforts.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #10 from Henri Verbeet hverbeet@gmail.com --- It's not using the Windows default palette either.
For what it's worth, images.qda contains some of the bitmaps used by the game. The format isn't very hard to figure out. (E.g. logo.bmp starts at offset 0x92dc8 and is 0x8366 bytes long.) What's interesting to note is that the palettes for the various bitmaps aren't the same. E.g., you can extract the palette from logo.bmp and make the intro logo show up correctly, but then the colors in the menu and the game itself will still be incorrect.
I suspect the game either does need to set ddraw palettes but fails to for some reason, or shouldn't be using 8-bit surfaces to start with.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #11 from Sergey Isakov isakov-sl@bk.ru --- For my mind the game should call ddraw_surface7_SetPalette() for each scene but it didn't. Wine can't know what palette is needed for next scene.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #12 from Sergey Isakov isakov-sl@bk.ru --- May be the game works through gdi32. If I set ddr=dgi I see no messages about palette but the result is negative, black screen only. Log is spammed by ~~~ trace:bitmap:CreateDIBSection format (304,-50), planes 1, bpp 8, BI_RGB, size 15200 RGB ~~~
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #13 from Henri Verbeet hverbeet@gmail.com --- Created attachment 53902 --> https://bugs.winehq.org/attachment.cgi?id=53902 hack
This hack should help. The application uses GetDeviceCaps(dc, BITSPIXEL); to get the screen depth, and essentially gets confused when it's not the 8 bpp it previously set. It might be possible to emulate 8bpp mode in winex11, I'm not sure how hard that would be.
https://bugs.winehq.org/show_bug.cgi?id=40096
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-d3d |winex11.drv
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #14 from Sergey Isakov isakov-sl@bk.ru --- Testeв шт real Windows 7-64. Main application menu is in psychodelic colors :) The game really uses default palette.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #15 from Sergey Isakov isakov-sl@bk.ru --- A note. To start the game required d3drm.dll which is not present in Windows 7. Started when I place the file in the game folder.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #16 from Sergey Isakov isakov-sl@bk.ru --- New observations. 1. wine-1.9.15-221-g2228aa1 The game works in color. No more black screen! But the colors are wrong. See screenshot. It works with both winemac or wineX11.
2. Same wine+Hack from Henri Verbeet, comment 13. It affected only on wineX11.drv and yes, the colors are correct (same as in real Windows 7). But there is only part of screen - looks like another bug with screen resolution.
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #17 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 55241 --> https://bugs.winehq.org/attachment.cgi?id=55241 No more black screen, but wrong colors
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #18 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 55242 --> https://bugs.winehq.org/attachment.cgi?id=55242 Working good with the hack.
using virtual desktop 800x600
https://bugs.winehq.org/show_bug.cgi?id=40096
--- Comment #19 from Henri Verbeet hverbeet@gmail.com --- The original regression is fixed, right? Please open a separate bug for the palette/color depth issue.
https://bugs.winehq.org/show_bug.cgi?id=40096
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #20 from winetest@luukku.com --- (In reply to Henri Verbeet from comment #19)
The original regression is fixed, right? Please open a separate bug for the palette/color depth issue.
With the hack the game seems to start with correct colors.
wine 2.0rc4-git + hack from comment 13.
I can't reproduce the palette issue.
https://bugs.winehq.org/show_bug.cgi?id=40096
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #21 from Wylda wylda@volny.cz --- (In reply to Henri Verbeet from comment #19)
The original regression is fixed, right? Please open a separate bug for the palette/color depth issue.
For me it looks like the regression is still present. I still only see the black screen in vanilla wine-2.0-rc5 instead of psychedelic colors.
But same as above, thanks to this hack game is working perfectly. So it continues in bug 42215.
Thank you Henri.
https://bugs.winehq.org/show_bug.cgi?id=40096
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #22 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.0-rc6.
-
wine-bugs＠winehq.org