[Bug 12884] New: " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

Summary: " is not a valid integer value
           Product: Wine
           Version: 0.9.59.
          Platform: PC
               URL: http://www.cmsfx.com/en/trading-software/download-vt-
                    trader/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Installing the application VT Trader works without any problems.
When I try to start the program, an "Application Error" dialog box appears with
the message

Exception EConvertError in module VTTrader.exe at 0000A98A. " is not a valid
integer value.

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal
           Keywords|                            |download

--- Comment #1 from Juan Lang   2008-04-30 11:17:17 ---
Not a blocker.  Please read severity descriptions before changing the severity.

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Austin English   2008-04-30 22:29:27 ---
Confirming. No terminal output. I'll get a +relay.

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #3 from Austin English   2008-04-30 22:30:02 ---
Created an attachment (id=12605)
 --> (http://bugs.winehq.org/attachment.cgi?id=12605)
+relay in git

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #4 from Lei Zhang   2008-05-01 00:43:28 ---
Does native oleaut32 help?

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #5 from Austin English   2008-05-01 07:51:38 ---
(In reply to comment #4)
> Does native oleaut32 help?

No.

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

gaz man  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from gaz man   2008-05-18 20:22:34 ---
Is this bug able to be solved. This program is the only thing keeping me using
windows.

[Bug 12884] " is not a valid integer value

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #7 from Louis Lenders   2008-05-19 12:12:57 ---
Created an attachment (id=13183)
 --> (http://bugs.winehq.org/attachment.cgi?id=13183)
hack to work around the crash

The attached hack (which is obviously bogus) let's the app start fine into the
login window (also needed to do 'winetricks msxml3' to work around some
msxml-bugs, but that's not where this report is about).

So apparently the application is not happy with what GetLocaleInfoA returns.
I'll attach a +locale trace later on. If someone who knows a lot of locales
could have a look, that's be nice

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |kernel32
            Summary|" is not a valid integer    |MessageBox " is not a valid
                   |value                       |integer value in Visual
                   |                            |Trading

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #8 from Louis Lenders   2008-05-19 13:15:53 ---
Created an attachment (id=13184)
 --> (http://bugs.winehq.org/attachment.cgi?id=13184)
+nls trace

here's +nls trace. Where it says "Application Error) is where the messagebox
pops up

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #9 from Louis Lenders   2008-05-19 15:59:32 ---
just a last remark: it looks as if something is wrong with Esperanto locale,
and that makes Visual Trader crash. If i just remove the following line from
dlls/kernel32/locale_rc.rc:

#include "nls/eox.nls"   /* 0x048f  LANG_ESPERANTO, SUBLANG_DEFAULT */

the login-window starts up just fine

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #10 from gaz man   2008-05-19 20:10:02 ---
It's great to see people working on this. I know a bunch of people on the
Visual Trader forum who will finally be able to get rid of windows if we can
get VT working in ubuntu :)

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #11 from Dmitry Timoshkov   2008-05-19 21:38:38 ---
(In reply to comment #9)
> just a last remark: it looks as if something is wrong with Esperanto locale,
> and that makes Visual Trader crash. If i just remove the following line from
> dlls/kernel32/locale_rc.rc:
> #include "nls/eox.nls"   /* 0x048f  LANG_ESPERANTO, SUBLANG_DEFAULT */
> the login-window starts up just fine

Does commenting out nls/eox.nls help? That's a non-standard locale, Windows
doesn't have it.

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #12 from Dmitry Timoshkov   2008-05-19 21:59:48 ---
(In reply to comment #11)
> Does commenting out nls/eox.nls help? That's a non-standard locale, Windows
> doesn't have it.

I looked at eox.nls, it's very incomplete. So, commenting it out is the right
fix.

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #13 from Louis Lenders   2008-05-20 00:33:27 ---
> Does commenting out nls/eox.nls help? That's a non-standard locale, Windows
> doesn't have it.

Yes, commenting out makes the loginwindow come up fine. Dmitry, could you send
a patch (if you think it's ok to remove it at least)

Ravi, i was not able to login with my demo account, it said the server could
not be found. That could be another bug in wine, or the server could really be
off line, i wouldn't know. When i try "Live trading" it says "Password
incorrect" which is basically correct, as i only have demo account.

Ravi, could you try if you are able to login (after applying the fix for the
first  bug>) thx

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #14 from Dmitry Timoshkov   2008-05-20 01:39:04 ---
I sent the patch:

http://www.winehq.org/pipermail/wine-patches/2008-May/054999.html

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #15 from gaz man   2008-05-20 03:32:16 ---
I could try to log in. I have 2 accounts both live and demo but don't know how
to apply patch

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #16 from Louis Lenders   2008-05-20 09:27:31 ---
apparantly Alexandre wasn't happy to remove eox.nls. He said it should be fixed
inside eox.nls. I had another look at the +nls trace and tracked down the
minimal changes needed to get this bug fixed:

diff --git a/dlls/kernel32/nls/eox.nls b/dlls/kernel32/nls/eox.nls
index 10a967f..ef3de65 100644
--- a/dlls/kernel32/nls/eox.nls
+++ b/dlls/kernel32/nls/eox.nls
@@ -45,8 +45,8 @@ STRINGTABLE LANGUAGE LANG_ESPERANTO, SUBLANG_DEFAULT
   LOCALE_ICURRENCY L"3"
   LOCALE_IDATE L"1"
   LOCALE_IDAYLZERO L""
-  LOCALE_IDEFAULTANSICODEPAGE L""
-  LOCALE_IDEFAULTCODEPAGE L""
+  LOCALE_IDEFAULTANSICODEPAGE L"1252"
+  LOCALE_IDEFAULTCODEPAGE L"66"
   LOCALE_IDEFAULTCOUNTRY L""
   LOCALE_IDEFAULTEBCDICCODEPAGE L""
   LOCALE_IDEFAULTLANGUAGE L"048f"

The numbers "1252" and "66" are bogus, i just copied them from another nls
file. Dmitry, as you know a lot of locales (i presume ;)) , could you write at
least a minimal fix for eox.nls with the correct numbers for
LOCALE_IDEFAULTANSICODEPAGE and LOCALE_IDEFAULTCODEPAGE. Thanks in advamce

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #17 from Austin English   2008-05-20 11:51:54 ---
May be of some use:
http://www.koders.com/noncode/fid142E08C0ECB50745DADAB8BF3376BDD052FFAA1F.as...

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #18 from Dmitry Timoshkov   2008-05-21 04:40:15 ---
Sent an updated patch:
http://www.winehq.org/pipermail/wine-patches/2008-May/055022.html

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #19 from Dmitry Timoshkov   2008-05-21 05:31:22 ---
The patch has been committed, please re-test, and close if appropriate.

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Louis Lenders   2008-05-21 12:39:41 ---
Yip, the bug is gone in current git. thx for sending patch dmitry.

Ravi, the fix is in next wine-release (coming out on friday). You also need to
do:
'wget http://kegel.com/wine/winetricks && sh winetricks msxml3'
because of some unimplemented stuff in wine's msxml3, but that's already
covered by other bugreports.

As stated before, i was not able to connect to the server; that could be
another wine-bug, or a problem on my side. If you run into same problem, please
open a new bugreport. Regards

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard   2008-05-23 10:37:45 ---
Closing bugs fixed in 1.0-rc2.

[Bug 12884] MessageBox " is not a valid integer value in Visual Trading

http://bugs.winehq.org/show_bug.cgi?id=12884

--- Comment #22 from gaz man   2008-06-22 04:04:21 ---
Please see and support bug 13382 so we can finally get VT Trader working with
linux/ubuntu