https://bugs.winehq.org/show_bug.cgi?id=48089
Bug ID: 48089 Summary: Origin update hangs with Esync enabled Product: Wine-staging Version: 4.19 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: sashok.olen@gmail.com CC: leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
Created attachment 65647 --> https://bugs.winehq.org/attachment.cgi?id=65647 +server
When Origin has an update available to be installed and Esync is enabled by passing WINEESYNC=1 envar, the updater hangs and never finishes. Disabling Esync solves the issue and allows Origin to complete the update. Attaching +server log. How to reproduce: 1) Create a prefix (64-bit will do) 2) Install DXVK using winetricks (app doesn't work correctly without it) 3) Add an override for OriginThinSetupInternal.exe and set it to disabled so that the app doesn't update during installation and a backup could be made for testing purposes. 4) Install an older version of Origin (you can use this link https://lutris.nyc3.cdn.digitaloceanspaces.com/games/origin/OriginSetup.exe) 5) Kill all processes in the prefix and remove override for OriginThinSetupInternal.exe 6) Run Origin.exe with WINEESYNC=1 envar passed on. Behavior with Esync disabled: Update window appears, then closes after a while, reopens and finishes the update. Behavior with Esync enabled: Update window appears, then closes but never reopens. The update hangs and never finishes. During the test, regular wine-staging build was used, but I've also tried it with a custom build that ports Fsync from Proton to Wine and it has the same issue when Fsync is in use (which it indicated in the logs).
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #1 from Zebediah Figura z.figura12@gmail.com --- Can you please attach a log with WINEDEBUG=+server,+esync,+fsync,+sync,+seh,+timestamp,+pid? Ideally please also do the same with client-side synchronization disabled. Thanks!
https://bugs.winehq.org/show_bug.cgi?id=48089
Alexandr Oleynikov sashok.olen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #65647|0 |1 is obsolete| |
--- Comment #2 from Alexandr Oleynikov sashok.olen@gmail.com --- Created attachment 65665 --> https://bugs.winehq.org/attachment.cgi?id=65665 WINEESYNC=1,+server,+esync,+fsync,+sync,+seh,+timestamp,+pid
Sure, here:
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #3 from Alexandr Oleynikov sashok.olen@gmail.com --- And here's with Esync off (WINEESYNC=0) https://drive.google.com/open?id=1HF3-xgCL_3njmPGqIdQxWKYKSOPSynZl
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #4 from Zebediah Figura z.figura12@gmail.com --- Looks like it depends on mutex abandonment, which is something not yet implemented.
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #5 from Alexandr Oleynikov sashok.olen@gmail.com --- It that something that's going to be hard to implement? Btw, since EA is coming back to Steam and their new games are going to come with Origin, this will soon become an issue for Proton as well (with the release of STAR WARS Jedi: Fallen Order).
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #6 from Zebediah Figura z.figura12@gmail.com --- Not especially hard, but I don't know when I'll have the time to spend on it.
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #7 from Alexandr Oleynikov sashok.olen@gmail.com --- Seems like Esync also causes Origin to fail to install and leads to a hang on startup. I don't know for sure whether it's due to lack of mutex abandonment though.
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #8 from Zebediah Figura z.figura12@gmail.com --- Should be fixed by https://github.com/wine-staging/wine-staging/commit/8b2fd051c97187c68dee2ba2f0df7aca65c4cca6; can you please retest?
https://bugs.winehq.org/show_bug.cgi?id=48089
--- Comment #9 from Alexandr Oleynikov sashok.olen@gmail.com --- With that it indeed works, thanks!
https://bugs.winehq.org/show_bug.cgi?id=48089
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |8b2fd051c97187c68dee2ba2f0d | |f7aca65c4cca6 Resolution|--- |FIXED
--- Comment #10 from Zebediah Figura z.figura12@gmail.com --- (In reply to Alexandr Oleynikov from comment #9)
With that it indeed works, thanks!
Thanks, closing then.
https://bugs.winehq.org/show_bug.cgi?id=48089
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Zebediah Figura z.figura12@gmail.com --- Closing bugs fixed in wine-staging 5.3.