[Bug 48571] New: Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Bug ID: 48571
           Summary: Firefox 72.0.* crashes on every tab (unless dwrite is
                    disabled)
           Product: Wine
           Version: 5.0
          Hardware: x86
               URL: https://download-installer.cdn.mozilla.net/pub/firefox
                    /releases/72.0.2/win64/en-US/Firefox%20Setup%2072.0.2.
                    msi
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: dwrite
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

Created attachment 66397
  --> https://bugs.winehq.org/attachment.cgi?id=66397
+dwrite log

As the title says. Tested in Staging-5.1 as firefox doesn`t work in vanilla
wine.

For convenience one could copy paste this one liner in the console:

wget
https://download-installer.cdn.mozilla.net/pub/firefox/releases/72.0.2/win64...
&& /opt/wine-staging/bin/wine msiexec /i ./"Firefox Setup 72.0.2.msi" /qn &&
/opt/wine-staging/bin/wine "c:\Program 
Files\Mozilla Firefox\firefox.exe" www.winehq.org

Firefox says: "Gah your tab just crashed"

If you disable dwrite the browser works (apart from some issues) rather well

Attached +seh,dwrite log, quite huge unfortunately

Maybe trouble begin at 
005e:trace:dwrite:dwritefontresource_Release 0xd850c80, refcount 0.
005e:trace:dwrite:shareddwritefactory_Release 0xd756670.
005e:trace:dwrite:dwritefontfile_Release (0xd758940)->(5)
005e:trace:dwrite:dwritefont_AddRef (0xd82b600)->(3)
005e:trace:seh:raise_exception code=c0000005 flags=0 addr=0x167dd4e ip=167dd4e
tid=005e

but that`s just a shot in the dark

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

--- Comment #1 from Nikolay Sivov  ---
It's probably missing about unimplemented method, that we actually call
internally:

---
0071:0072:trace:dwrite:dwritefontresource_CreateFontFace 0xf83f120, 0x1,
0x922620, 0, 0x922590.
0071:0072:trace:dwrite:dwritefactory6_CreateFontFaceReference 0x8dc6d20,
0x8dcc260, 0, 0x1, 0x922620, 0, 0x922430.
0071:0072:trace:dwrite:shareddwritefactory_AddRef 0x8dc6d20.
0071:0072:trace:dwrite:dwritefontfile_AddRef (0x8dcc260)->(7)
0071:0072:fixme:dwrite:fontfacereference1_CreateFontFace 0xf83f160, 0x922590.
0071:0072:trace:dwrite:fontfacereference_Release 0xf83f160, refcount 0.
0071:0072:trace:dwrite:dwritefontfile_Release (0x8dcc260)->(6)
0071:0072:trace:dwrite:shareddwritefactory_Release 0x8dc6d20.
0071:0072:trace:dwrite:dwritefontresource_Release 0xf83f120, refcount 0.
0071:0072:trace:dwrite:shareddwritefactory_Release 0x8dc6d20.
0071:0072:trace:dwrite:dwritefontfile_Release (0x8dcc260)->(5)
0071:0072:trace:dwrite:dwritefont_AddRef (0xf822d20)->(3)
0071:0072:trace:seh:raise_exception code=c0000005 flags=0 addr=0x167dd4e
ip=167dd4e tid=0072 
---

This most likely indicates insufficient error handling on Skia side, but it's
easy to implement partially, without support for variations. I'll take a look.

P.S. it was unable to get that far with vanilla wine unfortunately, something
in staging fixes it.

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Louis Lenders  ---
(In reply to Nikolay Sivov from comment #1)
> It's probably missing about unimplemented method, that we actually call
> internally:

Hi Nikolay, thanks for looking into this.

I tried your patch at mailinglist
(https://www.winehq.org/pipermail/wine-devel/2020-February/159447.html) and
applied on top of staging and it fixes the bug, 
firefox can now load various webpages without crashing. Once the patch gets in
this bug can be closed.

Thanks again and Regards

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6ee109c5aab14ef7382b69a9286
                   |                            |2cd740ffd0ef2
             Status|NEW                         |RESOLVED

--- Comment #3 from Nikolay Sivov  ---
Marking fixed,
https://source.winehq.org/git/wine.git/commit/6ee109c5aab14ef7382b69a92862cd....
Thanks for testing.

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 5.2.

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0.x

[Bug 48571] Firefox 72.0.* crashes on every tab (unless dwrite is disabled)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48571

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 5.0.x milestone from bug fixes included in 5.0.1.